mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
68 lines
1.9 KiB
Python
68 lines
1.9 KiB
Python
"""Tests for the monitoring emitter: hot-path invariant + subscriber fan-out."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import time
|
|
import threading
|
|
|
|
from agent.monitoring.emitter import MonitoringEmitter
|
|
from agent.monitoring.events import GatewayHealthEvent
|
|
|
|
|
|
def test_emit_never_raises_when_disabled():
|
|
em = MonitoringEmitter(enabled=False)
|
|
em.emit({"event": "gateway_health", "name": "gateway.health_snapshot"})
|
|
assert em.stats()["queued"] == 0
|
|
em.close()
|
|
|
|
|
|
def test_process_singleton_stays_dormant_until_subscribed():
|
|
from agent.monitoring import emitter
|
|
|
|
emitter.reset_emitter_for_tests()
|
|
try:
|
|
emitter.emit({"event": "gateway_health", "name": "gateway.lifecycle"})
|
|
singleton = emitter.get_emitter()
|
|
assert singleton.stats()["queued"] == 0
|
|
assert singleton._started is False
|
|
|
|
subscriber = lambda _batch: None # noqa: E731
|
|
singleton.subscribe(subscriber)
|
|
emitter.emit({"event": "gateway_health", "name": "gateway.lifecycle"})
|
|
assert singleton._started is True
|
|
singleton.unsubscribe(subscriber)
|
|
finally:
|
|
emitter.reset_emitter_for_tests()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_unsubscribe_stops_delivery():
|
|
em = MonitoringEmitter()
|
|
seen: list = []
|
|
cb = lambda batch: seen.extend(batch) # noqa: E731
|
|
em.subscribe(cb)
|
|
em.emit({"event": "gateway_health", "name": "a"})
|
|
em.flush()
|
|
em.unsubscribe(cb)
|
|
em.emit({"event": "gateway_health", "name": "b"})
|
|
em.flush()
|
|
em.close()
|
|
assert [ev["name"] for ev in seen] == ["a"]
|
|
|
|
|
|
|
|
|
|
def test_hot_path_is_fast():
|
|
em = MonitoringEmitter()
|
|
start = time.perf_counter()
|
|
for _ in range(1_000):
|
|
em.emit({"event": "gateway_health", "name": "gateway.health_snapshot"})
|
|
elapsed = time.perf_counter() - start
|
|
em.close()
|
|
# 1000 emits should be far under a second even on slow CI.
|
|
assert elapsed < 1.0
|