mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-27 17:58:07 +00:00
37e648128b
Follow-up to the salvaged #67409 search aliases: with kimi-k3 now in the curated kimi-coding list (#68108), a Coding Plan key rendered TWO rows for one model — curated 'kimi-k3' plus live-discovered bare 'k3' (merge dedup was exact-string). Add model_alias_canonical() derived from the same alias table and use it as the merge dedup key, so the curated public slug wins and live-only models still surface.
65 lines
2.4 KiB
Python
65 lines
2.4 KiB
Python
"""Picker dedup must fold live bare wire-ids into their curated public slug.
|
|
|
|
Kimi Coding Plan live-discovers its flagship as the bare id ``k3`` while the
|
|
curated catalog carries ``kimi-k3``. The curated-first picker merge must not
|
|
render both as separate rows for the same model.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.model_search import model_alias_canonical
|
|
from hermes_cli.models import provider_model_ids
|
|
|
|
|
|
class TestModelAliasCanonical:
|
|
def test_bare_k3_folds_to_public_slug(self):
|
|
assert model_alias_canonical("k3") == "kimi-k3"
|
|
assert model_alias_canonical("K3") == "kimi-k3"
|
|
|
|
def test_non_alias_ids_are_identity(self):
|
|
assert model_alias_canonical("kimi-k2.6") == "kimi-k2.6"
|
|
assert model_alias_canonical("GPT-5.4") == "gpt-5.4"
|
|
assert model_alias_canonical("") == ""
|
|
|
|
|
|
class TestPickerMergeAliasDedup:
|
|
def test_live_bare_k3_not_duplicated_against_curated_kimi_k3(self):
|
|
"""Coding Plan key: live returns bare ``k3``; curated has ``kimi-k3``.
|
|
Exactly one k3-family row must survive (the curated slug leads)."""
|
|
with (
|
|
patch(
|
|
"hermes_cli.auth.resolve_api_key_provider_credentials",
|
|
return_value={
|
|
"api_key": "sk-kimi-x",
|
|
"base_url": "https://api.kimi.com/coding",
|
|
},
|
|
),
|
|
patch(
|
|
"providers.base.ProviderProfile.fetch_models",
|
|
return_value=["k3", "kimi-for-coding"],
|
|
),
|
|
):
|
|
out = provider_model_ids("kimi-coding")
|
|
|
|
k3_rows = [m for m in out if model_alias_canonical(m) == "kimi-k3"]
|
|
assert k3_rows == ["kimi-k3"], out
|
|
# Live-only entries with no curated twin still surface.
|
|
assert "kimi-for-coding" in out
|
|
|
|
def test_live_only_models_unaffected(self):
|
|
"""Alias folding must not drop live models without curated twins."""
|
|
with (
|
|
patch(
|
|
"hermes_cli.auth.resolve_api_key_provider_credentials",
|
|
return_value={
|
|
"api_key": "sk-kimi-x",
|
|
"base_url": "https://api.kimi.com/coding",
|
|
},
|
|
),
|
|
patch(
|
|
"providers.base.ProviderProfile.fetch_models",
|
|
return_value=["kimi-brand-new-live-only"],
|
|
),
|
|
):
|
|
out = provider_model_ids("kimi-coding")
|
|
assert "kimi-brand-new-live-only" in out
|