mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-09 08:21:50 +00:00
The advisory lint-diff bot flagged 17 new ty diagnostics. 6 are
`unresolved-import` for httpx/aiohttp/pytest, which is structural
(CI lint env has no project deps) and matches every other platform
plugin's noise floor. The remaining 11 are real and fixable:
- `Optional[callable]` → `Optional[Callable[..., None]]` (auth.py)
invalid-type-form on `callable` as a type expression. Added the
proper `typing.Callable` import. Two sites: on_pending in
poll_for_token, on_user_code in login_device_flow.
- Dropped three unused `# type: ignore` comments on
hermes_constants / hermes_cli.config imports — ty can resolve
those modules fine, the comments were dead.
- _supervise_sidecar(proc) widened `proc.stdout` from
`IO[Any] | None` to a narrowed local after an early `is None`
guard. Defensive against subprocesses launched without
stdout=PIPE.
- cli.py _cmd_setup: dropped the `has_existing_project = bool(...)`
intermediate, did the narrowing inline with `if existing_id and
existing_secret:` so ty can see project_id/project_secret are
non-None when create_user is called.
- test_inbound.py: replaced three `adapter.handle_message =
fake_handle # type: ignore[assignment]` with
`monkeypatch.setattr(adapter, 'handle_message', fake_handle)`.
Same behavior, no type-ignore, and the monkeypatch reverts
cleanly between tests.
Validation:
ty check plugins/platforms/photon/ tests/plugins/platforms/photon/
→ All checks passed!
tests/plugins/platforms/photon/ → 26/26 pass
py_compile clean
Windows footgun checker → 0 footguns
139 lines
4.7 KiB
Python
139 lines
4.7 KiB
Python
"""Inbound dispatch + dedup tests for PhotonAdapter.
|
|
|
|
These tests bypass the aiohttp server — they call ``_dispatch_inbound``
|
|
and ``_is_duplicate`` directly. That keeps them fast and means we can
|
|
exercise the message-shape parsing logic without binding ports.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from typing import List
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType
|
|
from plugins.platforms.photon.adapter import PhotonAdapter
|
|
|
|
|
|
def _make_adapter(monkeypatch: pytest.MonkeyPatch) -> PhotonAdapter:
|
|
# Avoid touching real auth.json / env.
|
|
monkeypatch.setenv("PHOTON_PROJECT_ID", "test-project-id")
|
|
monkeypatch.setenv("PHOTON_PROJECT_SECRET", "test-project-secret")
|
|
monkeypatch.delenv("PHOTON_WEBHOOK_SECRET", raising=False)
|
|
cfg = PlatformConfig(enabled=True, token="", extra={})
|
|
return PhotonAdapter(cfg)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_text_dm(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured: List[MessageEvent] = []
|
|
|
|
async def fake_handle(event: MessageEvent) -> None:
|
|
captured.append(event)
|
|
|
|
monkeypatch.setattr(adapter, "handle_message", fake_handle)
|
|
|
|
payload = {
|
|
"event": "messages",
|
|
"space": {"id": "any;-;+15551234567", "platform": "iMessage"},
|
|
"message": {
|
|
"id": "spc-msg-abc",
|
|
"platform": "iMessage",
|
|
"direction": "inbound",
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
"sender": {"id": "+15551234567", "platform": "iMessage"},
|
|
"space": {"id": "any;-;+15551234567", "platform": "iMessage"},
|
|
"content": {"type": "text", "text": "hello world"},
|
|
},
|
|
}
|
|
await adapter._dispatch_inbound(payload)
|
|
|
|
assert len(captured) == 1
|
|
event = captured[0]
|
|
assert event.text == "hello world"
|
|
assert event.message_type == MessageType.TEXT
|
|
assert event.message_id == "spc-msg-abc"
|
|
src = event.source
|
|
assert src is not None
|
|
assert src.platform == Platform("photon")
|
|
assert src.chat_id == "any;-;+15551234567"
|
|
assert src.chat_type == "dm"
|
|
assert src.user_id == "+15551234567"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_group_id_detected(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured: List[MessageEvent] = []
|
|
|
|
async def fake_handle(event: MessageEvent) -> None:
|
|
captured.append(event)
|
|
|
|
monkeypatch.setattr(adapter, "handle_message", fake_handle)
|
|
|
|
payload = {
|
|
"event": "messages",
|
|
"space": {"id": "any;+;group-guid-xyz", "platform": "iMessage"},
|
|
"message": {
|
|
"id": "spc-msg-grp",
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
"sender": {"id": "+15551234567"},
|
|
"space": {"id": "any;+;group-guid-xyz"},
|
|
"content": {"type": "text", "text": "hi group"},
|
|
},
|
|
}
|
|
await adapter._dispatch_inbound(payload)
|
|
assert captured[0].source.chat_type == "group"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_attachment_surfaces_marker(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured: List[MessageEvent] = []
|
|
|
|
async def fake_handle(event: MessageEvent) -> None:
|
|
captured.append(event)
|
|
|
|
monkeypatch.setattr(adapter, "handle_message", fake_handle)
|
|
|
|
payload = {
|
|
"event": "messages",
|
|
"message": {
|
|
"id": "spc-msg-att",
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
"sender": {"id": "+15551234567"},
|
|
"space": {"id": "any;-;+15551234567"},
|
|
"content": {
|
|
"type": "attachment",
|
|
"name": "IMG_4127.HEIC",
|
|
"mimeType": "image/heic",
|
|
"size": 12345,
|
|
},
|
|
},
|
|
}
|
|
await adapter._dispatch_inbound(payload)
|
|
assert len(captured) == 1
|
|
event = captured[0]
|
|
# Attachment carries metadata marker; mime → MessageType.PHOTO.
|
|
assert "Photon attachment received" in event.text
|
|
assert "IMG_4127.HEIC" in event.text
|
|
assert event.message_type == MessageType.PHOTO
|
|
|
|
|
|
def test_is_duplicate_window(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
assert adapter._is_duplicate("id-1") is False
|
|
assert adapter._is_duplicate("id-1") is True
|
|
assert adapter._is_duplicate("id-2") is False
|
|
assert adapter._is_duplicate("id-1") is True # still dup
|
|
|
|
|
|
def test_check_requirements_without_node(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
# If no node binary on PATH the adapter should refuse to start.
|
|
from plugins.platforms.photon import adapter as adapter_mod
|
|
|
|
monkeypatch.setattr(adapter_mod.shutil, "which", lambda _name: None)
|
|
assert adapter_mod.check_requirements() is False
|