mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-11 08:42:11 +00:00
777dc9da62
Closes #33617. Adds additive _meta.hermes.sessionProvenance to ACP session surfaces so clients can detect compression-driven internal session rotation without parsing status text, guessing from token drops, or reading state.db. Derived on demand from the existing compression chain (parent_session_id / end_reason) — no new persisted state, no schema change, no ACP protocol change. ACP session_id stays the stable client handle. - acp_adapter/provenance.py: derive provenance from SessionDB - server.py: attach _meta to new/load/resume responses; emit a session_info_update when the internal head rotates during a prompt
103 lines
3.5 KiB
Python
103 lines
3.5 KiB
Python
"""Tests for ACP session-provenance derivation (issue #33617).
|
|
|
|
Exercises acp_adapter.provenance against a real SessionDB — no mocks — covering
|
|
the acceptance-criteria matrix: root session, compression-split continuation,
|
|
multi-depth chains, rotation flagging, and graceful handling of unknown ids.
|
|
"""
|
|
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from acp_adapter.provenance import build_session_provenance, session_provenance_meta
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
@pytest.fixture()
|
|
def db(tmp_path):
|
|
d = SessionDB(db_path=tmp_path / "state.db")
|
|
yield d
|
|
|
|
|
|
def _mk(db, sid, parent=None):
|
|
db.create_session(session_id=sid, source="acp", parent_session_id=parent)
|
|
|
|
|
|
def test_root_session_no_compression(db):
|
|
_mk(db, "root1")
|
|
prov = build_session_provenance(db, "acp-1", "root1")
|
|
assert prov["acpSessionId"] == "acp-1"
|
|
assert prov["currentHermesSessionId"] == "root1"
|
|
assert prov["rootHermesSessionId"] == "root1"
|
|
assert prov["parentHermesSessionId"] is None
|
|
assert prov["sessionKind"] == "root"
|
|
assert prov["compressionDepth"] == 0
|
|
assert "reason" not in prov # no rotation signalled
|
|
|
|
|
|
def test_compression_split_continuation(db):
|
|
# Parent ended with compression, child created afterwards.
|
|
_mk(db, "old")
|
|
db.end_session("old", "compression")
|
|
time.sleep(0.001)
|
|
_mk(db, "new", parent="old")
|
|
|
|
prov = build_session_provenance(
|
|
db, "acp-1", "new", previous_hermes_session_id="old"
|
|
)
|
|
assert prov["sessionKind"] == "continuation"
|
|
assert prov["parentHermesSessionId"] == "old"
|
|
assert prov["rootHermesSessionId"] == "old"
|
|
assert prov["compressionDepth"] == 1
|
|
assert prov["previousHermesSessionId"] == "old"
|
|
# Head rotated this turn → reason/creatorKind flagged.
|
|
assert prov["reason"] == "compression"
|
|
assert prov["creatorKind"] == "compression"
|
|
|
|
|
|
def test_multi_depth_chain(db):
|
|
_mk(db, "s0")
|
|
db.end_session("s0", "compression")
|
|
_mk(db, "s1", parent="s0")
|
|
db.end_session("s1", "compression")
|
|
_mk(db, "s2", parent="s1")
|
|
|
|
prov = build_session_provenance(db, "acp-1", "s2")
|
|
assert prov["rootHermesSessionId"] == "s0"
|
|
assert prov["compressionDepth"] == 2
|
|
assert prov["sessionKind"] == "continuation"
|
|
|
|
|
|
def test_non_compression_parent_is_root_not_continuation(db):
|
|
# A child with a parent that did NOT end via compression (e.g. delegate
|
|
# or branch child) must not be reported as a compression continuation.
|
|
_mk(db, "p")
|
|
_mk(db, "c", parent="p") # parent still live, no end_reason
|
|
prov = build_session_provenance(db, "acp-1", "c")
|
|
assert prov["sessionKind"] == "root"
|
|
assert prov["compressionDepth"] == 0
|
|
assert prov["rootHermesSessionId"] == "p" # lineage root still walked
|
|
|
|
|
|
def test_no_false_rotation_when_head_unchanged(db):
|
|
_mk(db, "s")
|
|
# previous == current → no rotation reason emitted.
|
|
prov = build_session_provenance(
|
|
db, "acp-1", "s", previous_hermes_session_id="s"
|
|
)
|
|
assert "reason" not in prov
|
|
assert "creatorKind" not in prov
|
|
assert prov["previousHermesSessionId"] == "s"
|
|
|
|
|
|
def test_unknown_session_returns_none(db):
|
|
assert build_session_provenance(db, "acp-1", "does-not-exist") is None
|
|
assert session_provenance_meta(db, "acp-1", "does-not-exist") is None
|
|
|
|
|
|
def test_meta_wrapper_shape(db):
|
|
_mk(db, "root1")
|
|
meta = session_provenance_meta(db, "acp-1", "root1")
|
|
assert set(meta.keys()) == {"hermes"}
|
|
assert "sessionProvenance" in meta["hermes"]
|
|
assert meta["hermes"]["sessionProvenance"]["currentHermesSessionId"] == "root1"
|