mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-23 16:36:23 +00:00
00e9f6dd4d
Add hermes_cli/windows_ssh_runtime.py: a native Windows trust boundary invoked over SSH to manage the Desktop SSH backend lifecycle — ACL-locked one-shot token file (owner+SYSTEM only, SE_DACL_PROTECTED, read-once via DELETE_ON_CLOSE), ownership lock, and detached serve spawn with CREATE_BREAKAWAY_FROM_JOB so the backend survives the SSH session's Job Object teardown. Process ownership is proven by exact pid + creation-time + argv + owner-nonce; state is tri-state (owned / stale / indeterminate) so a live-but-unreadable process is never mistaken for stale. Route _read_ssh_session_token_file to the Windows reader on win32, and move the POSIX token root from a hardcoded ~/.hermes to get_hermes_home() so both platforms honor the active profile.
94 lines
3.4 KiB
Python
94 lines
3.4 KiB
Python
import argparse
|
|
import os
|
|
|
|
import pytest
|
|
from hermes_constants import set_hermes_home_override, reset_hermes_home_override
|
|
|
|
from hermes_cli.main import _read_ssh_session_token_file, cmd_dashboard
|
|
from hermes_cli.subcommands.dashboard import build_dashboard_parser
|
|
|
|
|
|
def dashboard_parser():
|
|
parser = argparse.ArgumentParser()
|
|
subparsers = parser.add_subparsers(dest="command")
|
|
build_dashboard_parser(
|
|
subparsers,
|
|
cmd_dashboard=lambda _args: None,
|
|
cmd_dashboard_register=lambda _args: None,
|
|
)
|
|
return parser
|
|
|
|
|
|
def test_serve_help_advertises_secure_ssh_bootstrap_flags(capsys):
|
|
with pytest.raises(SystemExit) as exit_info:
|
|
dashboard_parser().parse_args(["serve", "--help"])
|
|
assert exit_info.value.code == 0
|
|
output = capsys.readouterr().out
|
|
assert "--ssh-session-token-file PATH" in output
|
|
assert "--ssh-owner-nonce NONCE" in output
|
|
|
|
|
|
def test_serve_accepts_owner_nonce():
|
|
args = dashboard_parser().parse_args(["serve", "--ssh-owner-nonce", "0123456789abcdef"])
|
|
assert args.ssh_owner_nonce == "0123456789abcdef"
|
|
|
|
|
|
@pytest.mark.parametrize("operation", ["--status", "--stop"])
|
|
def test_one_shot_token_file_rejects_non_starting_operations(operation):
|
|
args = dashboard_parser().parse_args([
|
|
"serve", operation, "--ssh-session-token-file", "/tmp/token",
|
|
])
|
|
with pytest.raises(SystemExit, match="cannot be used"):
|
|
cmd_dashboard(args)
|
|
|
|
|
|
def test_token_file_is_read_and_unlinked_through_private_directory(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
hermes_home = home / ".hermes"
|
|
token_dir = hermes_home / "desktop-ssh" / ("a" * 32)
|
|
token_dir.mkdir(parents=True, mode=0o700)
|
|
token_path = token_dir / "0123456789abcdef.token"
|
|
token_path.write_text("b" * 64)
|
|
token_path.chmod(0o600)
|
|
override = set_hermes_home_override(hermes_home)
|
|
try:
|
|
assert _read_ssh_session_token_file(str(token_path)) == "b" * 64
|
|
assert not token_path.exists()
|
|
finally:
|
|
reset_hermes_home_override(override)
|
|
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="POSIX symlink contract")
|
|
def test_token_file_rejects_symlink(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
token_dir = home / ".hermes" / "desktop-ssh" / ("a" * 32)
|
|
token_dir.mkdir(parents=True, mode=0o700)
|
|
target = tmp_path / "token"
|
|
target.write_text("b" * 64)
|
|
target.chmod(0o600)
|
|
token_path = token_dir / "0123456789abcdef.token"
|
|
token_path.symlink_to(target)
|
|
override = set_hermes_home_override(home / ".hermes")
|
|
try:
|
|
with pytest.raises(SystemExit, match="symlink|not accessible"):
|
|
_read_ssh_session_token_file(str(token_path))
|
|
assert not token_path.exists()
|
|
assert target.read_text() == "b" * 64
|
|
finally:
|
|
reset_hermes_home_override(override)
|
|
|
|
|
|
def test_token_file_rejects_parent_escape(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
token_root = home / ".hermes" / "desktop-ssh"
|
|
token_root.mkdir(parents=True, mode=0o700)
|
|
escaped = token_root.parent / "0123456789abcdef.token"
|
|
escaped.write_text("b" * 64)
|
|
escaped.chmod(0o600)
|
|
override = set_hermes_home_override(home / ".hermes")
|
|
try:
|
|
with pytest.raises(SystemExit, match="invalid runtime path"):
|
|
_read_ssh_session_token_file(str(token_root / ".." / escaped.name))
|
|
assert escaped.exists()
|
|
finally:
|
|
reset_hermes_home_override(override)
|