mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
56 lines
1.7 KiB
Python
56 lines
1.7 KiB
Python
import argparse
|
|
import os
|
|
|
|
import pytest
|
|
from hermes_constants import set_hermes_home_override, reset_hermes_home_override
|
|
|
|
from hermes_cli.main import _read_ssh_session_token_file, cmd_dashboard
|
|
from hermes_cli.subcommands.dashboard import build_dashboard_parser
|
|
|
|
|
|
def dashboard_parser():
|
|
parser = argparse.ArgumentParser()
|
|
subparsers = parser.add_subparsers(dest="command")
|
|
build_dashboard_parser(
|
|
subparsers,
|
|
cmd_dashboard=lambda _args: None,
|
|
cmd_dashboard_register=lambda _args: None,
|
|
)
|
|
return parser
|
|
|
|
|
|
def test_serve_help_advertises_secure_ssh_bootstrap_flags(capsys):
|
|
with pytest.raises(SystemExit) as exit_info:
|
|
dashboard_parser().parse_args(["serve", "--help"])
|
|
assert exit_info.value.code == 0
|
|
output = capsys.readouterr().out
|
|
assert "--ssh-session-token-file PATH" in output
|
|
assert "--ssh-owner-nonce NONCE" in output
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="POSIX symlink contract")
|
|
def test_token_file_rejects_symlink(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
token_dir = home / ".hermes" / "desktop-ssh" / ("a" * 32)
|
|
token_dir.mkdir(parents=True, mode=0o700)
|
|
target = tmp_path / "token"
|
|
target.write_text("b" * 64)
|
|
target.chmod(0o600)
|
|
token_path = token_dir / "0123456789abcdef.token"
|
|
token_path.symlink_to(target)
|
|
override = set_hermes_home_override(home / ".hermes")
|
|
try:
|
|
with pytest.raises(SystemExit, match="symlink|not accessible"):
|
|
_read_ssh_session_token_file(str(token_path))
|
|
assert not token_path.exists()
|
|
assert target.read_text() == "b" * 64
|
|
finally:
|
|
reset_hermes_home_override(override)
|
|
|
|
|