mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-10 13:31:38 +00:00
a796e0b796
* fix: cool down transient Telegram typing failures Port from openclaw/openclaw#93020: add per-chat cooldown for transient sendChatAction failures so keep-typing refreshes do not hammer Telegram during network blips or rate limits. * fix: support bare Telegram adapters in typing cooldown * test: update typing backoff imports for relocated Telegram adapter The Telegram adapter moved from gateway/platforms/telegram.py to plugins/platforms/telegram/adapter.py since this branch was created; point the test imports and monkeypatch targets at the new module.
113 lines
4 KiB
Python
113 lines
4 KiB
Python
"""Telegram typing indicator transient backoff tests."""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
_repo = str(Path(__file__).resolve().parents[2])
|
|
if _repo not in sys.path:
|
|
sys.path.insert(0, _repo)
|
|
|
|
|
|
def _ensure_telegram_mock():
|
|
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
|
|
return
|
|
|
|
mod = MagicMock()
|
|
mod.ext.ContextTypes.DEFAULT_TYPE = type(None)
|
|
mod.constants.ParseMode.MARKDOWN = "Markdown"
|
|
mod.constants.ParseMode.MARKDOWN_V2 = "MarkdownV2"
|
|
mod.constants.ParseMode.HTML = "HTML"
|
|
mod.constants.ChatType.PRIVATE = "private"
|
|
mod.constants.ChatType.GROUP = "group"
|
|
mod.constants.ChatType.SUPERGROUP = "supergroup"
|
|
mod.constants.ChatType.CHANNEL = "channel"
|
|
mod.error.NetworkError = type("NetworkError", (OSError,), {})
|
|
mod.error.TimedOut = type("TimedOut", (OSError,), {})
|
|
mod.error.RetryAfter = type("RetryAfter", (Exception,), {"__init__": lambda self, retry_after=1: setattr(self, "retry_after", retry_after)})
|
|
mod.error.BadRequest = type("BadRequest", (Exception,), {})
|
|
|
|
for name in ("telegram", "telegram.ext", "telegram.constants", "telegram.request"):
|
|
sys.modules.setdefault(name, mod)
|
|
sys.modules.setdefault("telegram.error", mod.error)
|
|
|
|
|
|
_ensure_telegram_mock()
|
|
|
|
from gateway.config import PlatformConfig
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
|
|
def _make_adapter():
|
|
adapter = TelegramAdapter(PlatformConfig(enabled=True, token="test-token"))
|
|
adapter._bot = AsyncMock()
|
|
return adapter
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_transient_failure_enters_cooldown(monkeypatch):
|
|
adapter = _make_adapter()
|
|
now = {"value": 1000.0}
|
|
monkeypatch.setattr("plugins.platforms.telegram.adapter.asyncio.get_running_loop", lambda: type("Loop", (), {"time": lambda self: now["value"]})())
|
|
monkeypatch.setattr(adapter, "_telegram_typing_cooldown_seconds", 30.0, raising=False)
|
|
|
|
async def fail_once(**kwargs):
|
|
raise OSError("temporary telegram network failure")
|
|
|
|
adapter._bot.send_chat_action = AsyncMock(side_effect=fail_once)
|
|
|
|
await adapter.send_typing("123")
|
|
await adapter.send_typing("123")
|
|
|
|
assert adapter._bot.send_chat_action.await_count == 1
|
|
assert adapter._telegram_typing_cooldown_until["123"] == pytest.approx(1030.0)
|
|
|
|
now["value"] = 1031.0
|
|
adapter._bot.send_chat_action = AsyncMock(return_value=None)
|
|
await adapter.send_typing("123")
|
|
|
|
assert adapter._bot.send_chat_action.await_count == 1
|
|
assert "123" not in adapter._telegram_typing_cooldown_until
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_dm_topic_fallback_success_does_not_cool_down(monkeypatch):
|
|
adapter = _make_adapter()
|
|
monkeypatch.setattr("plugins.platforms.telegram.adapter.asyncio.get_running_loop", lambda: type("Loop", (), {"time": lambda self: 10.0})())
|
|
|
|
calls = []
|
|
|
|
async def send_chat_action(**kwargs):
|
|
calls.append(kwargs)
|
|
if "message_thread_id" in kwargs:
|
|
raise RuntimeError("message thread not found")
|
|
return None
|
|
|
|
adapter._bot.send_chat_action = AsyncMock(side_effect=send_chat_action)
|
|
|
|
await adapter.send_typing(
|
|
"123",
|
|
metadata={"thread_id": "99", "telegram_dm_topic_reply_fallback": True},
|
|
)
|
|
|
|
assert len(calls) == 2
|
|
assert "123" not in adapter._telegram_typing_cooldown_until
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_bad_thread_failure_does_not_cool_down(monkeypatch):
|
|
adapter = _make_adapter()
|
|
monkeypatch.setattr("plugins.platforms.telegram.adapter.asyncio.get_running_loop", lambda: type("Loop", (), {"time": lambda self: 10.0})())
|
|
|
|
async def bad_request(**kwargs):
|
|
raise ValueError("message thread not found")
|
|
|
|
adapter._bot.send_chat_action = AsyncMock(side_effect=bad_request)
|
|
|
|
await adapter.send_typing("123", metadata={"thread_id": "99"})
|
|
await adapter.send_typing("123", metadata={"thread_id": "99"})
|
|
|
|
assert adapter._bot.send_chat_action.await_count == 2
|
|
assert "123" not in adapter._telegram_typing_cooldown_until
|