mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-09 13:21:42 +00:00
088b989442
* fix(gateway): scope reset banners' session info to the serving profile The auto-reset notice and the manual /reset //new banner both appended _format_session_info() outside any profile scope, so a multiplexed gateway advertised the base config's model/provider/context while the session actually ran on the profile's. Route both call sites through a new _reset_notice_session_info(source), which enters _profile_runtime_scope for the source's profile when gateway.multiplex_profiles is on (mirroring _run_agent's gating), so _load_gateway_config()/_resolve_gateway_model() resolve the profile's config.yaml via the existing context-local home override. Single-profile gateways never enter the scope — behavior unchanged. Both call sites invoke the helper via asyncio.to_thread: under the scope, resolution can do blocking work (credential refresh, context-length HTTP probes) that previously failed fast unscoped and must not run on the event loop. Fixes #59003 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(release): map irresi author email for PR #59048 salvage --------- Co-authored-by: irresi <blueirobin02@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
157 lines
7 KiB
Python
157 lines
7 KiB
Python
"""Tests for GatewayRunner._format_session_info — session config surfacing."""
|
|
|
|
import pytest
|
|
from unittest.mock import patch
|
|
|
|
from gateway.run import GatewayRunner
|
|
|
|
|
|
@pytest.fixture()
|
|
def runner():
|
|
"""Create a bare GatewayRunner without __init__."""
|
|
return GatewayRunner.__new__(GatewayRunner)
|
|
|
|
|
|
def _patch_info(tmp_path, config_yaml, model, runtime):
|
|
"""Return a context-manager stack that patches _format_session_info deps."""
|
|
cfg_path = tmp_path / "config.yaml"
|
|
if config_yaml is not None:
|
|
cfg_path.write_text(config_yaml)
|
|
return (
|
|
patch("gateway.run._hermes_home", tmp_path),
|
|
patch("gateway.run._resolve_gateway_model", return_value=model),
|
|
patch("gateway.run._resolve_runtime_agent_kwargs", return_value=runtime),
|
|
)
|
|
|
|
|
|
class TestFormatSessionInfo:
|
|
|
|
def test_includes_model_name(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: anthropic/claude-opus-4.6\n provider: openrouter\n",
|
|
"anthropic/claude-opus-4.6",
|
|
{"provider": "openrouter", "base_url": "https://openrouter.ai/api/v1", "api_key": "k"})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "claude-opus-4.6" in info
|
|
|
|
def test_includes_provider(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: test-model\n provider: openrouter\n",
|
|
"test-model",
|
|
{"provider": "openrouter", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "openrouter" in info
|
|
|
|
def test_config_context_length(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: test-model\n context_length: 32768\n",
|
|
"test-model",
|
|
{"provider": "custom", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "32K" in info
|
|
assert "config" in info
|
|
|
|
def test_default_fallback_hint(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: unknown-model-xyz\n",
|
|
"unknown-model-xyz",
|
|
{"provider": "", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "256K" in info
|
|
assert "model.context_length" in info
|
|
|
|
def test_local_endpoint_shown(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(
|
|
tmp_path,
|
|
"model:\n default: qwen3:8b\n provider: custom\n base_url: http://localhost:11434/v1\n context_length: 8192\n",
|
|
"qwen3:8b",
|
|
{"provider": "custom", "base_url": "http://localhost:11434/v1", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "localhost:11434" in info
|
|
assert "8K" in info
|
|
|
|
def test_cloud_endpoint_hidden(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: test-model\n provider: openrouter\n",
|
|
"test-model",
|
|
{"provider": "openrouter", "base_url": "https://openrouter.ai/api/v1", "api_key": "k"})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "Endpoint" not in info
|
|
|
|
def test_million_context_format(self, runner, tmp_path):
|
|
p1, p2, p3 = _patch_info(tmp_path, "model:\n default: test-model\n context_length: 1000000\n",
|
|
"test-model",
|
|
{"provider": "", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "1.0M" in info
|
|
|
|
def test_missing_config(self, runner, tmp_path):
|
|
"""No config.yaml should not crash."""
|
|
p1, p2, p3 = _patch_info(tmp_path, None, # don't create config
|
|
"anthropic/claude-sonnet-4.6",
|
|
{"provider": "openrouter", "base_url": "", "api_key": ""})
|
|
with p1, p2, p3:
|
|
info = runner._format_session_info()
|
|
assert "Model" in info
|
|
assert "Context" in info
|
|
|
|
def test_runtime_resolution_failure_doesnt_crash(self, runner, tmp_path):
|
|
"""If runtime resolution raises, should still produce output."""
|
|
cfg_path = tmp_path / "config.yaml"
|
|
cfg_path.write_text("model:\n default: test-model\n context_length: 4096\n")
|
|
with patch("gateway.run._hermes_home", tmp_path), \
|
|
patch("gateway.run._resolve_gateway_model", return_value="test-model"), \
|
|
patch("gateway.run._resolve_runtime_agent_kwargs", side_effect=RuntimeError("no creds")):
|
|
info = runner._format_session_info()
|
|
assert "4K" in info
|
|
assert "config" in info
|
|
|
|
|
|
class TestResetNoticeSessionInfo:
|
|
"""#59003: the auto-reset banner must report the serving profile's config,
|
|
not the multiplexer's base config."""
|
|
|
|
_RUNTIME = {"provider": "", "base_url": "", "api_key": ""}
|
|
|
|
def _source(self):
|
|
from gateway.config import Platform
|
|
from gateway.session import SessionSource
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM, chat_id="123", user_id="u1",
|
|
profile="planner",
|
|
)
|
|
|
|
def _homes(self, tmp_path):
|
|
base = tmp_path / "base"
|
|
profile = tmp_path / "profiles" / "planner"
|
|
profile.mkdir(parents=True)
|
|
base.mkdir()
|
|
base.joinpath("config.yaml").write_text(
|
|
"model:\n default: base-model\n provider: custom\n context_length: 1000\n")
|
|
profile.joinpath("config.yaml").write_text(
|
|
"model:\n default: profile-model\n provider: anthropic\n context_length: 2000\n")
|
|
return base, profile
|
|
|
|
def test_multiplex_uses_profile_config(self, runner, tmp_path):
|
|
from types import SimpleNamespace
|
|
base, profile = self._homes(tmp_path)
|
|
runner.config = SimpleNamespace(multiplex_profiles=True)
|
|
with patch("gateway.run._hermes_home", base), \
|
|
patch.object(GatewayRunner, "_resolve_profile_home_for_source", return_value=profile), \
|
|
patch("gateway.run._resolve_runtime_agent_kwargs", return_value=self._RUNTIME):
|
|
info = runner._reset_notice_session_info(self._source())
|
|
assert "profile-model" in info
|
|
assert "anthropic" in info
|
|
assert "base-model" not in info
|
|
|
|
def test_single_profile_uses_base_config(self, runner, tmp_path):
|
|
from types import SimpleNamespace
|
|
base, _profile = self._homes(tmp_path)
|
|
runner.config = SimpleNamespace(multiplex_profiles=False)
|
|
with patch("gateway.run._hermes_home", base), \
|
|
patch("gateway.run._resolve_runtime_agent_kwargs", return_value=self._RUNTIME):
|
|
info = runner._reset_notice_session_info(self._source())
|
|
assert "base-model" in info
|
|
assert "profile-model" not in info
|