mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-13 14:02:16 +00:00
8986981df4
Sibling sweep from the #58902 raft review found aiohttp servers still running on the implicit 1 MiB default with no explicit body cap: - bluebubbles webhook (127.0.0.1): 1 MiB explicit cap — events are small JSON/form payloads; attachments arrive via the REST API - teams Bot Framework listener (0.0.0.0 bind — most exposed): 1 MiB cap; activities are JSON well under that - hermes proxy server: 10 MB cap mirroring api_server's MAX_REQUEST_BYTES (chat-completion payloads can be large, but must stay bounded) client_max_size bounds every read path including chunked transfer-encoding requests that carry no Content-Length (#58536/#58902 pattern). Deliberately excluded: feishu, whatsapp_cloud, sms, line, wecom, msgraph — open contributor PRs (#54938, #54944, #54620, #54931, #54934, #25296) already cover those; reviewing them separately preserves their credit. 3 regression tests pin the wiring.
36 lines
1.3 KiB
Python
36 lines
1.3 KiB
Python
"""Regression tests: aiohttp servers must set an explicit ``client_max_size``.
|
|
|
|
Without it, aiohttp falls back to its implicit 1 MiB default and — worse —
|
|
handlers that only check ``Content-Length`` can be bypassed entirely by
|
|
chunked transfer-encoding requests (#58536 webhook, #58902 raft lineage).
|
|
These tests pin the wiring for the three servers fixed in this follow-up:
|
|
bluebubbles, teams, and the ``hermes proxy`` server.
|
|
"""
|
|
|
|
import inspect
|
|
|
|
|
|
def test_bluebubbles_app_sets_client_max_size():
|
|
import gateway.platforms.bluebubbles as bb
|
|
|
|
assert bb._WEBHOOK_MAX_BODY_BYTES > 0
|
|
src = inspect.getsource(bb.BlueBubblesAdapter.connect)
|
|
assert "client_max_size=_WEBHOOK_MAX_BODY_BYTES" in src
|
|
|
|
|
|
def test_teams_app_sets_client_max_size():
|
|
import plugins.platforms.teams.adapter as teams
|
|
|
|
assert teams._MAX_BODY_BYTES > 0
|
|
src = inspect.getsource(teams.TeamsAdapter.connect)
|
|
assert "client_max_size=_MAX_BODY_BYTES" in src
|
|
|
|
|
|
def test_proxy_app_sets_client_max_size():
|
|
import hermes_cli.proxy.server as proxy_server
|
|
|
|
# Mirrors api_server's MAX_REQUEST_BYTES: chat payloads can be large,
|
|
# but the cap must exist so chunked bodies stay bounded.
|
|
assert proxy_server.MAX_REQUEST_BYTES >= 1_048_576
|
|
src = inspect.getsource(proxy_server.create_app)
|
|
assert "client_max_size=MAX_REQUEST_BYTES" in src
|