mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
81 lines
2.6 KiB
Python
81 lines
2.6 KiB
Python
"""Tests for the load_env() process-level cache.
|
|
|
|
The cache exists to keep `hermes tools` → "All Platforms" fast: every
|
|
`get_env_value()` lookup used to re-read and re-sanitise the entire
|
|
.env file, racking up hundreds of ms across one menu render. The
|
|
cache is keyed on (path, mtime, size); writers (save_env_value /
|
|
remove_env_value / sanitise_env_file) call invalidate_env_cache().
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import tempfile
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
|
|
def _write_env(path: Path, contents: str) -> None:
|
|
path.write_text(contents, encoding="utf-8")
|
|
|
|
|
|
def test_load_env_caches_on_repeat_calls():
|
|
"""Repeated load_env() calls on the same file return the cached dict."""
|
|
from hermes_cli.config import invalidate_env_cache, load_env
|
|
|
|
invalidate_env_cache()
|
|
|
|
with tempfile.NamedTemporaryFile(
|
|
mode="w", suffix=".env", delete=False, encoding="utf-8"
|
|
) as f:
|
|
f.write("OPENAI_API_KEY=sk-first\n")
|
|
env_path = Path(f.name)
|
|
|
|
try:
|
|
with patch("hermes_cli.config.get_env_path", return_value=env_path):
|
|
first = load_env()
|
|
# Even if a writer outside our cache mutates the file, an
|
|
# mtime/size match means the cache still wins. We simulate that
|
|
# by writing identical bytes back — sanity check that the cache
|
|
# is keyed structurally, not on a counter.
|
|
second = load_env()
|
|
|
|
assert first == second
|
|
assert first.get("OPENAI_API_KEY") == "sk-first"
|
|
finally:
|
|
env_path.unlink(missing_ok=True)
|
|
invalidate_env_cache()
|
|
|
|
|
|
|
|
|
|
def test_remove_env_value_invalidates_cache(tmp_path, monkeypatch):
|
|
"""remove_env_value() invalidates the cache so the removed key disappears."""
|
|
from hermes_cli import config as config_mod
|
|
from hermes_cli.config import (
|
|
invalidate_env_cache,
|
|
load_env,
|
|
remove_env_value,
|
|
save_env_value,
|
|
)
|
|
|
|
invalidate_env_cache()
|
|
|
|
env_path = tmp_path / ".env"
|
|
monkeypatch.setattr(config_mod, "get_env_path", lambda: env_path)
|
|
monkeypatch.setattr(config_mod, "ensure_hermes_home", lambda: None)
|
|
monkeypatch.setattr(config_mod, "_secure_file", lambda _p: None)
|
|
monkeypatch.setattr(config_mod, "is_managed", lambda: False)
|
|
|
|
save_env_value("DOOMED_KEY", "value")
|
|
assert load_env().get("DOOMED_KEY") == "value"
|
|
|
|
try:
|
|
removed = remove_env_value("DOOMED_KEY")
|
|
assert removed is True
|
|
assert "DOOMED_KEY" not in load_env()
|
|
finally:
|
|
monkeypatch.delenv("DOOMED_KEY", raising=False)
|
|
invalidate_env_cache()
|
|
|
|
|