mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
86f02d8d71
Match the row-budget naming introduced in PR #11260 for the approval and clarify panels: rename chrome_reserve=14 into reserved_below=6 (input chrome below the panel) + panel_chrome=6 (this panel's borders, blanks, and hint row) + min_visible=3 (floor on visible items). Same arithmetic as before, but a reviewer reading both files now sees the same handle. Compact-chrome mode is intentionally not adopted — that pattern fits the "fixed mandatory content might overflow" shape of approval/clarify (solved by truncating with a marker), whereas the picker's overflow is already handled by the scrolling viewport.
62 lines
2.7 KiB
Python
62 lines
2.7 KiB
Python
"""Tests for the prompt_toolkit /model picker scroll viewport.
|
|
|
|
Regression for: when a provider exposes many models (e.g. Ollama Cloud's
|
|
36+), the picker rendered every choice into a Window with no max height,
|
|
clipping the bottom border and any items past the terminal's last row.
|
|
The viewport helper now caps visible items and slides the offset to keep
|
|
the cursor on screen.
|
|
"""
|
|
from cli import HermesCLI
|
|
|
|
|
|
_compute = HermesCLI._compute_model_picker_viewport
|
|
|
|
|
|
class TestPickerViewport:
|
|
def test_short_list_no_scroll(self):
|
|
offset, visible = _compute(selected=0, scroll_offset=0, n=5, term_rows=30)
|
|
assert offset == 0
|
|
assert visible == 5
|
|
|
|
def test_long_list_caps_visible_to_chrome_budget(self):
|
|
# 30 rows minus reserved_below=6 minus panel_chrome=6 → max_visible=18.
|
|
offset, visible = _compute(selected=0, scroll_offset=0, n=36, term_rows=30)
|
|
assert visible == 18
|
|
assert offset == 0
|
|
|
|
def test_cursor_past_window_scrolls_down(self):
|
|
offset, visible = _compute(selected=22, scroll_offset=0, n=36, term_rows=30)
|
|
assert visible == 18
|
|
assert 22 in range(offset, offset + visible)
|
|
|
|
def test_cursor_above_window_scrolls_up(self):
|
|
offset, visible = _compute(selected=3, scroll_offset=15, n=36, term_rows=30)
|
|
assert offset == 3
|
|
assert 3 in range(offset, offset + visible)
|
|
|
|
def test_offset_clamped_to_bottom(self):
|
|
# Selected on the last item — offset must keep the visible window
|
|
# full, not walk past the end of the list.
|
|
offset, visible = _compute(selected=35, scroll_offset=0, n=36, term_rows=30)
|
|
assert offset + visible == 36
|
|
assert 35 in range(offset, offset + visible)
|
|
|
|
def test_tiny_terminal_uses_minimum_visible(self):
|
|
# term_rows below the chrome budget falls back to the floor of 3 rows.
|
|
_, visible = _compute(selected=0, scroll_offset=0, n=20, term_rows=10)
|
|
assert visible == 3
|
|
|
|
def test_offset_recovers_after_stage_switch(self):
|
|
# When the user backs out of the model stage and re-enters with
|
|
# selected=0, a stale offset from the previous stage must collapse.
|
|
offset, visible = _compute(selected=0, scroll_offset=25, n=36, term_rows=30)
|
|
assert offset == 0
|
|
assert 0 in range(offset, offset + visible)
|
|
|
|
def test_full_navigation_keeps_cursor_visible(self):
|
|
offset = 0
|
|
for cursor in list(range(36)) + list(range(35, -1, -1)):
|
|
offset, visible = _compute(cursor, offset, n=36, term_rows=30)
|
|
assert cursor in range(offset, offset + visible), (
|
|
f"cursor={cursor} out of view: offset={offset} visible={visible}"
|
|
)
|