hermes-agent/tests/cli/test_cli_user_message_preview.py
Teknium 3dd8059a05
fix(tests): eliminate flaky/broken tests — shadow sys.path inserts, unmocked network in compressor tests, stale-SDK feishu pin guard, quadratic redact regexes
- Remove tests/-shadowing sys.path.insert(dirname/'..') from 11 test files:
  it prepended the tests/ dir itself to sys.path, so 'import agent' /
  'import hermes_cli' resolved to the test packages and collection died
  with ModuleNotFoundError depending on import order (2 files failed in
  every full-suite run; 9 more were latent).
- Patch call_llm in 5 context-compressor tests that called compress()
  unmocked: each burned ~50s attempting live LLM traffic through the
  relay before falling back (572s file — the slowest in the suite, and
  flaky under the 300s per-file timeout). File now runs in ~5s.
- agent/redact.py: fix two catastrophically-backtracking regexes hit by
  the compressor's redaction pass on large payloads —
  _STRICT_URL_USERINFO_RE anchors on the mandatory '//' (optional-scheme
  prefix backtracked O(n^2): ~55s on a 320KB payload, now sub-ms;
  output-equivalence fuzz-verified on 20k random strings), and the
  _CFG_DOTTED_RE/_CFG_ANCHORED_RE subs gain an exact linear keyword
  pre-gate so secret-free text skips the quadratic pattern entirely.
- tests/gateway/test_feishu.py: version-guard the extra_ua_tags SDK
  signature check; the repo pins lark-oapi==1.6.8 but stale local
  installs (1.5.3) fail the assertion — skip below the pin.
- tests/tools/test_managed_browserbase_and_modal.py: stub
  agent.redact + agent.credential_persistence in the fake agent package
  (empty __path__ blocks all real agent.* imports added since the fake
  was written).
- tests/gateway/test_startup_restart_race.py: raise wait_for timeouts
  2s -> 30s; 2s wall-clock on a loaded 40-worker box flaked in the
  baseline run (passes instantly when the box is quiet).
2026-07-29 12:18:07 -07:00

90 lines
3.1 KiB
Python

import importlib
import sys
from unittest.mock import MagicMock, patch
_cli_mod = None
def _make_cli(user_message_preview=None):
global _cli_mod
clean_config = {
"model": {
"default": "anthropic/claude-opus-4.6",
"base_url": "https://openrouter.ai/api/v1",
"provider": "auto",
},
"display": {
"compact": False,
"tool_progress": "all",
"user_message_preview": user_message_preview or {"first_lines": 2, "last_lines": 2},
},
"agent": {},
"terminal": {"env_type": "local"},
}
clean_env = {"LLM_MODEL": "", "HERMES_MAX_ITERATIONS": ""}
prompt_toolkit_stubs = {
"prompt_toolkit": MagicMock(),
"prompt_toolkit.history": MagicMock(),
"prompt_toolkit.styles": MagicMock(),
"prompt_toolkit.patch_stdout": MagicMock(),
"prompt_toolkit.application": MagicMock(),
"prompt_toolkit.layout": MagicMock(),
"prompt_toolkit.layout.processors": MagicMock(),
"prompt_toolkit.filters": MagicMock(),
"prompt_toolkit.layout.dimension": MagicMock(),
"prompt_toolkit.layout.menus": MagicMock(),
"prompt_toolkit.widgets": MagicMock(),
"prompt_toolkit.key_binding": MagicMock(),
"prompt_toolkit.completion": MagicMock(),
"prompt_toolkit.formatted_text": MagicMock(),
"prompt_toolkit.auto_suggest": MagicMock(),
}
with patch.dict(sys.modules, prompt_toolkit_stubs), patch.dict("os.environ", clean_env, clear=False):
import cli as mod
mod = importlib.reload(mod)
_cli_mod = mod
with patch.object(mod, "get_tool_definitions", return_value=[]), patch.dict(mod.__dict__, {"CLI_CONFIG": clean_config}):
return mod.HermesCLI()
class TestSubmittedUserMessagePreview:
def test_default_preview_shows_first_two_lines_and_last_two_lines(self):
cli = _make_cli()
rendered = cli._format_submitted_user_message_preview(
"line1\nline2\nline3\nline4\nline5\nline6"
)
assert "line1" in rendered
assert "line2" in rendered
assert "line5" in rendered
assert "line6" in rendered
assert "line3" not in rendered
assert "line4" not in rendered
assert "(+2 more lines)" in rendered
def test_preview_can_hide_last_lines(self):
cli = _make_cli({"first_lines": 2, "last_lines": 0})
rendered = cli._format_submitted_user_message_preview(
"line1\nline2\nline3\nline4\nline5\nline6"
)
assert "line1" in rendered
assert "line2" in rendered
assert "line5" not in rendered
assert "line6" not in rendered
assert "(+4 more lines)" in rendered
def test_invalid_first_lines_value_falls_back_to_one(self):
cli = _make_cli({"first_lines": 0, "last_lines": 2})
rendered = cli._format_submitted_user_message_preview("line1\nline2\nline3\nline4")
assert "line1" in rendered
assert "line3" in rendered
assert "line4" in rendered
assert "(+1 more line)" in rendered