mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
139 lines
4.7 KiB
Python
139 lines
4.7 KiB
Python
"""Tests for the gateway /queue command handler (running-agent path).
|
|
|
|
/queue stores a turn-boundary follow-up in the adapter's pending queue
|
|
without interrupting the active run. The queued event must carry the
|
|
full payload — media attachments and reply context — not just the text.
|
|
Previously the handler rebuilt the event with only text/type/source/
|
|
message_id/channel_prompt, silently dropping any photo/document/reply
|
|
metadata the user attached to the /queue message.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from datetime import datetime
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import GatewayConfig, Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType
|
|
from gateway.session import SessionEntry, SessionSource, build_session_key
|
|
|
|
|
|
def _make_source() -> SessionSource:
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
user_id="u1",
|
|
chat_id="c1",
|
|
user_name="tester",
|
|
chat_type="dm",
|
|
)
|
|
|
|
|
|
def _make_runner(session_entry: SessionEntry):
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.config = GatewayConfig(
|
|
platforms={Platform.TELEGRAM: PlatformConfig(enabled=True, token="***")}
|
|
)
|
|
adapter = MagicMock()
|
|
adapter.send = AsyncMock()
|
|
adapter._pending_messages = {}
|
|
runner.adapters = {Platform.TELEGRAM: adapter}
|
|
runner._voice_mode = {}
|
|
runner.hooks = SimpleNamespace(emit=AsyncMock(), loaded_hooks=False)
|
|
runner.session_store = MagicMock()
|
|
runner.session_store.get_or_create_session.return_value = session_entry
|
|
runner.session_store.load_transcript.return_value = []
|
|
runner.session_store.has_any_sessions.return_value = True
|
|
runner._running_agents = {}
|
|
runner._running_agents_ts = {}
|
|
runner._pending_messages = {}
|
|
runner._queued_events = {}
|
|
runner._pending_approvals = {}
|
|
runner._session_db = MagicMock()
|
|
runner._session_db.get_session_title.return_value = None
|
|
runner._reasoning_config = None
|
|
runner._provider_routing = {}
|
|
runner._fallback_model = None
|
|
runner._show_reasoning = False
|
|
runner._is_user_authorized = lambda _source: True
|
|
runner._set_session_env = lambda _context: None
|
|
runner._should_send_voice_reply = lambda *_args, **_kwargs: False
|
|
runner._send_voice_reply = AsyncMock()
|
|
runner._capture_gateway_honcho_if_configured = lambda *args, **kwargs: None
|
|
runner._emit_gateway_run_progress = AsyncMock()
|
|
return runner, adapter
|
|
|
|
|
|
def _session_entry() -> SessionEntry:
|
|
return SessionEntry(
|
|
session_key=build_session_key(_make_source()),
|
|
session_id="sess-1",
|
|
created_at=datetime.now(),
|
|
updated_at=datetime.now(),
|
|
platform=Platform.TELEGRAM,
|
|
chat_type="dm",
|
|
total_tokens=0,
|
|
)
|
|
|
|
|
|
def _running(runner):
|
|
"""Mark the session as having a running agent so /queue hits the
|
|
early-intercept path."""
|
|
sk = build_session_key(_make_source())
|
|
runner._running_agents[sk] = MagicMock()
|
|
return sk
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_queue_preserves_photo_media():
|
|
"""A /queue carrying a photo must keep the attachment + type."""
|
|
runner, adapter = _make_runner(_session_entry())
|
|
sk = _running(runner)
|
|
|
|
event = MessageEvent(
|
|
text="/queue look at this",
|
|
message_type=MessageType.PHOTO,
|
|
source=_make_source(),
|
|
message_id="q-photo",
|
|
media_urls=["/tmp/photo-a.jpg"],
|
|
media_types=["image/jpeg"],
|
|
)
|
|
result = await runner._handle_message(event)
|
|
|
|
assert result is not None and "queued" in result.lower()
|
|
queued = adapter._pending_messages[sk]
|
|
assert queued.text == "look at this"
|
|
assert queued.message_type == MessageType.PHOTO
|
|
assert queued.media_urls == ["/tmp/photo-a.jpg"]
|
|
assert queued.media_types == ["image/jpeg"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_queue_preserves_reply_context():
|
|
runner, adapter = _make_runner(_session_entry())
|
|
sk = _running(runner)
|
|
|
|
event = MessageEvent(
|
|
text="/queue and this",
|
|
source=_make_source(),
|
|
message_id="q-reply",
|
|
reply_to_message_id="orig-7",
|
|
reply_to_text="the original message",
|
|
reply_to_author_id="a1",
|
|
reply_to_author_name="alice",
|
|
)
|
|
result = await runner._handle_message(event)
|
|
|
|
assert result is not None and "queued" in result.lower()
|
|
queued = adapter._pending_messages[sk]
|
|
assert queued.reply_to_message_id == "orig-7"
|
|
assert queued.reply_to_text == "the original message"
|
|
assert queued.reply_to_author_id == "a1"
|
|
assert queued.reply_to_author_name == "alice"
|
|
|
|
|
|
if __name__ == "__main__": # pragma: no cover
|
|
pytest.main([__file__, "-v"])
|