mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.
app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help
components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
(structurally load-bearing / edge-case-heavy)
config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
`.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts
hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
MeasuredNode interface + one cast site
root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
members
eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
(compiled by react/compiler, deps live in $[N] memo arrays that
eslint can't introspect) and removed the now-orphan in-file
disable directive in ScrollBox.tsx
fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
{ force: true }) — kills the no-empty lint error and is more
idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
two useEffect dep arrays (they're stable React setState setters;
adding is safe and silences exhaustive-deps)
verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
tests/hermes_cli/test_tui_resume_flow.py
tests/hermes_cli/test_tui_npm_install.py → 57/57
144 lines
3.5 KiB
TypeScript
144 lines
3.5 KiB
TypeScript
import { Box, Text, useInput } from '@hermes/ink'
|
|
import { useEffect, useState } from 'react'
|
|
|
|
import type { GatewayClient } from '../gatewayClient.js'
|
|
import type { SessionListItem, SessionListResponse } from '../gatewayTypes.js'
|
|
import { asRpcResult, rpcErrorMessage } from '../lib/rpc.js'
|
|
import type { Theme } from '../theme.js'
|
|
|
|
const VISIBLE = 15
|
|
|
|
const age = (ts: number) => {
|
|
const d = (Date.now() / 1000 - ts) / 86400
|
|
|
|
if (d < 1) {
|
|
return 'today'
|
|
}
|
|
|
|
if (d < 2) {
|
|
return 'yesterday'
|
|
}
|
|
|
|
return `${Math.floor(d)}d ago`
|
|
}
|
|
|
|
export function SessionPicker({ gw, onCancel, onSelect, t }: SessionPickerProps) {
|
|
const [items, setItems] = useState<SessionListItem[]>([])
|
|
const [err, setErr] = useState('')
|
|
const [sel, setSel] = useState(0)
|
|
const [loading, setLoading] = useState(true)
|
|
|
|
useEffect(() => {
|
|
gw.request<SessionListResponse>('session.list', { limit: 20 })
|
|
.then(raw => {
|
|
const r = asRpcResult<SessionListResponse>(raw)
|
|
|
|
if (!r) {
|
|
setErr('invalid response: session.list')
|
|
setLoading(false)
|
|
|
|
return
|
|
}
|
|
|
|
setItems(r.sessions ?? [])
|
|
setErr('')
|
|
setLoading(false)
|
|
})
|
|
.catch((e: unknown) => {
|
|
setErr(rpcErrorMessage(e))
|
|
setLoading(false)
|
|
})
|
|
}, [gw])
|
|
|
|
useInput((ch, key) => {
|
|
if (key.escape) {
|
|
return onCancel()
|
|
}
|
|
|
|
if (key.upArrow && sel > 0) {
|
|
setSel(s => s - 1)
|
|
}
|
|
|
|
if (key.downArrow && sel < items.length - 1) {
|
|
setSel(s => s + 1)
|
|
}
|
|
|
|
if (key.return && items[sel]) {
|
|
onSelect(items[sel]!.id)
|
|
}
|
|
|
|
const n = parseInt(ch)
|
|
|
|
if (n >= 1 && n <= Math.min(9, items.length)) {
|
|
onSelect(items[n - 1]!.id)
|
|
}
|
|
})
|
|
|
|
if (loading) {
|
|
return <Text color={t.color.dim}>loading sessions…</Text>
|
|
}
|
|
|
|
if (err) {
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text color={t.color.label}>error: {err}</Text>
|
|
<Text color={t.color.dim}>Esc to cancel</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
if (!items.length) {
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text color={t.color.dim}>no previous sessions</Text>
|
|
<Text color={t.color.dim}>Esc to cancel</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
const off = Math.max(0, Math.min(sel - Math.floor(VISIBLE / 2), items.length - VISIBLE))
|
|
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text bold color={t.color.amber}>
|
|
Resume Session
|
|
</Text>
|
|
|
|
{off > 0 && <Text color={t.color.dim}> ↑ {off} more</Text>}
|
|
|
|
{items.slice(off, off + VISIBLE).map((s, vi) => {
|
|
const i = off + vi
|
|
|
|
return (
|
|
<Box key={s.id}>
|
|
<Text color={sel === i ? t.color.label : t.color.dim}>{sel === i ? '▸ ' : ' '}</Text>
|
|
|
|
<Box width={30}>
|
|
<Text color={sel === i ? t.color.cornsilk : t.color.dim}>
|
|
{String(i + 1).padStart(2)}. [{s.id}]
|
|
</Text>
|
|
</Box>
|
|
|
|
<Box width={30}>
|
|
<Text color={t.color.dim}>
|
|
({s.message_count} msgs, {age(s.started_at)}, {s.source || 'tui'})
|
|
</Text>
|
|
</Box>
|
|
|
|
<Text color={sel === i ? t.color.cornsilk : t.color.dim}>{s.title || s.preview || '(untitled)'}</Text>
|
|
</Box>
|
|
)
|
|
})}
|
|
|
|
{off + VISIBLE < items.length && <Text color={t.color.dim}> ↓ {items.length - off - VISIBLE} more</Text>}
|
|
<Text color={t.color.dim}>↑/↓ select · Enter resume · 1-9 quick · Esc cancel</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
interface SessionPickerProps {
|
|
gw: GatewayClient
|
|
onCancel: () => void
|
|
onSelect: (id: string) => void
|
|
t: Theme
|
|
}
|