mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-08 13:12:08 +00:00
Drop the Responses-API native compaction path and its opt-in umbrella flag from the salvaged feature. On the Codex OAuth chat route Hermes owns the message list and the summary compressor works (and stays provider-portable — encrypted compaction items would lock the session history to chatgpt.com and break /model switches and provider fallback). On the app-server runtime (codex CLI/agent) the codex agent owns the real thread context, so thread/compact/start is the only mechanism that can actually shrink it (#36801) — that path is now the default behavior for codex_app_server sessions, controlled by compression.codex_app_server_auto (native|hermes|off), no umbrella flag. Removed: responses.compact() call path, codex_compaction_items replay/ persistence plumbing, codex_native_compaction + codex_responses_threshold config keys, desktop settings fields, and their tests. Kept: everything app-server (compact_thread(), compaction notifications, bookkeeping, docs, tests) plus cache-busting keys for the surviving knobs.
194 lines
5.6 KiB
Python
194 lines
5.6 KiB
Python
from types import SimpleNamespace
|
|
|
|
from agent.codex_runtime import _record_codex_app_server_compaction
|
|
from agent.conversation_compression import COMPACTION_STATUS, compress_context
|
|
from agent.transports.codex_app_server_session import TurnResult
|
|
|
|
|
|
class FakeCodexSession:
|
|
def __init__(self, result):
|
|
self.result = result
|
|
self.calls = 0
|
|
self.closed = False
|
|
|
|
def compact_thread(self):
|
|
self.calls += 1
|
|
return self.result
|
|
|
|
def close(self):
|
|
self.closed = True
|
|
|
|
|
|
class DummyAgent:
|
|
def __init__(
|
|
self,
|
|
result,
|
|
*,
|
|
auto_compaction="native",
|
|
):
|
|
self.api_mode = "codex_app_server"
|
|
self.codex_app_server_auto_compaction = auto_compaction
|
|
self.session_id = "hermes-session-1"
|
|
self.platform = "cli"
|
|
self._cached_system_prompt = "cached prompt"
|
|
self._codex_session = FakeCodexSession(result)
|
|
self.context_compressor = SimpleNamespace(
|
|
compression_count=0,
|
|
last_compression_rough_tokens=0,
|
|
last_prompt_tokens=123,
|
|
last_completion_tokens=45,
|
|
awaiting_real_usage_after_compression=False,
|
|
)
|
|
self.statuses = []
|
|
self.warnings = []
|
|
self.events = []
|
|
self.built_prompts = []
|
|
|
|
def _emit_status(self, message):
|
|
self.statuses.append(message)
|
|
|
|
def _emit_warning(self, message):
|
|
self.warnings.append(message)
|
|
|
|
def _build_system_prompt(self, system_message):
|
|
self.built_prompts.append(system_message)
|
|
return "built prompt"
|
|
|
|
def event_callback(self, name, payload):
|
|
self.events.append((name, payload))
|
|
|
|
|
|
def test_codex_app_server_native_auto_mode_leaves_thread_compaction_to_codex():
|
|
agent = DummyAgent(
|
|
TurnResult(thread_id="thread-1", turn_id="compact-turn-1")
|
|
)
|
|
messages = [{"role": "user", "content": "hi"}]
|
|
|
|
returned, prompt = compress_context(
|
|
agent,
|
|
messages,
|
|
"system",
|
|
approx_tokens=100000,
|
|
task_id="test",
|
|
)
|
|
|
|
assert returned is messages
|
|
assert prompt == "cached prompt"
|
|
assert agent._codex_session.calls == 0
|
|
assert agent.context_compressor.compression_count == 0
|
|
assert agent.events == []
|
|
|
|
|
|
def test_codex_app_server_manual_compression_routes_to_codex_thread():
|
|
agent = DummyAgent(
|
|
TurnResult(thread_id="thread-1", turn_id="compact-turn-1")
|
|
)
|
|
messages = [
|
|
{"role": "user", "content": "hi"},
|
|
{"role": "assistant", "content": "hello"},
|
|
]
|
|
|
|
returned, prompt = compress_context(
|
|
agent,
|
|
messages,
|
|
"system",
|
|
approx_tokens=100000,
|
|
task_id="test",
|
|
force=True,
|
|
)
|
|
|
|
assert returned is messages
|
|
assert prompt == "cached prompt"
|
|
assert agent._codex_session.calls == 1
|
|
assert agent.context_compressor.compression_count == 1
|
|
assert agent.context_compressor.last_compression_rough_tokens == 100000
|
|
assert agent.context_compressor.last_prompt_tokens == -1
|
|
assert agent.context_compressor.last_completion_tokens == 0
|
|
assert agent.context_compressor.awaiting_real_usage_after_compression is True
|
|
assert agent.events == [
|
|
(
|
|
"session:compress",
|
|
{
|
|
"platform": "cli",
|
|
"session_id": "hermes-session-1",
|
|
"old_session_id": "",
|
|
"in_place": False,
|
|
"compression_count": 1,
|
|
"runtime": "codex_app_server",
|
|
"thread_id": "thread-1",
|
|
"turn_id": "compact-turn-1",
|
|
},
|
|
)
|
|
]
|
|
|
|
|
|
def test_codex_app_server_hermes_mode_auto_compression_routes_to_codex_thread():
|
|
agent = DummyAgent(
|
|
TurnResult(thread_id="thread-1", turn_id="compact-turn-1"),
|
|
auto_compaction="hermes",
|
|
)
|
|
messages = [{"role": "user", "content": "hi"}]
|
|
|
|
returned, prompt = compress_context(
|
|
agent,
|
|
messages,
|
|
"system",
|
|
approx_tokens=100000,
|
|
)
|
|
|
|
assert returned is messages
|
|
assert prompt == "cached prompt"
|
|
assert agent._codex_session.calls == 1
|
|
assert agent.context_compressor.compression_count == 1
|
|
|
|
|
|
def test_codex_app_server_compression_failure_preserves_bookkeeping():
|
|
agent = DummyAgent(TurnResult(error="compact failed"))
|
|
messages = [{"role": "user", "content": "hi"}]
|
|
|
|
returned, prompt = compress_context(
|
|
agent,
|
|
messages,
|
|
"system",
|
|
approx_tokens=100000,
|
|
force=True,
|
|
)
|
|
|
|
assert returned is messages
|
|
assert prompt == "cached prompt"
|
|
assert agent._codex_session.calls == 1
|
|
assert agent.context_compressor.compression_count == 0
|
|
assert agent.context_compressor.last_prompt_tokens == 123
|
|
assert agent.warnings
|
|
|
|
|
|
def test_codex_app_server_native_compaction_notice_emits_status_and_event():
|
|
agent = DummyAgent(
|
|
TurnResult(thread_id="thread-1", turn_id="normal-turn-1")
|
|
)
|
|
turn = TurnResult(
|
|
thread_id="thread-1",
|
|
turn_id="normal-turn-1",
|
|
compacted=True,
|
|
)
|
|
|
|
recorded = _record_codex_app_server_compaction(agent, turn)
|
|
|
|
assert recorded is True
|
|
assert agent.context_compressor.compression_count == 1
|
|
assert agent.statuses == [COMPACTION_STATUS]
|
|
assert agent.events == [
|
|
(
|
|
"session:compress",
|
|
{
|
|
"platform": "cli",
|
|
"session_id": "hermes-session-1",
|
|
"old_session_id": "",
|
|
"in_place": False,
|
|
"compression_count": 1,
|
|
"runtime": "codex_app_server",
|
|
"thread_id": "thread-1",
|
|
"turn_id": "normal-turn-1",
|
|
},
|
|
)
|
|
]
|