knoal 33a529538d fix(gateway): strip stale dangerous-confirmation text in user messages (#59607) ... When a high-risk side effect (e.g. host restart via shutdown.exe) runs, the user's plain-text confirmation phrase is persisted in the conversation transcript. If the host restart killed the gateway process before the assistant's tool result was written, the transcript tail ends on the assistant's text response - and the dangerous confirmation text remains in the user role. On the next inbound message - possibly a casual 'are you there?' from the user minutes later - the LLM sees the stale confirmation and may interpret the new turn as a fresh re-confirmation, re-executing the destructive action. This is the failure mode reported in #59607. Fix: - Add strip_stale_dangerous_confirmations() in agent/replay_cleanup.py that removes user messages whose content matches a known dangerous confirmation pattern AND whose timestamp is older than 60 seconds. - Add is_dangerous_confirmation() helper with the matched patterns (i18n-aware: covers 確認強制重開機 from the original incident). - Wire the stripper into _build_gateway_agent_history() right after the existing 75ed07ace strippers, so the strip chain is: strip_interrupted_tool_tails -> strip_dangling_tool_call_tail -> strip_stale_dangerous_confirmations. - Update _build_replay_entry() to preserve the timestamp on user messages (it was previously dropped), since the new stripper needs it. Complements 75ed07ace (which strips the assistant side of the broken tail) by handling the user side: a stale plain-text confirmation that the assistant has not yet responded to in a way the resume logic recognises. Failing-test-first discipline: the bug-detection test test_stale_confirmation_text_is_stripped_on_resume fails on unfixed code (proves the test catches the bug) and passes after the fix. Five additional safety tests confirm no regression on: - fresh confirmations (within expiry) are preserved - non-confirmation text is preserved - non-matching histories are untouched - dangerous-pattern detection works in all cases (case, i18n, None) - direct unit test of the strip helper Refs: #59607		2026-07-07 14:40:32 +05:30
..
acp	fix(acp): also preserve archived rows on model-switch / restore saves	2026-07-01 17:16:51 +05:30
acp_adapter
agent	fix(usage): scope Codex usage pool fallback to AuthError, keep singleton token on account_id read failure	2026-07-07 12:01:33 +05:30
ci	fix(ci): classify should default to no MCP	2026-06-23 10:32:27 -07:00
cli	perf(cli): TTFT round 2 — live reasoning by default, partial-line streaming, prompt-build cache, stale budget-warning docs (#59389)	2026-07-06 00:16:38 -07:00
computer_use	fix(computer-use): sanitize env on the 4 remaining cua-driver spawn sites (#59165)	2026-07-05 14:48:20 -07:00
cron	refactor(cron): derive one-shot run-claim TTL from HERMES_CRON_TIMEOUT (#59567)	2026-07-06 04:57:09 -07:00
dashboard	fix(dashboard): use loopback host for in-container WebSocket client (#58993) [salvage #59682] (#60092)	2026-07-07 18:33:28 +10:00
docker	fix: remove dead f-string prefixes via ruff F541 (216 sites) (#52336)	2026-07-05 13:42:46 -07:00
e2e	fix(gateway): route SessionDB calls through AsyncSessionDB	2026-06-29 15:51:57 -07:00
fakes
fixtures/plugins/example-dashboard/dashboard
gateway	fix(gateway): strip stale dangerous-confirmation text in user messages (#59607)	2026-07-07 14:40:32 +05:30
hermes_cli	fix(auth): per-profile Anthropic OAuth file + complete port-binding platform set (#57563 salvage) (#59339)	2026-07-07 08:33:06 +00:00
hermes_state	fix(state): exclude delegate/branch/tool children from resume walk + reconcile salvaged fixes	2026-06-25 16:29:09 -07:00
honcho_plugin	feat(memory): Honcho OAuth connect — desktop and CLI flows + token refresh (#44335)	2026-06-22 19:16:47 -05:00
integration	fix: remove dead f-string prefixes via ruff F541 (216 sites) (#52336)	2026-07-05 13:42:46 -07:00
manual	docs(cron): scope in_channel to channels; document DM continuation knob	2026-07-01 03:16:13 -07:00
openviking_plugin	feat(openviking): add full recall prefetch policy	2026-06-24 18:53:49 +05:30
plugins	fix(photon): auto-reinstall stale sidecar deps before start	2026-07-05 17:38:32 -07:00
providers	fix(models): pass model.base_url to fetch_models in /model picker	2026-06-16 13:09:40 -07:00
run_agent	test: expect model slug in autoraise notice dict (follow-up to gpt-5.4 extension)	2026-07-06 12:46:20 -07:00
scripts	revert(windows): roll back terminal-popup PRs #53791 #53810 #53829 (#53853)	2026-06-27 15:59:00 -07:00
secret_sources	feat(secrets): adapt 1Password onto the SecretSource interface	2026-07-06 04:58:07 -07:00
skills	blocked-tail pass: blind opt-out default, email fallback, peopleconnect delete-wipes-suppression	2026-07-03 15:21:04 -04:00
stress	fix: remove dead f-string prefixes via ruff F541 (216 sites) (#52336)	2026-07-05 13:42:46 -07:00
tools	feat(docker): re-seed a terminally-dead Nous bootstrap session on boot (#59983)	2026-07-07 06:57:23 +00:00
tui_gateway	fix(tui_gateway): route setup.runtime_check and setup.status to RPC pool	2026-07-02 15:44:37 -05:00
website
__init__.py
conftest.py	feat(managed-scope): add managed_scope module (resolver, loaders, key helpers)	2026-06-19 07:46:33 -07:00
run_interrupt_test.py
test_account_usage.py
test_assistant_ui_tap_compat.py	test(deps): guard @assistant-ui cluster on one tap version	2026-06-15 11:55:02 -04:00
test_atomic_replace_symlinks.py	fix(config): preserve owner on atomic writes (#56644)	2026-07-03 14:27:34 +10:00
test_background_review_list_shapes.py	fix(background-review): guard summarize against list-shaped tool responses (#59437)	2026-07-06 03:28:30 -07:00
test_background_review_session_isolation.py	test(review): add integration guards for the two isolation wirings (review)	2026-07-01 16:21:39 +05:30
test_base_url_hostname.py
test_batch_runner_checkpoint.py
test_bitwarden_secrets.py	feat(secrets): pluggable SecretSource interface + multi-source orchestrator	2026-07-06 04:58:07 -07:00
test_cli_file_drop.py
test_cli_manual_compress.py
test_cli_skin_integration.py
test_code_skew.py	fix(gateway): refuse model switch on stale checkout to avoid env_float ImportError	2026-06-24 04:16:54 +05:30
test_copilot_initiator.py	fix(copilot): set x-initiator per turn so user prompts bill as premium requests (salvage #4097) (#58544)	2026-07-05 00:44:15 -07:00
test_ctx_halving_fix.py
test_dashboard_sidecar_close_on_disconnect.py	fix(dashboard): hide sidecar sessions from history (#49269)	2026-06-19 18:06:38 -04:00
test_delegate_cascade_49148.py	fix(agent): stop delegate cascade from deleting the parent session	2026-06-21 12:09:16 -07:00
test_desktop_electron_pin.py	fix(desktop): resolve electronDist dynamically + self-heal blocked installs (supersedes #48081/#48082) (#48091)	2026-06-17 18:48:35 -05:00
test_desktop_mac_entitlements.py
test_dispatch_session_id.py	fix(dispatch): forward session_id into registry.dispatch (#28479)	2026-06-14 00:27:59 -04:00
test_empty_model_fallback.py
test_empty_session_hygiene.py
test_env_loader_op_bootstrap.py	fix(secrets): make 1Password bootstrap token reliable outside systemd	2026-07-06 04:58:07 -07:00
test_env_loader_secret_sources.py	feat(secrets): adapt 1Password onto the SecretSource interface	2026-07-06 04:58:07 -07:00
test_evidence_store.py
test_fast_safe_load.py	perf(startup): parse config + plugin manifests with libyaml CSafeLoader (#54486)	2026-06-28 15:38:39 -07:00
test_gateway_streaming_nested_config.py
test_get_tool_definitions_cache_isolation.py
test_hermes_bootstrap.py	revert(windows): roll back terminal-popup PRs #53791 #53810 #53829 (#53853)	2026-06-27 15:59:00 -07:00
test_hermes_constants.py	test: update reasoning-effort docstring guards for new 'max' level	2026-07-04 14:19:44 +05:30
test_hermes_home_profile_warning.py
test_hermes_logging.py	fix(logging): drive rotating file handlers through an async QueueListener	2026-07-05 11:44:53 +05:30
test_hermes_state.py	fix(state): heal NULL active rows on every startup, not just pre-v12 DBs	2026-07-07 14:40:18 +05:30
test_hermes_state_compression_locks.py
test_hermes_state_wal_fallback.py
test_honcho_client_concurrency.py
test_honcho_client_config.py
test_honcho_session_context.py
test_honcho_startup_fail_open.py
test_install_diverged_update.py	test(installer): cover diverged managed-clone recovery in install scripts	2026-06-30 20:11:01 +07:00
test_install_lockfile_churn.py	fix(install): discard managed lockfile churn before stashing	2026-06-25 23:49:11 -07:00
test_install_no_initial_commit.py
test_install_ps1_native_stderr_eap.py	fix(install): fail fast when uv venv genuinely fails under relaxed EAP	2026-06-18 22:11:35 +05:30
test_install_ps1_python_fallback_venv.py	test(installer): lock Python-fallback propagation into the venv stage (#50769)	2026-06-23 21:33:08 -07:00
test_install_ps1_uv_powershell_host.py	test(install): lock uv installer to a resolved PowerShell host	2026-06-18 16:26:34 +07:00
test_install_ps1_web_server_syntax_probe.py	fix(install): guard Windows desktop installs against broken web_server	2026-07-05 19:35:30 -07:00
test_install_sh_browser_install.py	test(install): track run_with_timeout extraction after #39219 refactor (#54185)	2026-06-28 03:58:01 -07:00
test_install_sh_install_method_stamp.py	fix(update): scope install-method stamp to the code tree, not $HERMES_HOME (#48188)	2026-06-18 14:14:41 +10:00
test_install_sh_node_global_prefix.py	fix(hermes): heal broken managed Node tree instead of PATH fallback	2026-06-26 20:10:20 +05:30
test_install_sh_pythonpath_sanitization.py
test_install_sh_root_fhs_uv_python_path.py
test_install_sh_setup_wizard_tty_probe.py
test_install_sh_symlink_stomp.py
test_install_sh_termux_network_prereqs.py
test_install_unmerged_index.py	fix(install): discard managed lockfile churn before stashing	2026-06-25 23:49:11 -07:00
test_ipv4_preference.py
test_lazy_session_regressions.py	fix(gateway): surface retry hint instead of silently dropping turn after /stop (#31884)	2026-06-24 23:51:31 +05:30
test_lint_config.py
test_live_system_guard_self_test.py
test_mcp_serve.py	refactor: consolidate gateway session metadata into state.db (#58899)	2026-07-05 14:01:03 -07:00
test_mini_swe_runner.py
test_minimax_model_validation.py
test_minimax_oauth.py
test_minisweagent_path.py
test_model_forces_max_completion_tokens.py
test_model_picker_scroll.py
test_model_tools.py	fix(toolsets): preserve core tools when a posture toolset is in disabled_toolsets (#57315)	2026-07-05 14:51:49 -07:00
test_model_tools_async_bridge.py
test_ollama_num_ctx.py	test(vision): cover Ollama /api/show vision capability routing (#54511)	2026-06-28 22:52:59 -07:00
test_onepassword_secrets.py	feat(secrets): add 1Password (op://) secret source	2026-07-06 04:58:07 -07:00
test_output_cap_parsing.py	fix(context): parse vLLM's token-based output-cap error format	2026-07-01 03:17:48 -07:00
test_package_json_lazy_deps.py
test_packaging_metadata.py	security(deps): enforce aiohttp CVE floor on all lazy messaging paths + coverage guard	2026-07-01 02:51:45 -07:00
test_plugin_skills.py
test_plugin_utils.py
test_process_loop_event_loop_warning.py
test_profile_isolation_runtime.py	test(profile): two-profile regression suite + preserve skills_hub monkeypatch seam	2026-06-30 15:30:06 -07:00
test_project_metadata.py	fix(memory): lazy-install supermemory + mem0 SDKs like honcho/hindsight	2026-06-29 00:25:36 -07:00
test_retry_utils.py	refactor(retry): single-source Z.AI overload short-attempts + drop change-detector assert	2026-07-07 11:57:01 +05:30
test_run_tests_parallel.py	fix(tests): bare pytest flags pass through run_tests.sh without a '--' separator (#54008)	2026-06-27 22:43:26 -07:00
test_sanitize_tool_error.py
test_setup_temporary_outputs.py	refactor(ci): rewrite docker tests to check built container	2026-06-26 19:15:18 -07:00
test_slash_worker_watchdog.py
test_sql_injection.py
test_stale_utils_module_import.py	fix(gateway): refuse model switch on stale checkout to avoid env_float ImportError	2026-06-24 04:16:54 +05:30
test_state_db_malformed_repair.py	fix(state): detect and repair FTS write corruption that silently drops gateway history (#52798)	2026-06-25 21:18:41 -07:00
test_subprocess_home_isolation.py	fix: make profile subprocess HOME policy explicit	2026-06-14 03:20:21 -07:00
test_termux_all_extra_compat.py
test_timezone.py
test_toolset_distributions.py
test_toolsets.py	feat(mcp): adopt mcp__server__tool naming convention	2026-07-05 13:40:21 -07:00
test_trajectory_compressor.py
test_trajectory_compressor_async.py
test_transform_llm_output_hook.py
test_transform_tool_result_hook.py
test_tui_gateway_loop_noise.py	fix(tui_gateway): suppress WS peer-hangup teardown error flood (#50005) (#54126)	2026-06-28 02:35:01 -07:00
test_tui_gateway_queue_on_busy.py	fix(tui_gateway): queue mid-turn prompts instead of dropping them on a busy retry	2026-06-25 12:29:49 -05:00
test_tui_gateway_server.py	fix(tui): probe active custom model provider	2026-07-06 13:08:50 -07:00
test_tui_gateway_ws.py	fix(tui): start MCP discovery for websocket sessions	2026-06-28 04:14:12 -07:00
test_tui_mcp_late_refresh.py	fix(tui): refresh tool snapshot when MCP discovery lands after agent build (#48403)	2026-06-18 05:41:23 -07:00
test_utils_truthy_values.py
test_web_server.py	fix(dashboard): disable ws keepalive ping on loopback to survive event-loop stalls	2026-07-03 03:33:22 +05:30
test_wheel_locales_e2e.py
test_windows_subprocess_no_window_flags.py	test: make windows no-window-flag assertions immune to update-check daemon	2026-06-30 01:35:55 -05:00
test_yaml_indent_consistency_31999.py	fix(utils): unify YAML list indent across all config writers (#31999)	2026-06-25 23:27:44 +05:30
test_yuanbao_integration.py
test_yuanbao_markdown.py
test_yuanbao_pipeline.py	fix(yuanbao): skip resource resolve on cache hits	2026-07-05 13:53:30 -07:00
test_yuanbao_proto.py
test_yuanbao_reconnect_set_active.py	fix(yuanbao): restore active singleton after WS reconnect	2026-07-05 00:41:34 -07:00
test_yuanbao_shutdown.py