mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-18 04:41:56 +00:00
6f285efb80
When the user runs /stop or a session is interrupted mid-flight, the 👀 in-progress reaction lingered on the user's message indefinitely. Without another agent run to swap it for 👍/👎, the eyes stayed there forever — visually misleading (looks like the agent is still working). Fix: on ProcessingOutcome.CANCELLED, call set_message_reaction with reaction=None to clear all reactions on the message. Documented Bot API semantics (equivalent to Bot API 10.0's deleteMessageReaction, but works on PTB 22.6 already without the version bump). Test changes: - Renamed test_on_processing_complete_cancelled_keeps_existing_reaction → test_on_processing_complete_cancelled_clears_reaction; updated assertion to expect set_message_reaction(reaction=None). - Added test_on_processing_complete_cancelled_skipped_when_disabled (TELEGRAM_REACTIONS=false short-circuits). - Added test_clear_reactions_handles_api_error_gracefully and test_clear_reactions_returns_false_without_bot to cover the new _clear_reactions helper.
317 lines
10 KiB
Python
317 lines
10 KiB
Python
"""Tests for Telegram message reactions tied to processing lifecycle hooks."""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType, ProcessingOutcome
|
|
from gateway.session import SessionSource
|
|
|
|
|
|
def _make_adapter(**extra_env):
|
|
from gateway.platforms.telegram import TelegramAdapter
|
|
|
|
adapter = object.__new__(TelegramAdapter)
|
|
adapter.platform = Platform.TELEGRAM
|
|
adapter.config = PlatformConfig(enabled=True, token="fake-token")
|
|
adapter._bot = AsyncMock()
|
|
adapter._bot.set_message_reaction = AsyncMock()
|
|
return adapter
|
|
|
|
|
|
def _make_event(chat_id: str = "123", message_id: str = "456") -> MessageEvent:
|
|
return MessageEvent(
|
|
text="hello",
|
|
message_type=MessageType.TEXT,
|
|
source=SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id=chat_id,
|
|
chat_type="private",
|
|
user_id="42",
|
|
user_name="TestUser",
|
|
),
|
|
message_id=message_id,
|
|
)
|
|
|
|
|
|
# ── _reactions_enabled ───────────────────────────────────────────────
|
|
|
|
|
|
def test_reactions_disabled_by_default(monkeypatch):
|
|
"""Telegram reactions should be disabled by default."""
|
|
monkeypatch.delenv("TELEGRAM_REACTIONS", raising=False)
|
|
adapter = _make_adapter()
|
|
assert adapter._reactions_enabled() is False
|
|
|
|
|
|
def test_reactions_enabled_when_set_true(monkeypatch):
|
|
"""Setting TELEGRAM_REACTIONS=true enables reactions."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
assert adapter._reactions_enabled() is True
|
|
|
|
|
|
def test_reactions_enabled_with_1(monkeypatch):
|
|
"""TELEGRAM_REACTIONS=1 enables reactions."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "1")
|
|
adapter = _make_adapter()
|
|
assert adapter._reactions_enabled() is True
|
|
|
|
|
|
def test_reactions_disabled_with_false(monkeypatch):
|
|
"""TELEGRAM_REACTIONS=false disables reactions."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "false")
|
|
adapter = _make_adapter()
|
|
assert adapter._reactions_enabled() is False
|
|
|
|
|
|
def test_reactions_disabled_with_0(monkeypatch):
|
|
"""TELEGRAM_REACTIONS=0 disables reactions."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "0")
|
|
adapter = _make_adapter()
|
|
assert adapter._reactions_enabled() is False
|
|
|
|
|
|
def test_reactions_disabled_with_no(monkeypatch):
|
|
"""TELEGRAM_REACTIONS=no disables reactions."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "no")
|
|
adapter = _make_adapter()
|
|
assert adapter._reactions_enabled() is False
|
|
|
|
|
|
# ── _set_reaction ────────────────────────────────────────────────────
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_set_reaction_calls_bot_api(monkeypatch):
|
|
"""_set_reaction should call bot.set_message_reaction with correct args."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
|
|
result = await adapter._set_reaction("123", "456", "\U0001f440")
|
|
|
|
assert result is True
|
|
adapter._bot.set_message_reaction.assert_awaited_once_with(
|
|
chat_id=123,
|
|
message_id=456,
|
|
reaction="\U0001f440",
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_set_reaction_returns_false_without_bot(monkeypatch):
|
|
"""_set_reaction should return False when bot is not available."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
adapter._bot = None
|
|
|
|
result = await adapter._set_reaction("123", "456", "\U0001f440")
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_set_reaction_handles_api_error_gracefully(monkeypatch):
|
|
"""API errors during reaction should not propagate."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
adapter._bot.set_message_reaction = AsyncMock(side_effect=RuntimeError("no perms"))
|
|
|
|
result = await adapter._set_reaction("123", "456", "\U0001f440")
|
|
assert result is False
|
|
|
|
|
|
# ── on_processing_start ──────────────────────────────────────────────
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_start_adds_eyes_reaction(monkeypatch):
|
|
"""Processing start should add eyes reaction when enabled."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_start(event)
|
|
|
|
adapter._bot.set_message_reaction.assert_awaited_once_with(
|
|
chat_id=123,
|
|
message_id=456,
|
|
reaction="\U0001f440",
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_start_skipped_when_disabled(monkeypatch):
|
|
"""Processing start should not react when reactions are disabled."""
|
|
monkeypatch.delenv("TELEGRAM_REACTIONS", raising=False)
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_start(event)
|
|
|
|
adapter._bot.set_message_reaction.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_start_handles_missing_ids(monkeypatch):
|
|
"""Should handle events without chat_id or message_id gracefully."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
event = MessageEvent(
|
|
text="hello",
|
|
message_type=MessageType.TEXT,
|
|
source=SimpleNamespace(chat_id=None),
|
|
message_id=None,
|
|
)
|
|
|
|
await adapter.on_processing_start(event)
|
|
|
|
adapter._bot.set_message_reaction.assert_not_awaited()
|
|
|
|
|
|
# ── on_processing_complete ───────────────────────────────────────────
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_complete_success(monkeypatch):
|
|
"""Successful processing should set thumbs-up reaction."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_complete(event, ProcessingOutcome.SUCCESS)
|
|
|
|
adapter._bot.set_message_reaction.assert_awaited_once_with(
|
|
chat_id=123,
|
|
message_id=456,
|
|
reaction="\U0001f44d",
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_complete_failure(monkeypatch):
|
|
"""Failed processing should set thumbs-down reaction."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_complete(event, ProcessingOutcome.FAILURE)
|
|
|
|
adapter._bot.set_message_reaction.assert_awaited_once_with(
|
|
chat_id=123,
|
|
message_id=456,
|
|
reaction="\U0001f44e",
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_complete_skipped_when_disabled(monkeypatch):
|
|
"""Processing complete should not react when reactions are disabled."""
|
|
monkeypatch.delenv("TELEGRAM_REACTIONS", raising=False)
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_complete(event, ProcessingOutcome.SUCCESS)
|
|
|
|
adapter._bot.set_message_reaction.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_complete_cancelled_clears_reaction(monkeypatch):
|
|
"""Cancelled processing should clear the in-progress reaction.
|
|
|
|
Without this clear, the 👀 reaction lingers on the user's message
|
|
indefinitely (until another agent run swaps it for 👍/👎). On a
|
|
``/stop`` that ends a session, that reaction never gets cleaned up.
|
|
"""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_complete(event, ProcessingOutcome.CANCELLED)
|
|
|
|
# set_message_reaction with reaction=None clears all reactions on the
|
|
# message (Bot API documented semantics; equivalent to Bot API 10.0's
|
|
# deleteMessageReaction but works on PTB 22.6 already).
|
|
adapter._bot.set_message_reaction.assert_awaited_once_with(
|
|
chat_id=123,
|
|
message_id=456,
|
|
reaction=None,
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_processing_complete_cancelled_skipped_when_disabled(monkeypatch):
|
|
"""Cancelled processing should not call the API when reactions are off."""
|
|
monkeypatch.delenv("TELEGRAM_REACTIONS", raising=False)
|
|
adapter = _make_adapter()
|
|
event = _make_event()
|
|
|
|
await adapter.on_processing_complete(event, ProcessingOutcome.CANCELLED)
|
|
|
|
adapter._bot.set_message_reaction.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_clear_reactions_handles_api_error_gracefully(monkeypatch):
|
|
"""API errors during clear should not propagate."""
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "true")
|
|
adapter = _make_adapter()
|
|
adapter._bot.set_message_reaction = AsyncMock(side_effect=RuntimeError("no perms"))
|
|
|
|
result = await adapter._clear_reactions("123", "456")
|
|
assert result is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_clear_reactions_returns_false_without_bot(monkeypatch):
|
|
"""_clear_reactions should return False when bot is not available."""
|
|
adapter = _make_adapter()
|
|
adapter._bot = None
|
|
|
|
result = await adapter._clear_reactions("123", "456")
|
|
assert result is False
|
|
|
|
|
|
# ── config.py bridging ───────────────────────────────────────────────
|
|
|
|
|
|
def test_config_bridges_telegram_reactions(monkeypatch, tmp_path):
|
|
"""gateway/config.py bridges telegram.reactions to TELEGRAM_REACTIONS env var."""
|
|
import yaml
|
|
config_file = tmp_path / "config.yaml"
|
|
config_file.write_text(yaml.dump({
|
|
"telegram": {
|
|
"reactions": True,
|
|
},
|
|
}))
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
# Use setenv (not delenv) so monkeypatch registers cleanup even when
|
|
# the var doesn't exist yet — load_gateway_config will overwrite it.
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "")
|
|
|
|
from gateway.config import load_gateway_config
|
|
load_gateway_config()
|
|
|
|
import os
|
|
assert os.getenv("TELEGRAM_REACTIONS") == "true"
|
|
|
|
|
|
def test_config_reactions_env_takes_precedence(monkeypatch, tmp_path):
|
|
"""Env var should take precedence over config.yaml for reactions."""
|
|
import yaml
|
|
config_file = tmp_path / "config.yaml"
|
|
config_file.write_text(yaml.dump({
|
|
"telegram": {
|
|
"reactions": True,
|
|
},
|
|
}))
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
monkeypatch.setenv("TELEGRAM_REACTIONS", "false")
|
|
|
|
from gateway.config import load_gateway_config
|
|
load_gateway_config()
|
|
|
|
import os
|
|
assert os.getenv("TELEGRAM_REACTIONS") == "false"
|