mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
72 lines
2.7 KiB
Python
72 lines
2.7 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import pytest
|
|
|
|
from agent import image_gen_registry
|
|
from agent.image_gen_provider import ImageGenProvider
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_registry():
|
|
image_gen_registry._reset_for_tests()
|
|
yield
|
|
image_gen_registry._reset_for_tests()
|
|
|
|
|
|
class _FakeCodexProvider(ImageGenProvider):
|
|
@property
|
|
def name(self) -> str:
|
|
return "codex"
|
|
|
|
def generate(self, prompt, aspect_ratio="landscape", **kwargs):
|
|
return {
|
|
"success": True,
|
|
"image": "/tmp/codex-test.png",
|
|
"model": "gpt-5.2-codex",
|
|
"prompt": prompt,
|
|
"aspect_ratio": aspect_ratio,
|
|
"provider": "codex",
|
|
}
|
|
|
|
|
|
class TestPluginDispatch:
|
|
def test_dispatch_routes_to_codex_provider(self, monkeypatch, tmp_path):
|
|
from tools import image_generation_tool
|
|
from agent import image_gen_registry as registry_module
|
|
from hermes_cli import plugins as plugins_module
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
(tmp_path / "config.yaml").write_text("image_gen:\n provider: codex\n")
|
|
image_gen_registry.register_provider(_FakeCodexProvider())
|
|
|
|
monkeypatch.setattr(image_generation_tool, "_read_configured_image_provider", lambda: "codex")
|
|
monkeypatch.setattr(plugins_module, "_ensure_plugins_discovered", lambda: None)
|
|
monkeypatch.setattr(registry_module, "get_provider", lambda name: _FakeCodexProvider() if name == "codex" else None)
|
|
|
|
dispatched = image_generation_tool._dispatch_to_plugin_provider("draw cat", "square")
|
|
payload = json.loads(dispatched)
|
|
|
|
assert payload["success"] is True
|
|
assert payload["provider"] == "codex"
|
|
assert payload["image"] == "/tmp/codex-test.png"
|
|
assert payload["aspect_ratio"] == "square"
|
|
|
|
|
|
def test_deepinfra_key_alone_does_not_select_image_backend(self, monkeypatch):
|
|
"""DeepInfra chat credentials do not imply consent to image billing."""
|
|
from tools import image_generation_tool
|
|
|
|
monkeypatch.setenv("DEEPINFRA_API_KEY", "«redacted:sk-…»")
|
|
monkeypatch.delenv("FAL_KEY", raising=False)
|
|
monkeypatch.setattr(image_generation_tool, "_read_configured_image_provider", lambda: None)
|
|
assert image_generation_tool._dispatch_to_plugin_provider("a cat", "square") is None
|
|
|
|
def test_requirements_ignore_unselected_paid_plugin(self, monkeypatch):
|
|
from tools import image_generation_tool
|
|
|
|
monkeypatch.setattr(image_generation_tool, "check_fal_api_key", lambda: False)
|
|
monkeypatch.setattr(
|
|
image_generation_tool, "_read_configured_image_provider", lambda: None
|
|
)
|
|
assert image_generation_tool.check_image_generation_requirements() is False
|