mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
46 lines
1.6 KiB
Python
46 lines
1.6 KiB
Python
"""FAL_KEY env var normalization (whitespace-only treated as unset)."""
|
|
|
|
|
|
def test_fal_key_whitespace_is_unset(monkeypatch):
|
|
# Whitespace-only FAL_KEY must NOT register as configured, and the managed
|
|
# gateway fallback must be disabled for this assertion to be meaningful.
|
|
monkeypatch.setenv("FAL_KEY", " ")
|
|
|
|
from tools import image_generation_tool
|
|
|
|
monkeypatch.setattr(
|
|
image_generation_tool, "_resolve_managed_fal_gateway", lambda: None
|
|
)
|
|
|
|
assert image_generation_tool.check_fal_api_key() is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Actionable setup message when no FAL backend is reachable.
|
|
# Regression for the silent-drop UX gap described in issue #2543.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_image_generate_tool_returns_actionable_error_when_no_backend(monkeypatch):
|
|
"""End-to-end: handler must surface the actionable message, not a bare string."""
|
|
import json
|
|
|
|
from tools import image_generation_tool
|
|
|
|
monkeypatch.setattr(
|
|
image_generation_tool, "fal_key_is_configured", lambda: False
|
|
)
|
|
monkeypatch.setattr(
|
|
image_generation_tool, "_resolve_managed_fal_gateway", lambda: None
|
|
)
|
|
monkeypatch.setattr(
|
|
image_generation_tool, "managed_nous_tools_enabled", lambda: False
|
|
)
|
|
|
|
result = json.loads(
|
|
image_generation_tool.image_generate_tool(prompt="a cat")
|
|
)
|
|
|
|
assert result["success"] is False
|
|
assert "https://fal.ai" in result["error"]
|
|
assert "FAL_KEY" in result["error"]
|