mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
105 lines
3.1 KiB
Python
105 lines
3.1 KiB
Python
import subprocess
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import web_server
|
|
|
|
pytest.importorskip("starlette.testclient")
|
|
from starlette.testclient import TestClient
|
|
|
|
|
|
@pytest.fixture
|
|
def client():
|
|
previous = getattr(web_server.app.state, "auth_required", None)
|
|
web_server.app.state.auth_required = False
|
|
test_client = TestClient(web_server.app)
|
|
test_client.headers[web_server._SESSION_HEADER_NAME] = web_server._SESSION_TOKEN
|
|
try:
|
|
yield test_client
|
|
finally:
|
|
if previous is None:
|
|
try:
|
|
delattr(web_server.app.state, "auth_required")
|
|
except AttributeError:
|
|
pass
|
|
else:
|
|
web_server.app.state.auth_required = previous
|
|
|
|
|
|
def _git(repo: Path, *args: str) -> None:
|
|
subprocess.run(["git", *args], cwd=repo, check=True, capture_output=True)
|
|
|
|
|
|
@pytest.fixture
|
|
def repo(tmp_path):
|
|
root = tmp_path / "repo"
|
|
root.mkdir()
|
|
_git(root, "init", "-q")
|
|
_git(root, "config", "user.email", "t@example.com")
|
|
_git(root, "config", "user.name", "Test")
|
|
(root / "a.txt").write_text("one\ntwo\n")
|
|
_git(root, "add", "-A")
|
|
_git(root, "commit", "-qm", "init")
|
|
# A tracked modification + a brand-new untracked file (the new-file case the
|
|
# rail/review must surface).
|
|
(root / "a.txt").write_text("one\ntwo\nthree\n")
|
|
(root / "new.py").write_text("print(1)\nprint(2)\n")
|
|
return root
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_stage_commit_roundtrip_clears_changes(client, repo):
|
|
assert client.post("/api/git/review/stage", json={"path": str(repo), "file": "a.txt"}).json() == {"ok": True}
|
|
staged = client.get("/api/git/status", params={"path": str(repo)}).json()
|
|
assert staged["staged"] >= 1
|
|
|
|
assert client.post(
|
|
"/api/git/review/commit", json={"path": str(repo), "message": "tracked change", "push": False}
|
|
).json() == {"ok": True}
|
|
|
|
after = client.get("/api/git/status", params={"path": str(repo)}).json()
|
|
# The tracked change is committed; only the untracked file remains.
|
|
assert after["changed"] == 1
|
|
assert after["untracked"] == 1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_worktree_add_initializes_plain_folder(client, tmp_path):
|
|
folder = tmp_path / "plain-project"
|
|
folder.mkdir()
|
|
(folder / "notes.txt").write_text("not committed\n")
|
|
|
|
added = client.post(
|
|
"/api/git/worktree/add", json={"path": str(folder), "branch": "feature/plain"}
|
|
).json()
|
|
|
|
assert added["branch"] == "feature/plain"
|
|
assert Path(added["path"]).is_dir()
|
|
assert (folder / ".git").exists()
|
|
_git(folder, "rev-parse", "--verify", "HEAD")
|
|
|
|
status = client.get("/api/git/status", params={"path": str(folder)}).json()
|
|
assert status["branch"] == status["defaultBranch"]
|
|
assert status["branch"]
|
|
# Existing files are not silently committed by repo initialization.
|
|
assert any(file["path"] == "notes.txt" and file["untracked"] for file in status["files"])
|
|
|
|
|
|
|
|
|
|
def test_git_endpoints_require_auth(repo):
|
|
unauth = TestClient(web_server.app)
|
|
|
|
assert unauth.get("/api/git/status", params={"path": str(repo)}).status_code == 401
|
|
assert unauth.post("/api/git/review/stage", json={"path": str(repo)}).status_code == 401
|