mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-01 12:02:05 +00:00
e684b808ad
`hermes serve` is newer than the desktop binary's release cadence, so a new app launched against an un-upgraded managed install / PATH `hermes` would crash on an unknown subcommand and brick the user mid-upgrade. Detect whether the resolved runtime registers `serve` (fast source read of its dashboard.py, with a one-time CLI probe fallback) and rewrite the backend argv to the legacy `dashboard --no-open` only when it does not. Happy path (current runtimes) pays nothing and still spawns `serve`. - electron/backend-command.cjs: pure serve/dashboard argv helpers + serve- source detection (unit-tested in backend-command.test.cjs) - main.cjs: backendSupportsServe() cache + getBackendArgsForRuntime() guard at both backend spawn sites; expose `root` from the Windows venv unwrap so the fast source check covers Windows too - docs: note the backward-compat fallback in README, desktop.md, AGENTS.md
83 lines
2.3 KiB
JavaScript
83 lines
2.3 KiB
JavaScript
'use strict'
|
|
|
|
const test = require('node:test')
|
|
const assert = require('node:assert/strict')
|
|
|
|
const {
|
|
serveBackendArgs,
|
|
dashboardFallbackArgs,
|
|
sourceDeclaresServe,
|
|
} = require('./backend-command.cjs')
|
|
|
|
test('serveBackendArgs builds a headless serve invocation', () => {
|
|
assert.deepEqual(serveBackendArgs(), [
|
|
'serve',
|
|
'--host',
|
|
'127.0.0.1',
|
|
'--port',
|
|
'0',
|
|
])
|
|
})
|
|
|
|
test('serveBackendArgs pins a profile when provided', () => {
|
|
assert.deepEqual(serveBackendArgs('worker'), [
|
|
'--profile',
|
|
'worker',
|
|
'serve',
|
|
'--host',
|
|
'127.0.0.1',
|
|
'--port',
|
|
'0',
|
|
])
|
|
})
|
|
|
|
test('dashboardFallbackArgs rewrites serve -> dashboard --no-open, keeping the -m prefix', () => {
|
|
const serve = ['-m', 'hermes_cli.main', 'serve', '--host', '127.0.0.1', '--port', '0']
|
|
assert.deepEqual(dashboardFallbackArgs(serve), [
|
|
'-m',
|
|
'hermes_cli.main',
|
|
'dashboard',
|
|
'--no-open',
|
|
'--host',
|
|
'127.0.0.1',
|
|
'--port',
|
|
'0',
|
|
])
|
|
})
|
|
|
|
test('dashboardFallbackArgs preserves a --profile flag ahead of serve', () => {
|
|
const serve = ['-m', 'hermes_cli.main', '--profile', 'worker', 'serve', '--host', '127.0.0.1', '--port', '0']
|
|
assert.deepEqual(dashboardFallbackArgs(serve), [
|
|
'-m',
|
|
'hermes_cli.main',
|
|
'--profile',
|
|
'worker',
|
|
'dashboard',
|
|
'--no-open',
|
|
'--host',
|
|
'127.0.0.1',
|
|
'--port',
|
|
'0',
|
|
])
|
|
})
|
|
|
|
test('dashboardFallbackArgs is a no-op (copy) when there is no serve token', () => {
|
|
const args = ['-m', 'hermes_cli.main', 'dashboard', '--no-open']
|
|
const out = dashboardFallbackArgs(args)
|
|
assert.deepEqual(out, args)
|
|
assert.notEqual(out, args, 'should return a copy, not the same reference')
|
|
})
|
|
|
|
test('sourceDeclaresServe detects the serve subparser registration', () => {
|
|
assert.equal(sourceDeclaresServe('subparsers.add_parser("serve", help="...")'), true)
|
|
assert.equal(sourceDeclaresServe("subparsers.add_parser('serve')"), true)
|
|
assert.equal(sourceDeclaresServe('subparsers.add_parser(\n "serve",\n)'), true)
|
|
})
|
|
|
|
test('sourceDeclaresServe does not false-positive on the substring "server"', () => {
|
|
const oldSource = `
|
|
dashboard_parser = subparsers.add_parser("dashboard", help="Start the web UI dashboard")
|
|
from hermes_cli.web_server import start_server # web server
|
|
`
|
|
assert.equal(sourceDeclaresServe(oldSource), false)
|
|
})
|