Teknium 2ecca1e7d3 fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint (#53829) ... Follow-up to #53791 addressing review feedback: the footgun checker treated capture_output=/stdout=/stderr=/check_output as proof a subprocess can't pop a Windows console. That invariant is false — stream redirection controls where a child's output goes, not whether a console is allocated. From a console-less parent (Desktop/Electron, pythonw.exe, detached gateway/cron) a console-subsystem child still flashes a window even when fully captured. - check-windows-footguns.py: capture/redirect/check_output is no longer a blanket safe-pass. Added _WINDOWS_FLASHING_PROGRAMS (git/gh/npm/node/python/uv/ffmpeg/ docker/powershell/…); calls to those are flagged even when captured. Non-flashing programs keep the capture exemption (no 271-site noise). _subprocess_compat.run/ popen calls are inherently safe (wrapper injects CREATE_NO_WINDOW). - Routed the 35 genuine flashing git/gh/npm/uv/ffmpeg/docker spawns through the _subprocess_compat.run/popen chokepoint (Brooklyn's wrapper from #53810) — the durable fix, not per-site annotations. cmd.exe /c start stays # ok (intentional). - Updated tests + CONTRIBUTING.md rule #17 to the corrected invariant.		2026-06-27 14:49:41 -07:00
..
test_build_skills_index_health.py	fix(skills-hub): stop shipping a degenerate index when GitHub taps collapse (#42347)	2026-06-08 15:21:28 -07:00
test_release_acp_registry.py	feat(acp-registry): switch to uvx distribution, drop npm launcher	2026-05-14 22:27:09 -07:00
test_windows_footgun_subprocess_rule.py	fix(windows): capture is not a no-window boundary; route flashing spawns through chokepoint (#53829)	2026-06-27 14:49:41 -07:00