mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-21 10:22:18 +00:00
f35abb122a
Serve webhook inbound for multiple profiles off the one shared listener via a
URL prefix, with no second port bound.
- SessionSource gains a 'profile' field (round-trips through to_dict/from_dict;
omitted when unset so existing serialization is unchanged). It carries which
profile an inbound message was routed to.
- WebhookAdapter registers /p/{profile}/webhooks/{route_name} alongside the
existing /webhooks/{route_name}. _resolve_request_profile validates the
prefix against profiles_to_serve(): None when absent or multiplexing is off
(ignored, handled as default — no spurious 404), the profile name when valid,
_PROFILE_REJECTED (→ 404) when the profile isn't served. The resolved profile
is stamped onto the SessionSource.
- session-key namespacing and the per-turn home/credential scope now prefer
source.profile: SessionStore._resolve_profile_for_key(source),
_session_key_for_source fallback, and _resolve_profile_home_for_source all
honor it (→ the agent turn resolves that profile's config/skills/credentials
via the Phase 2 _profile_runtime_scope).
Constraint: routing inbound needs no per-profile platform credential, but the
agent still needs the routed profile's provider key — delivered by Phase 2's
secret scope. api_server (OpenAI-compatible surface) profile routing is a
focused follow-on; its source-construction path differs from webhook's.
Tests: SessionSource.profile round-trip + namespace drive; _resolve_request_
profile accept/reject/ignore matrix.
73 lines
3 KiB
Python
73 lines
3 KiB
Python
"""Phase 1: HTTP-inbound /p/<profile>/ routing for the webhook adapter."""
|
|
import pytest
|
|
|
|
from gateway.config import GatewayConfig, Platform
|
|
from gateway.session import SessionSource, build_session_key
|
|
|
|
|
|
class TestSessionSourceProfileField:
|
|
def test_profile_roundtrips(self):
|
|
s = SessionSource(
|
|
platform=Platform.WEBHOOK if hasattr(Platform, "WEBHOOK") else Platform.TELEGRAM,
|
|
chat_id="c1",
|
|
chat_type="webhook",
|
|
profile="coder",
|
|
)
|
|
restored = SessionSource.from_dict(s.to_dict())
|
|
assert restored.profile == "coder"
|
|
|
|
def test_profile_absent_not_serialized(self):
|
|
s = SessionSource(platform=Platform.TELEGRAM, chat_id="c1", chat_type="dm")
|
|
assert "profile" not in s.to_dict()
|
|
|
|
def test_source_profile_drives_session_key_namespace(self):
|
|
s = SessionSource(platform=Platform.TELEGRAM, chat_id="99", chat_type="dm")
|
|
# build_session_key takes profile explicitly; the adapter passes
|
|
# source.profile through. Verify the namespace follows it.
|
|
assert build_session_key(s, profile="coder") == "agent:coder:telegram:dm:99"
|
|
|
|
|
|
class TestWebhookProfileResolution:
|
|
"""_resolve_request_profile validates the /p/<profile>/ prefix."""
|
|
|
|
def _adapter(self, multiplex: bool, served=("default", "coder")):
|
|
from gateway.platforms.webhook import WebhookAdapter, _PROFILE_REJECTED
|
|
|
|
class _FakeReq:
|
|
def __init__(self, profile):
|
|
self.match_info = {"profile": profile} if profile is not None else {}
|
|
|
|
cfg = GatewayConfig(multiplex_profiles=multiplex)
|
|
|
|
class _Runner:
|
|
config = cfg
|
|
|
|
# Construct minimally; we only call _resolve_request_profile.
|
|
adapter = WebhookAdapter.__new__(WebhookAdapter)
|
|
adapter.gateway_runner = _Runner()
|
|
return adapter, _FakeReq, _PROFILE_REJECTED, served
|
|
|
|
def test_no_prefix_returns_none(self):
|
|
adapter, Req, _REJ, _ = self._adapter(multiplex=True)
|
|
assert adapter._resolve_request_profile(Req(None)) is None
|
|
|
|
def test_prefix_ignored_when_multiplex_off(self):
|
|
adapter, Req, _REJ, _ = self._adapter(multiplex=False)
|
|
# Even a bogus profile is ignored (not 404'd) when multiplexing is off.
|
|
assert adapter._resolve_request_profile(Req("anything")) is None
|
|
|
|
def test_known_profile_accepted(self, monkeypatch):
|
|
adapter, Req, _REJ, served = self._adapter(multiplex=True)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.profiles.profiles_to_serve",
|
|
lambda multiplex: [(n, None) for n in served],
|
|
)
|
|
assert adapter._resolve_request_profile(Req("coder")) == "coder"
|
|
|
|
def test_unknown_profile_rejected(self, monkeypatch):
|
|
adapter, Req, REJ, served = self._adapter(multiplex=True)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.profiles.profiles_to_serve",
|
|
lambda multiplex: [(n, None) for n in served],
|
|
)
|
|
assert adapter._resolve_request_profile(Req("ghost")) is REJ
|