mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
102 lines
4.4 KiB
Python
102 lines
4.4 KiB
Python
"""Tests for slash command prefix matching in HermesCLI.process_command."""
|
|
from unittest.mock import MagicMock, patch
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli():
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj.config = {}
|
|
cli_obj.console = MagicMock()
|
|
cli_obj.agent = None
|
|
cli_obj.conversation_history = []
|
|
cli_obj.session_id = None
|
|
cli_obj._pending_input = MagicMock()
|
|
return cli_obj
|
|
|
|
|
|
class TestSlashCommandPrefixMatching:
|
|
def test_unique_prefix_dispatches_command(self):
|
|
"""/con should dispatch to /config when it uniquely matches."""
|
|
cli_obj = _make_cli()
|
|
with patch.object(cli_obj, 'show_config') as mock_config:
|
|
cli_obj.process_command("/con")
|
|
mock_config.assert_called_once()
|
|
|
|
|
|
|
|
def test_ambiguous_prefix_shows_suggestions(self):
|
|
"""/re matches multiple commands — should show ambiguous message."""
|
|
cli_obj = _make_cli()
|
|
with patch("cli._cprint") as mock_cprint:
|
|
cli_obj.process_command("/re")
|
|
printed = " ".join(str(c) for c in mock_cprint.call_args_list)
|
|
assert "Ambiguous" in printed or "Did you mean" in printed
|
|
|
|
|
|
|
|
def test_skill_command_prefix_matches(self):
|
|
"""A prefix that uniquely matches a skill command should dispatch it."""
|
|
cli_obj = _make_cli()
|
|
fake_skill = {"/test-skill-xyz": {"name": "Test Skill", "description": "test"}}
|
|
printed = []
|
|
cli_obj.console.print = lambda *a, **kw: printed.append(str(a))
|
|
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill):
|
|
cli_obj.process_command("/test-skill-xy")
|
|
|
|
# Should NOT show "Unknown command" — should have dispatched or attempted skill
|
|
unknown = any("Unknown command" in p for p in printed)
|
|
assert not unknown, f"Expected skill prefix to match, got: {printed}"
|
|
|
|
def test_ambiguous_between_builtin_and_skill(self):
|
|
"""Ambiguous prefix spanning builtin + skill commands shows suggestions."""
|
|
cli_obj = _make_cli()
|
|
# /help-extra is a fake skill that shares /hel prefix with /help
|
|
fake_skill = {"/help-extra": {"name": "Help Extra", "description": "test"}}
|
|
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill), patch.object(cli_obj, 'show_help') as mock_help:
|
|
cli_obj.process_command("/help")
|
|
|
|
# /help is an exact match so should work normally, not show ambiguous
|
|
mock_help.assert_called_once()
|
|
printed = " ".join(str(c) for c in cli_obj.console.print.call_args_list)
|
|
assert "Ambiguous" not in printed
|
|
|
|
def test_shortest_match_preferred_over_longer_skill(self):
|
|
"""/qui should dispatch to /quit (5 chars) not report ambiguous with /quint-pipeline (15 chars)."""
|
|
cli_obj = _make_cli()
|
|
fake_skill = {"/quint-pipeline": {"name": "Quint Pipeline", "description": "test"}}
|
|
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill):
|
|
# /quit is caught by the exact "/quit" branch → process_command returns False
|
|
result = cli_obj.process_command("/qui")
|
|
|
|
# Returns False because /quit was dispatched (exits chat loop)
|
|
assert result is False
|
|
printed = " ".join(str(c) for c in cli_obj.console.print.call_args_list)
|
|
assert "Ambiguous" not in printed
|
|
|
|
def test_tied_shortest_matches_still_ambiguous(self):
|
|
"""/re matches /reset and /retry (both 6 chars) — no unique shortest, stays ambiguous."""
|
|
cli_obj = _make_cli()
|
|
printed = []
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_cprint', side_effect=lambda t: printed.append(t)):
|
|
cli_obj.process_command("/re")
|
|
combined = " ".join(printed)
|
|
assert "Ambiguous" in combined or "Did you mean" in combined
|
|
|
|
def test_exact_typed_name_dispatches_over_longer_match(self):
|
|
"""/help typed with /help-extra skill installed → exact match wins."""
|
|
cli_obj = _make_cli()
|
|
fake_skill = {"/help-extra": {"name": "Help Extra", "description": ""}}
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill), \
|
|
patch.object(cli_obj, 'show_help') as mock_help:
|
|
cli_obj.process_command("/help")
|
|
mock_help.assert_called_once()
|
|
printed = " ".join(str(c) for c in cli_obj.console.print.call_args_list)
|
|
assert "Ambiguous" not in printed
|