mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-03 02:11:48 +00:00
51b44b6e3f
Self-review caught several errors in the previous commit: Frontmatter - Replace non-standard `requires_runtime` / `requires_tooling` fields with the documented `compatibility:` field (parsed by tools/skills_tool.py). - Drop the `audit-v5` author tag I added unnecessarily. MODEL_LOADERS catalog - Remove `IPAdapterUnifiedLoader` (input `preset` is an enum, not a file). - Remove `IPAdapterInsightFaceLoader` and `InsightFaceLoader` (input `provider` is a GPU backend selector, not a model file). These would have flagged enum values like "STANDARD" or "CUDA" as missing model files. - Add "NB:" comment explaining `BasicGuider` has no `cfg` input (the original PARAM_PATTERNS entry would never have matched). - Remove `SamplerCustomAdvanced.noise_seed` from PARAM_PATTERNS — that node takes a NOISE input from RandomNoise, not a seed field directly. NODE_TO_PACKAGE registry slugs - Verified all 18 packages against api.comfy.org and fixed: - `comfyui-essentials` → `comfyui_essentials` (underscore, not hyphen) - `comfyui-gguf` → `ComfyUI-GGUF` (case-sensitive) - `comfyui-photomaker-plus` → `ComfyUI-PhotoMaker-Plus` - `comfyui-wanvideowrapper` → `ComfyUI-WanVideoWrapper` - ComfyUI-HunyuanVideoWrapper isn't on the registry; surface a git-URL install hint via new NODE_TO_GIT_URL fallback so the user can install via ComfyUI-Manager's /manager/queue/install endpoint. Wrong class names - `Canny` → `CannyEdgePreprocessor` (controlnet-aux registers the latter, the former never appears in /object_info). - Add `Zoe_DepthAnythingPreprocessor` and `AnimalPosePreprocessor` while fixing controlnet-aux. - Remove `Reroute (rgthree)` (rgthree's Reroute is JS-only — no Python class, never appears in /object_info). - Add `Display Int (rgthree)` (sibling of Display Any). - Move `UltralyticsDetectorProvider` from `comfyui-impact-pack` to `comfyui-impact-subpack` (separate package, registered there). Tests - Update test_packages_are_safe_for_shell to accept case-mixed slugs (the registry uses both ComfyUI- and comfyui_ prefixes inconsistently). Replaced the lowercase-only assertion with a shell-safe regex check. - 117 tests still pass (105 unit + 8 cloud + 4 cross-host). Attribution - Add `SHL0MS@users.noreply.github.com` mapping to scripts/release.py AUTHOR_MAP so check-attribution CI passes.
68 lines
2.3 KiB
Python
68 lines
2.3 KiB
Python
"""Tests for check_deps.py — focuses on parsing logic that doesn't need a server."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from check_deps import (
|
|
NODE_TO_PACKAGE,
|
|
model_present,
|
|
normalize_for_match,
|
|
suggest_install_command,
|
|
)
|
|
|
|
|
|
class TestNormalizeForMatch:
|
|
def test_basic(self):
|
|
s = normalize_for_match("model.safetensors")
|
|
assert "model.safetensors" in s
|
|
assert "model" in s
|
|
|
|
def test_subfolder(self):
|
|
s = normalize_for_match("subdir/model.pt")
|
|
assert "subdir/model.pt" in s
|
|
assert "model.pt" in s
|
|
assert "model" in s
|
|
|
|
|
|
class TestModelPresent:
|
|
def test_exact_match(self):
|
|
assert model_present("a.safetensors", {"a.safetensors", "b.safetensors"}) is True
|
|
|
|
def test_extension_difference(self):
|
|
# User said "model" but installed is "model.safetensors"
|
|
assert model_present("model", {"model.safetensors"}) is True
|
|
# Reverse direction — also matches
|
|
assert model_present("model.safetensors", {"model"}) is True
|
|
|
|
def test_subfolder_match(self):
|
|
# Installed list has "subdir/model.safetensors", workflow asks "model.safetensors"
|
|
assert model_present("model.safetensors", {"subdir/model.safetensors"}) is True
|
|
|
|
def test_missing(self):
|
|
assert model_present("missing.safetensors", {"a.safetensors", "b.safetensors"}) is False
|
|
|
|
def test_empty_installed(self):
|
|
assert model_present("anything.safetensors", set()) is False
|
|
|
|
|
|
class TestSuggestInstallCommand:
|
|
def test_known_node(self):
|
|
cmd = suggest_install_command("VHS_VideoCombine")
|
|
assert cmd == "comfy node install comfyui-videohelpersuite"
|
|
|
|
def test_unknown_node(self):
|
|
assert suggest_install_command("SomeRandomNodeName123") is None
|
|
|
|
|
|
class TestNodePackageMap:
|
|
def test_no_duplicates(self):
|
|
# Each node should map to exactly one package
|
|
keys = list(NODE_TO_PACKAGE.keys())
|
|
assert len(keys) == len(set(keys))
|
|
|
|
def test_packages_are_safe_for_shell(self):
|
|
# Registry slugs must be alphanumerics + hyphens/underscores only
|
|
# (passed straight to `comfy node install <pkg>`).
|
|
import re
|
|
safe = re.compile(r"^[A-Za-z0-9][A-Za-z0-9._\-]*$")
|
|
for pkg in NODE_TO_PACKAGE.values():
|
|
assert safe.match(pkg), f"Unsafe package slug: {pkg!r}"
|