mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-23 16:36:23 +00:00
2bb531b67a
* fix(desktop): extend read aloud timeout Hermes Desktop Read Aloud can show a false failure after 15s even when backend TTS synthesis succeeds. The Desktop renderer bridge request to /api/audio/speak blocks until provider synthesis, audio file read, and base64 response encoding finish, so larger messages or slower remote TTS providers can legitimately exceed the default 15s Electron backend timeout (DEFAULT_FETCH_TIMEOUT_MS in hardening.ts). Give only the blocking Read Aloud request a bounded TTS-specific timeout (180s floor, 600s cap, text-length scaling). Normal Desktop API requests keep the short default so real backend hangs still fail promptly. Salvage of #39286 rebased onto current main (original branch conflicted in apps/desktop/src/hermes.ts and hermes.test.ts against the newly-added STARTUP_REQUEST_TIMEOUT_MS / PROMPT_SUBMIT_REQUEST_TIMEOUT_MS constants and model-options tests). Both additions coexist; no behavior changed. Co-authored-by: Ruslan Vasylev <ruslan.vasylev.vfx@gmail.com> * fix(desktop): extend read aloud + transcription timeouts Hermes Desktop Read Aloud can show a false failure after 15s even when backend TTS synthesis succeeds. The Desktop renderer bridge request to /api/audio/speak blocks until provider synthesis, audio file read, and base64 response encoding finish, so larger messages or slower remote TTS providers can legitimately exceed the default 15s Electron backend timeout (DEFAULT_FETCH_TIMEOUT_MS in hardening.ts). /api/audio/transcribe is the sibling blocking endpoint with the same bug class: it blocks on provider STT + file handling + encoding behind the same 15s default, so long clips / remote providers hit the same spurious timeout. Give both requests a bounded, endpoint-specific timeout (180s floor, 600s cap) — speak scales on text length, transcribe on the base64 payload length. Every other Desktop API request keeps the short default so real backend hangs still fail promptly. Salvage of #39286 rebased onto current main. The original PR was scoped to /api/audio/speak only; this extends it to also close the transcribe twin per OutThisLife's review suggestion on #39286, closing the whole 'audio endpoints time out at 15s' class in one shot. Co-authored-by: Ruslan Vasylev <ruslan.vasylev.vfx@gmail.com> --------- Co-authored-by: Ruslan Vasylev <ruslan.vasylev.vfx@gmail.com> |
||
|---|---|---|
| .. | ||
| bootstrap-installer | ||
| desktop | ||
| shared | ||