mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
8d023e43ed
Deep scan with vulture, pyflakes, and manual cross-referencing identified: - 41 dead functions/methods (zero callers in production) - 7 production-dead functions (only test callers, tests deleted) - 5 dead constants/variables - ~35 unused imports across agent/, hermes_cli/, tools/, gateway/ Categories of dead code removed: - Refactoring leftovers: _set_default_model, _setup_copilot_reasoning_selection, rebuild_lookups, clear_session_context, get_logs_dir, clear_session - Unused API surface: search_models_dev, get_pricing, skills_categories, get_read_files_summary, clear_read_tracker, menu_labels, get_spinner_list - Dead compatibility wrappers: schedule_cronjob, list_cronjobs, remove_cronjob - Stale debug helpers: get_debug_session_info copies in 4 tool files (centralized version in debug_helpers.py already exists) - Dead gateway methods: send_emote, send_notice (matrix), send_reaction (bluebubbles), _normalize_inbound_text (feishu), fetch_room_history (matrix), _start_typing_indicator (signal), parse_feishu_post_content - Dead constants: NOUS_API_BASE_URL, SKILLS_TOOL_DESCRIPTION, FILE_TOOLS, VALID_ASPECT_RATIOS, MEMORY_DIR - Unused UI code: _interactive_provider_selection, _interactive_model_selection (superseded by prompt_toolkit picker) Test suite verified: 609 tests covering affected files all pass. Tests for removed functions deleted. Tests using removed utilities (clear_read_tracker, MEMORY_DIR) updated to use internal APIs directly.
72 lines
2.4 KiB
Python
72 lines
2.4 KiB
Python
"""Tests for hermes_cli/tips.py — random tip display at session start."""
|
|
|
|
import pytest
|
|
from hermes_cli.tips import TIPS, get_random_tip
|
|
|
|
|
|
class TestTipsCorpus:
|
|
"""Validate the tip corpus itself."""
|
|
|
|
def test_has_at_least_200_tips(self):
|
|
assert len(TIPS) >= 200, f"Expected 200+ tips, got {len(TIPS)}"
|
|
|
|
def test_no_duplicates(self):
|
|
assert len(TIPS) == len(set(TIPS)), "Duplicate tips found"
|
|
|
|
def test_all_tips_are_strings(self):
|
|
for i, tip in enumerate(TIPS):
|
|
assert isinstance(tip, str), f"Tip {i} is not a string: {type(tip)}"
|
|
|
|
def test_no_empty_tips(self):
|
|
for i, tip in enumerate(TIPS):
|
|
assert tip.strip(), f"Tip {i} is empty or whitespace-only"
|
|
|
|
def test_max_length_reasonable(self):
|
|
"""Tips should fit on a single terminal line (~120 chars max)."""
|
|
for i, tip in enumerate(TIPS):
|
|
assert len(tip) <= 150, (
|
|
f"Tip {i} too long ({len(tip)} chars): {tip[:60]}..."
|
|
)
|
|
|
|
def test_no_leading_trailing_whitespace(self):
|
|
for i, tip in enumerate(TIPS):
|
|
assert tip == tip.strip(), f"Tip {i} has leading/trailing whitespace"
|
|
|
|
|
|
class TestGetRandomTip:
|
|
"""Validate the get_random_tip() function."""
|
|
|
|
def test_returns_string(self):
|
|
tip = get_random_tip()
|
|
assert isinstance(tip, str)
|
|
assert len(tip) > 0
|
|
|
|
def test_returns_tip_from_corpus(self):
|
|
tip = get_random_tip()
|
|
assert tip in TIPS
|
|
|
|
def test_randomness(self):
|
|
"""Multiple calls should eventually return different tips."""
|
|
seen = set()
|
|
for _ in range(50):
|
|
seen.add(get_random_tip())
|
|
# With 200+ tips and 50 draws, we should see at least 10 unique
|
|
assert len(seen) >= 10, f"Only got {len(seen)} unique tips in 50 draws"
|
|
|
|
|
|
class TestTipIntegrationInCLI:
|
|
"""Test that the tip display code in cli.py works correctly."""
|
|
|
|
def test_tip_import_works(self):
|
|
"""The import used in cli.py must succeed."""
|
|
from hermes_cli.tips import get_random_tip
|
|
assert callable(get_random_tip)
|
|
|
|
def test_tip_display_format(self):
|
|
"""Verify the Rich markup format doesn't break."""
|
|
tip = get_random_tip()
|
|
color = "#B8860B"
|
|
markup = f"[dim {color}]✦ Tip: {tip}[/]"
|
|
# Should not contain nested/broken Rich tags
|
|
assert markup.count("[/]") == 1
|
|
assert "[dim #B8860B]" in markup
|