mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-09 13:21:42 +00:00
ba31699091
The google-antigravity and google-gemini-cli OAuth providers were removed in #50492. They were the only producers of a cloudcode-pa:// base_url, so the account-level-quota early-returns in _pool_may_recover_from_rate_limit and _credential_pool_may_recover_rate_limit are now unreachable. - Drop the dead cloudcode-pa:// checks and the now-unused provider/base_url params on _pool_may_recover_from_rate_limit (only caller updated). - Prune the obsolete CloudCode-specific regression tests; keep the live single/multi-entry pool-rotation invariants (#11314).
53 lines
1.9 KiB
Python
53 lines
1.9 KiB
Python
"""Regression tests for #11314 — credential-pool rotation vs. fallback.
|
|
|
|
_pool_may_recover_from_rate_limit() is the hinge between credential-pool
|
|
rotation and fallback-provider activation. Rotation is only worth waiting on
|
|
when the pool exists, has an available entry, and has more than one entry to
|
|
rotate to; otherwise we should fall back to the configured fallback provider
|
|
immediately.
|
|
"""
|
|
import inspect
|
|
from unittest.mock import MagicMock
|
|
|
|
from agent import conversation_loop
|
|
from run_agent import _pool_may_recover_from_rate_limit
|
|
|
|
|
|
def _pool(entries: int = 2):
|
|
p = MagicMock()
|
|
p.has_available.return_value = True
|
|
p.entries.return_value = list(range(entries))
|
|
return p
|
|
|
|
|
|
def test_multi_entry_pool_recovers():
|
|
assert _pool_may_recover_from_rate_limit(_pool(entries=3)) is True
|
|
|
|
|
|
def test_single_entry_pool_skips_rotation():
|
|
# Single-entry-pool exception (#11314): nothing to rotate to.
|
|
assert _pool_may_recover_from_rate_limit(_pool(entries=1)) is False
|
|
|
|
|
|
def test_exhausted_pool_skips_rotation():
|
|
p = MagicMock()
|
|
p.has_available.return_value = False
|
|
assert _pool_may_recover_from_rate_limit(p) is False
|
|
|
|
|
|
def test_no_pool_skips_rotation():
|
|
assert _pool_may_recover_from_rate_limit(None) is False
|
|
|
|
|
|
def test_conversation_loop_resolves_pool_helper_through_run_agent_module():
|
|
"""Extracted conversation loop must honor tests/patches on run_agent.
|
|
|
|
conversation_loop intentionally lazy-loads run_agent via _ra(). If this
|
|
call site uses a bare imported helper, monkeypatching run_agent in tests (and
|
|
production wrappers that patch run_agent) will not propagate into the
|
|
extracted loop; older code also hit NameError in this branch.
|
|
"""
|
|
source = inspect.getsource(conversation_loop.run_conversation)
|
|
|
|
assert "_ra()._pool_may_recover_from_rate_limit(" in source
|
|
assert "pool_may_recover = _pool_may_recover_from_rate_limit(" not in source
|