mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-25 17:18:11 +00:00
91799405aa
Salvaged from PR #36220, ported onto the current SessionStore (SQLite- backed get_or_create_session; activity check is last_prompt_tokens) and the sidecar-note reset path (context notes now ride turn_sidecar_notes instead of prepending to context_prompt). Long-lived Slack/Discord channels/threads lose their context on daily/idle session resets, and the agent can bind a new request to an unrelated recent session (observed: a Discord thread reset caused a PR in the wrong repository). Record prev_session_id when an auto-reset replaces a session with real activity, persist it, and append a deterministic one-line hint to the auto-reset context note pointing the agent at session_search for that specific prior session. No LLM calls, no channel-history APIs, no extra DB lookups; other platforms and activity-free resets are untouched. Refs #36220. Co-authored-by: metamon <269728612+metamon-p@users.noreply.github.com>
145 lines
5 KiB
Python
145 lines
5 KiB
Python
"""Tests for the lightweight Slack/Discord channel session-continuity hint.
|
|
|
|
Salvaged from PR #36220 (metamon-p), ported onto the current SessionStore.
|
|
|
|
Covers:
|
|
- SessionStore records the previous session_id on auto-reset (and only then).
|
|
- prev_session_id survives a to_dict() → from_dict() roundtrip (gateway restart).
|
|
- build_channel_continuity_note() emits a hint only for Slack/Discord sessions
|
|
that were auto-reset with real prior activity, and stays silent otherwise.
|
|
"""
|
|
|
|
from datetime import datetime, timedelta
|
|
|
|
import pytest
|
|
|
|
from gateway.config import GatewayConfig, Platform, SessionResetPolicy
|
|
from gateway.session import (
|
|
SessionEntry,
|
|
SessionSource,
|
|
SessionStore,
|
|
build_channel_continuity_note,
|
|
)
|
|
|
|
|
|
@pytest.fixture()
|
|
def _isolated_db(tmp_path, monkeypatch):
|
|
import hermes_state
|
|
|
|
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
return tmp_path
|
|
|
|
|
|
def _make_store(tmp_path, policy=None):
|
|
config = GatewayConfig()
|
|
if policy:
|
|
config.default_reset_policy = policy
|
|
return SessionStore(sessions_dir=tmp_path / "sessions", config=config)
|
|
|
|
|
|
def _slack_source(thread_id=None):
|
|
return SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="C123",
|
|
chat_type="thread" if thread_id else "channel",
|
|
user_id="U1",
|
|
thread_id=thread_id,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# SessionStore records prev_session_id on auto-reset
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestPrevSessionIdCapture:
|
|
def test_prev_session_id_set_on_auto_reset(self, _isolated_db, tmp_path):
|
|
store = _make_store(tmp_path, SessionResetPolicy(mode="idle", idle_minutes=1))
|
|
source = _slack_source(thread_id="T9")
|
|
|
|
entry1 = store.get_or_create_session(source)
|
|
assert entry1.prev_session_id is None # fresh session, nothing replaced
|
|
|
|
entry1.last_prompt_tokens = 4000 # had real conversation
|
|
entry1.updated_at = datetime.now() - timedelta(minutes=5)
|
|
store._save()
|
|
|
|
entry2 = store.get_or_create_session(source)
|
|
assert entry2.was_auto_reset is True
|
|
assert entry2.reset_had_activity is True
|
|
assert entry2.prev_session_id == entry1.session_id
|
|
|
|
def test_prev_session_id_none_without_reset(self, _isolated_db, tmp_path):
|
|
store = _make_store(tmp_path)
|
|
source = _slack_source()
|
|
|
|
entry = store.get_or_create_session(source)
|
|
assert entry.prev_session_id is None
|
|
|
|
def test_prev_session_id_roundtrips_serialization(self):
|
|
entry = SessionEntry(
|
|
session_key="k",
|
|
session_id="20260101_010000_def",
|
|
created_at=datetime.now(),
|
|
updated_at=datetime.now(),
|
|
platform=Platform.SLACK,
|
|
was_auto_reset=True,
|
|
auto_reset_reason="daily",
|
|
reset_had_activity=True,
|
|
prev_session_id="20260101_000000_abc",
|
|
)
|
|
reloaded = SessionEntry.from_dict(entry.to_dict())
|
|
assert reloaded.prev_session_id == "20260101_000000_abc"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# build_channel_continuity_note
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _reset_entry(platform, prev="20260101_000000_abc", had_activity=True):
|
|
return SessionEntry(
|
|
session_key="k",
|
|
session_id="20260101_010000_def",
|
|
created_at=datetime.now(),
|
|
updated_at=datetime.now(),
|
|
platform=platform,
|
|
was_auto_reset=True,
|
|
auto_reset_reason="daily",
|
|
reset_had_activity=had_activity,
|
|
prev_session_id=prev,
|
|
)
|
|
|
|
|
|
class TestBuildChannelContinuityNote:
|
|
def test_slack_channel_emits_hint(self):
|
|
entry = _reset_entry(Platform.SLACK)
|
|
note = build_channel_continuity_note(entry, _slack_source())
|
|
assert note is not None
|
|
assert "session_search" in note
|
|
assert entry.prev_session_id in note
|
|
assert "channel" in note
|
|
|
|
def test_discord_thread_uses_thread_wording(self):
|
|
entry = _reset_entry(Platform.DISCORD)
|
|
source = SessionSource(
|
|
platform=Platform.DISCORD,
|
|
chat_id="c",
|
|
chat_type="thread",
|
|
thread_id="T1",
|
|
)
|
|
note = build_channel_continuity_note(entry, source)
|
|
assert note is not None
|
|
assert "thread" in note
|
|
|
|
def test_other_platform_returns_none(self):
|
|
entry = _reset_entry(Platform.TELEGRAM)
|
|
source = SessionSource(platform=Platform.TELEGRAM, chat_id="c", user_id="u")
|
|
assert build_channel_continuity_note(entry, source) is None
|
|
|
|
def test_no_activity_returns_none(self):
|
|
entry = _reset_entry(Platform.SLACK, had_activity=False)
|
|
assert build_channel_continuity_note(entry, _slack_source()) is None
|
|
|
|
def test_no_prev_session_id_returns_none(self):
|
|
entry = _reset_entry(Platform.SLACK, prev=None)
|
|
assert build_channel_continuity_note(entry, _slack_source()) is None
|