mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
3e7a11ca2e
Two Windows fixes for the canonical test runner, salvaged from #66496: - scripts/run_tests.sh: probe the native Windows venv layout (Scripts/activate → Scripts/python.exe) alongside bin/activate, adapted to main's pytest-import-guarded loop with SKIPPED_VENVS reporting. Without it a python -m venv / uv venv on Git Bash/MSYS is never found and the runner refuses to start. - scripts/run_tests_parallel.py: _make_stdio_glyph_safe() reconfigures stdout/stderr to UTF-8 (errors=replace fallback) so the ✓/✗ progress glyphs cannot crash a cp1252 console when the runner is invoked directly (run_tests.sh's PYTHONUTF8=1 only covers the wrapped path). No-op on UTF-8 stdio. Ships 3 OS-independent cp1252 tests plus encoding=utf-8 in the runner-subprocess assertions. Dropped from the original PR: the USERPROFILE/HOMEDRIVE/HOMEPATH/ SYSTEMROOT env-forwarding hunk — main's WIN_ENV loop already forwards a superset (#67385/#70813).
69 lines
2.3 KiB
Python
69 lines
2.3 KiB
Python
"""The runner's status glyphs must not crash narrow console encodings.
|
|
|
|
On native Windows, piped or legacy-console stdio defaults to cp1252, which
|
|
cannot encode the runner's ✓/✗ progress glyphs — before the fix, the first
|
|
per-file status line killed the whole run with UnicodeEncodeError. The
|
|
failure depends only on the stream's encoding, so these tests pin it on
|
|
every OS by building a cp1252 stream explicitly.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import io
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
_RUNNER_PATH = REPO_ROOT / "scripts" / "run_tests_parallel.py"
|
|
|
|
|
|
def _load_runner():
|
|
spec = importlib.util.spec_from_file_location("run_tests_parallel", _RUNNER_PATH)
|
|
mod = importlib.util.module_from_spec(spec)
|
|
spec.loader.exec_module(mod)
|
|
return mod
|
|
|
|
|
|
def _cp1252_stream() -> tuple[io.TextIOWrapper, io.BytesIO]:
|
|
raw = io.BytesIO()
|
|
return io.TextIOWrapper(raw, encoding="cp1252", errors="strict"), raw
|
|
|
|
|
|
def test_cp1252_stream_reproduces_the_crash_without_the_fix() -> None:
|
|
# Baseline for the bug: a strict cp1252 stream cannot take the glyph.
|
|
stream, _raw = _cp1252_stream()
|
|
try:
|
|
stream.write("✓")
|
|
except UnicodeEncodeError:
|
|
return
|
|
raise AssertionError("expected UnicodeEncodeError on strict cp1252")
|
|
|
|
|
|
def test_glyph_safe_stdio_survives_cp1252(monkeypatch) -> None:
|
|
mod = _load_runner()
|
|
stream, raw = _cp1252_stream()
|
|
monkeypatch.setattr(sys, "stdout", stream)
|
|
monkeypatch.setattr(sys, "stderr", stream)
|
|
|
|
mod._make_stdio_glyph_safe()
|
|
print("✓ tests/foo.py (3 tests, 1.2s) ✗")
|
|
sys.stdout.flush()
|
|
|
|
out = raw.getvalue()
|
|
assert "✓".encode("utf-8") in out, "stream should now carry UTF-8 glyphs"
|
|
assert b"tests/foo.py (3 tests, 1.2s)" in out, "line content must survive"
|
|
|
|
|
|
def test_glyph_safe_stdio_noop_without_reconfigure(monkeypatch) -> None:
|
|
# Streams without .reconfigure (e.g. pytest's capture buffers, plain
|
|
# StringIO) must pass through untouched instead of raising.
|
|
mod = _load_runner()
|
|
plain = io.StringIO()
|
|
monkeypatch.setattr(sys, "stdout", plain)
|
|
monkeypatch.setattr(sys, "stderr", plain)
|
|
|
|
mod._make_stdio_glyph_safe()
|
|
print("✓ still fine")
|
|
|
|
assert "✓ still fine" in plain.getvalue()
|