mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
165 lines
4.8 KiB
Python
165 lines
4.8 KiB
Python
"""Tests for the ``hermes send`` CLI subcommand.
|
|
|
|
Covers the argument parsing / stdin / file / list behavior of
|
|
``hermes_cli.send_cmd``. The underlying ``send_message_tool`` is stubbed so
|
|
no network I/O or gateway is required.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import io
|
|
import json
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import send_cmd
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _parse(argv):
|
|
"""Build the top-level parser and return the parsed args for ``argv``."""
|
|
import argparse
|
|
|
|
parser = argparse.ArgumentParser(prog="hermes")
|
|
subparsers = parser.add_subparsers(dest="command")
|
|
send_cmd.register_send_subparser(subparsers)
|
|
return parser.parse_args(["send", *argv])
|
|
|
|
|
|
class _FakeTool:
|
|
"""Replacement for ``tools.send_message_tool.send_message_tool``."""
|
|
|
|
def __init__(self, payload):
|
|
self.payload = payload
|
|
self.calls = []
|
|
|
|
def __call__(self, args, **_kw):
|
|
self.calls.append(dict(args))
|
|
return json.dumps(self.payload)
|
|
|
|
|
|
@pytest.fixture
|
|
def fake_tool(monkeypatch):
|
|
"""Install a fake send_message_tool and return the stub for inspection."""
|
|
import sys
|
|
import types
|
|
|
|
fake = _FakeTool({"success": True, "message_id": "m123"})
|
|
|
|
mod = types.ModuleType("tools.send_message_tool")
|
|
mod.send_message_tool = fake
|
|
# Register the stub so ``from tools.send_message_tool import ...`` inside
|
|
# cmd_send resolves to our fake. Also patch the parent ``tools`` package
|
|
# entry so attribute lookup works.
|
|
monkeypatch.setitem(sys.modules, "tools.send_message_tool", mod)
|
|
return fake
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Happy path
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Error paths
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
def test_file_decode_error_suggests_media_directive(fake_tool, capsys, monkeypatch, tmp_path):
|
|
monkeypatch.setattr("sys.stdin.isatty", lambda: True)
|
|
bad = tmp_path / "bad-bytes.bin"
|
|
bad.write_bytes(b"\xff\xfe\x00")
|
|
|
|
args = _parse(["--to", "telegram", "--file", str(bad)])
|
|
with pytest.raises(SystemExit) as exc:
|
|
send_cmd.cmd_send(args)
|
|
assert exc.value.code == 2
|
|
err = capsys.readouterr().err
|
|
assert "not a text file" in err.lower()
|
|
assert f"MEDIA:{bad}" in err
|
|
assert "[[as_document]]" in err
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# --list
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Parser registration contract
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_register_send_subparser_is_reusable():
|
|
"""Sanity check: the registrar returns a parser and wires ``cmd_send``."""
|
|
import argparse
|
|
|
|
parser = argparse.ArgumentParser()
|
|
subparsers = parser.add_subparsers(dest="command")
|
|
send_parser = send_cmd.register_send_subparser(subparsers)
|
|
assert send_parser is not None
|
|
args = parser.parse_args(["send", "--to", "telegram", "hi"])
|
|
assert args.func is send_cmd.cmd_send
|
|
assert args.to == "telegram"
|
|
assert args.message == "hi"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Env loader
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_load_hermes_env_bridges_config_yaml_scalars(tmp_path, monkeypatch):
|
|
"""Top-level config.yaml scalars should be bridged into os.environ.
|
|
|
|
This mirrors the gateway/run.py bootstrap behavior: without this, running
|
|
``hermes send`` from a fresh shell cannot resolve the home channel
|
|
because ``TELEGRAM_HOME_CHANNEL`` (saved by ``hermes config set``) lives
|
|
in config.yaml, not in .env — and the gateway's config loader reads via
|
|
``os.getenv(...)``.
|
|
"""
|
|
import os
|
|
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / ".env").write_text("SOME_TOKEN=abc123\n")
|
|
(hermes_home / "config.yaml").write_text(
|
|
"TELEGRAM_HOME_CHANNEL: '5550001111'\nnested:\n ignored: true\n"
|
|
)
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.delenv("TELEGRAM_HOME_CHANNEL", raising=False)
|
|
monkeypatch.delenv("SOME_TOKEN", raising=False)
|
|
|
|
# Force get_hermes_home() to re-resolve under the patched env.
|
|
from importlib import reload
|
|
|
|
import hermes_cli.config as _hc_config
|
|
reload(_hc_config)
|
|
|
|
send_cmd._load_hermes_env()
|
|
|
|
assert os.environ.get("SOME_TOKEN") == "abc123"
|
|
assert os.environ.get("TELEGRAM_HOME_CHANNEL") == "5550001111"
|
|
|
|
|