mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
163 lines
5.3 KiB
Python
163 lines
5.3 KiB
Python
"""Regression tests for the /model picker's credential-discovery paths.
|
|
|
|
Covers:
|
|
- Normal path (tokens already in Hermes auth store)
|
|
- Claude Code fallback (tokens only in ~/.claude/.credentials.json)
|
|
- Negative case (no credentials anywhere)
|
|
|
|
Note: auto-import from ~/.codex/auth.json was removed in #12360 — Hermes
|
|
now owns its own openai-codex auth state, and users explicitly adopt
|
|
existing Codex CLI tokens via `hermes auth openai-codex`. The old
|
|
"Codex CLI shared file" discovery tests were removed with that change.
|
|
"""
|
|
|
|
import base64
|
|
import json
|
|
import time
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_fake_jwt(expiry_offset: int = 3600) -> str:
|
|
"""Build a fake JWT with a future expiry."""
|
|
header = base64.urlsafe_b64encode(b'{"alg":"RS256"}').rstrip(b"=").decode()
|
|
exp = int(time.time()) + expiry_offset
|
|
payload_bytes = json.dumps({"exp": exp, "sub": "test"}).encode()
|
|
payload = base64.urlsafe_b64encode(payload_bytes).rstrip(b"=").decode()
|
|
return f"{header}.{payload}.fakesig"
|
|
|
|
|
|
@pytest.fixture()
|
|
def hermes_auth_only_env(tmp_path, monkeypatch):
|
|
"""Tokens already in Hermes auth store (no Codex CLI needed)."""
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
# Point CODEX_HOME to nonexistent dir to prove it's not needed
|
|
monkeypatch.setenv("CODEX_HOME", str(tmp_path / "no_codex"))
|
|
|
|
(hermes_home / "auth.json").write_text(json.dumps({
|
|
"version": 2,
|
|
"providers": {
|
|
"openai-codex": {
|
|
"tokens": {
|
|
"access_token": _make_fake_jwt(),
|
|
"refresh_token": "fake-refresh",
|
|
},
|
|
"last_refresh": "2026-04-12T00:00:00Z",
|
|
}
|
|
},
|
|
}))
|
|
|
|
for var in [
|
|
"OPENROUTER_API_KEY", "OPENAI_API_KEY", "ANTHROPIC_API_KEY",
|
|
"NOUS_API_KEY", "DEEPSEEK_API_KEY",
|
|
]:
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
return hermes_home
|
|
|
|
|
|
def test_normal_path_still_works(hermes_auth_only_env):
|
|
"""openai-codex appears when tokens are already in Hermes auth store."""
|
|
from hermes_cli.model_switch import list_authenticated_providers
|
|
|
|
providers = list_authenticated_providers(
|
|
current_provider="openai-codex",
|
|
max_models=10,
|
|
)
|
|
slugs = [p["slug"] for p in providers]
|
|
assert "openai-codex" in slugs
|
|
|
|
|
|
|
|
|
|
@pytest.fixture()
|
|
def claude_code_only_env(tmp_path, monkeypatch):
|
|
"""Set up an environment where Anthropic credentials only exist in
|
|
~/.claude/.credentials.json (Claude Code) — not in env vars or Hermes
|
|
auth store."""
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
# No Codex CLI
|
|
monkeypatch.setenv("CODEX_HOME", str(tmp_path / "no_codex"))
|
|
|
|
(hermes_home / "auth.json").write_text(
|
|
json.dumps({"version": 2, "providers": {}})
|
|
)
|
|
|
|
# Claude Code credentials in the correct format
|
|
claude_dir = tmp_path / ".claude"
|
|
claude_dir.mkdir()
|
|
(claude_dir / ".credentials.json").write_text(json.dumps({
|
|
"claudeAiOauth": {
|
|
"accessToken": _make_fake_jwt(),
|
|
"refreshToken": "fake-refresh",
|
|
"expiresAt": int(time.time() * 1000) + 3_600_000,
|
|
}
|
|
}))
|
|
|
|
# Patch Path.home() so the adapter finds the file
|
|
monkeypatch.setattr(Path, "home", classmethod(lambda cls: tmp_path))
|
|
|
|
for var in [
|
|
"OPENROUTER_API_KEY", "OPENAI_API_KEY", "ANTHROPIC_API_KEY",
|
|
"ANTHROPIC_TOKEN", "CLAUDE_CODE_OAUTH_TOKEN",
|
|
"NOUS_API_KEY", "DEEPSEEK_API_KEY",
|
|
]:
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
return hermes_home
|
|
|
|
|
|
def test_claude_code_file_detected_by_model_picker(claude_code_only_env):
|
|
"""anthropic should appear when credentials only exist in ~/.claude/.credentials.json."""
|
|
from hermes_cli.model_switch import list_authenticated_providers
|
|
|
|
providers = list_authenticated_providers(
|
|
current_provider="anthropic",
|
|
max_models=10,
|
|
)
|
|
slugs = [p["slug"] for p in providers]
|
|
assert "anthropic" in slugs, (
|
|
f"anthropic not found in /model picker providers: {slugs}"
|
|
)
|
|
|
|
anthropic = next(p for p in providers if p["slug"] == "anthropic")
|
|
assert anthropic["is_current"] is True
|
|
assert anthropic["total_models"] > 0
|
|
|
|
|
|
def test_no_codex_when_no_credentials(tmp_path, monkeypatch):
|
|
"""openai-codex should NOT appear when no credentials exist anywhere."""
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setenv("CODEX_HOME", str(tmp_path / "no_codex"))
|
|
|
|
(hermes_home / "auth.json").write_text(
|
|
json.dumps({"version": 2, "providers": {}})
|
|
)
|
|
|
|
for var in [
|
|
"OPENROUTER_API_KEY", "OPENAI_API_KEY", "ANTHROPIC_API_KEY",
|
|
"NOUS_API_KEY", "DEEPSEEK_API_KEY", "COPILOT_GITHUB_TOKEN",
|
|
"GH_TOKEN", "GEMINI_API_KEY",
|
|
]:
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
from hermes_cli.model_switch import list_authenticated_providers
|
|
|
|
providers = list_authenticated_providers(
|
|
current_provider="openrouter",
|
|
max_models=10,
|
|
)
|
|
slugs = [p["slug"] for p in providers]
|
|
assert "openai-codex" not in slugs, (
|
|
"openai-codex should not appear without any credentials"
|
|
)
|