mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
85 lines
2.6 KiB
Python
85 lines
2.6 KiB
Python
"""Tests for utils.atomic_json_write — crash-safe JSON file writes."""
|
|
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from utils import atomic_json_write
|
|
|
|
|
|
class TestAtomicJsonWrite:
|
|
"""Core atomic write behavior."""
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_cleans_up_temp_file_on_baseexception(self, tmp_path):
|
|
class SimulatedAbort(BaseException):
|
|
pass
|
|
|
|
target = tmp_path / "data.json"
|
|
original = {"preserved": True}
|
|
target.write_text(json.dumps(original), encoding="utf-8")
|
|
|
|
with patch("utils.json.dump", side_effect=SimulatedAbort):
|
|
with pytest.raises(SimulatedAbort):
|
|
atomic_json_write(target, {"new": True})
|
|
|
|
tmp_files = [f for f in tmp_path.iterdir() if ".tmp" in f.name]
|
|
assert len(tmp_files) == 0
|
|
assert json.loads(target.read_text(encoding="utf-8")) == original
|
|
|
|
|
|
|
|
|
|
def test_mode_does_not_crash_without_fchmod(self, tmp_path):
|
|
"""Regression: os.fchmod is Unix-only and absent on Windows. Passing a
|
|
mode must not raise AttributeError when fchmod is unavailable.
|
|
|
|
Simulates the Windows os module by removing fchmod from the namespace.
|
|
Previously this crashed in `hermes memory setup` while saving the
|
|
Hindsight config with mode=0o600 (GitHub: Windows setup traceback).
|
|
"""
|
|
import utils
|
|
|
|
target = tmp_path / "secret.json"
|
|
no_fchmod = {k: getattr(os, k) for k in dir(os) if k != "fchmod"}
|
|
fake_os = type("FakeOs", (), no_fchmod)
|
|
assert not hasattr(fake_os, "fchmod")
|
|
|
|
with patch.object(utils, "os", fake_os):
|
|
atomic_json_write(target, {"api_key": "secret"}, mode=0o600)
|
|
|
|
assert json.loads(target.read_text(encoding="utf-8")) == {"api_key": "secret"}
|
|
|
|
|
|
def test_concurrent_writes_dont_corrupt(self, tmp_path):
|
|
"""Multiple rapid writes should each produce valid JSON."""
|
|
import threading
|
|
|
|
target = tmp_path / "concurrent.json"
|
|
errors = []
|
|
|
|
def writer(n):
|
|
try:
|
|
atomic_json_write(target, {"writer": n, "data": list(range(100))})
|
|
except Exception as e:
|
|
errors.append(e)
|
|
|
|
threads = [threading.Thread(target=writer, args=(i,)) for i in range(10)]
|
|
for t in threads:
|
|
t.start()
|
|
for t in threads:
|
|
t.join()
|
|
|
|
assert not errors
|
|
# File should contain valid JSON from one of the writers
|
|
result = json.loads(target.read_text())
|
|
assert "writer" in result
|
|
assert len(result["data"]) == 100
|