mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
99 lines
2.9 KiB
Python
99 lines
2.9 KiB
Python
"""Tests for agent.async_utils.safe_schedule_threadsafe."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import gc
|
|
import warnings
|
|
from concurrent.futures import Future
|
|
from unittest.mock import patch
|
|
|
|
|
|
from agent.async_utils import safe_schedule_threadsafe
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _no_unawaited_warnings(caught, *, coro_name: str = "") -> bool:
|
|
"""Return True if no "X was never awaited" warning slipped through.
|
|
|
|
When *coro_name* is provided, only warnings naming that coroutine are
|
|
counted
|
|
"""
|
|
bad = [
|
|
w for w in caught
|
|
if issubclass(w.category, RuntimeWarning)
|
|
and "was never awaited" in str(w.message)
|
|
and (not coro_name or coro_name in str(w.message))
|
|
]
|
|
return not bad
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSafeScheduleThreadsafe:
|
|
def test_returns_future_on_success(self):
|
|
loop = asyncio.new_event_loop()
|
|
try:
|
|
import threading
|
|
ready = threading.Event()
|
|
stop = threading.Event()
|
|
|
|
def _runner():
|
|
asyncio.set_event_loop(loop)
|
|
ready.set()
|
|
loop.run_until_complete(_wait_for_stop(stop))
|
|
|
|
async def _wait_for_stop(ev):
|
|
while not ev.is_set():
|
|
await asyncio.sleep(0.005)
|
|
|
|
t = threading.Thread(target=_runner, daemon=True)
|
|
t.start()
|
|
ready.wait(timeout=2)
|
|
|
|
async def _sample():
|
|
return 42
|
|
|
|
fut = safe_schedule_threadsafe(_sample(), loop)
|
|
assert isinstance(fut, Future)
|
|
assert fut.result(timeout=2) == 42
|
|
|
|
stop.set()
|
|
t.join(timeout=2)
|
|
finally:
|
|
if loop.is_running():
|
|
loop.call_soon_threadsafe(loop.stop)
|
|
loop.close()
|
|
|
|
|
|
|
|
def test_scheduling_exception_closes_coroutine(self):
|
|
"""If run_coroutine_threadsafe raises, close the coroutine and return None."""
|
|
# A loop that *looks* open but raises on submission
|
|
loop = asyncio.new_event_loop()
|
|
try:
|
|
async def _sample():
|
|
return "ok"
|
|
|
|
coro = _sample()
|
|
with warnings.catch_warnings(record=True) as caught:
|
|
warnings.simplefilter("always")
|
|
with patch(
|
|
"agent.async_utils.asyncio.run_coroutine_threadsafe",
|
|
side_effect=RuntimeError("scheduler down"),
|
|
):
|
|
result = safe_schedule_threadsafe(coro, loop)
|
|
del coro
|
|
gc.collect()
|
|
|
|
assert result is None
|
|
assert _no_unawaited_warnings(caught, coro_name='_sample')
|
|
finally:
|
|
loop.close()
|
|
|
|
|