mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-21 10:22:18 +00:00
b15dc58064
The image-generate tool showed a placeholder, then the model echoed a (often different) image inline in its prose — a second, jarring copy in the wrong place, dimmed as tool scaffolding, with a misplaced download button. Now the generated image lives only in the tool slot: - Strip every embedded image/media link from the assistant prose of a message that produced an image (the model frequently restates the remote URL while the result holds the local path), preserving the agent's words. Applied on hydration, live deltas, and completion. - One stable frame sized from the aspect_ratio arg up front, so the diffusion placeholder and the decoded image share the same box and crossfade with no layout shift; the box derives its height from the true ratio on load (no letterboxing). - Exempt generated images from the tool-block dim-until-hover rule. - Extract a shared useImageDownload hook + ImageLightbox so the tool image and markdown images share one implementation.
97 lines
3.3 KiB
TypeScript
97 lines
3.3 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import {
|
|
dedupeGeneratedImageEchoesInParts,
|
|
generatedImageEchoSources,
|
|
generatedImageFromResult,
|
|
stripGeneratedImageEchoes
|
|
} from './generated-images'
|
|
|
|
describe('generatedImageFromResult', () => {
|
|
it('prefers the host-visible image path', () => {
|
|
expect(
|
|
generatedImageFromResult({
|
|
agent_visible_image: '/container/cache/cat.png',
|
|
host_image: '/Users/me/.hermes/cache/images/cat.png',
|
|
image: '/Users/me/.hermes/cache/images/cat.png',
|
|
success: true
|
|
})
|
|
).toBe('/Users/me/.hermes/cache/images/cat.png')
|
|
})
|
|
|
|
it('ignores failed image generation results', () => {
|
|
expect(generatedImageFromResult({ image: 'https://cdn.example/cat.png', success: false })).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('stripGeneratedImageEchoes', () => {
|
|
it('removes repeated generated image markdown without removing prose', () => {
|
|
expect(
|
|
stripGeneratedImageEchoes('Here you go.\n\n', [
|
|
'https://cdn.example/cat.png'
|
|
])
|
|
).toBe('Here you go.')
|
|
})
|
|
|
|
it('removes media links for generated local image paths', () => {
|
|
expect(
|
|
stripGeneratedImageEchoes('Saved image: [Image: cat.png](#media:%2Ftmp%2Fcat.png)', ['/tmp/cat.png'])
|
|
).toBe('Saved image:')
|
|
})
|
|
})
|
|
|
|
describe('generatedImageEchoSources', () => {
|
|
it('collects every path variant the model might restate', () => {
|
|
expect(
|
|
generatedImageEchoSources([
|
|
{
|
|
result: { agent_visible_image: '/sandbox/cat.png', host_image: '/host/cat.png', image: '/host/cat.png', success: true },
|
|
toolName: 'image_generate',
|
|
type: 'tool-call'
|
|
}
|
|
])
|
|
).toEqual(['/host/cat.png', '/sandbox/cat.png'])
|
|
})
|
|
})
|
|
|
|
describe('dedupeGeneratedImageEchoesInParts', () => {
|
|
it('keeps the agent prose while removing the duplicated image', () => {
|
|
expect(
|
|
dedupeGeneratedImageEchoesInParts([
|
|
{ text: 'Here is your peacock!  Enjoy.', type: 'text' },
|
|
{ result: { host_image: '/host/p.png', image: '/host/p.png', success: true }, toolName: 'image_generate', type: 'tool-call' }
|
|
])
|
|
).toEqual([
|
|
{ text: 'Here is your peacock! Enjoy.', type: 'text' },
|
|
{ result: { host_image: '/host/p.png', image: '/host/p.png', success: true }, toolName: 'image_generate', type: 'tool-call' }
|
|
])
|
|
})
|
|
|
|
it('strips a sandbox path the model restated instead of the host path', () => {
|
|
expect(
|
|
dedupeGeneratedImageEchoesInParts([
|
|
{ text: '', type: 'text' },
|
|
{
|
|
result: { agent_visible_image: '/sandbox/cat.png', host_image: '/host/cat.png', image: '/host/cat.png', success: true },
|
|
toolName: 'image_generate',
|
|
type: 'tool-call'
|
|
}
|
|
])
|
|
).toEqual([
|
|
{
|
|
result: { agent_visible_image: '/sandbox/cat.png', host_image: '/host/cat.png', image: '/host/cat.png', success: true },
|
|
toolName: 'image_generate',
|
|
type: 'tool-call'
|
|
}
|
|
])
|
|
})
|
|
|
|
it('leaves pending generations untouched so the agent prose survives', () => {
|
|
const parts = [
|
|
{ text: 'Another peacock, coming up!', type: 'text' },
|
|
{ result: undefined, toolName: 'image_generate', type: 'tool-call' }
|
|
]
|
|
|
|
expect(dedupeGeneratedImageEchoesInParts(parts)).toEqual(parts)
|
|
})
|
|
})
|