mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
117 lines
3.6 KiB
Python
117 lines
3.6 KiB
Python
"""Tests for container-aware CLI routing (NixOS container mode).
|
|
|
|
When container.enable = true in the NixOS module, the activation script
|
|
writes a .container-mode metadata file. The host CLI detects this and
|
|
execs into the container instead of running locally.
|
|
"""
|
|
import os
|
|
import subprocess
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.config import (
|
|
get_container_exec_info,
|
|
)
|
|
|
|
|
|
# =============================================================================
|
|
# get_container_exec_info
|
|
# =============================================================================
|
|
|
|
|
|
@pytest.fixture
|
|
def container_env(tmp_path, monkeypatch):
|
|
"""Set up a fake HERMES_HOME with .container-mode file."""
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.delenv("HERMES_DEV", raising=False)
|
|
|
|
container_mode = hermes_home / ".container-mode"
|
|
container_mode.write_text(
|
|
"# Written by NixOS activation script. Do not edit manually.\n"
|
|
"backend=podman\n"
|
|
"container_name=hermes-agent\n"
|
|
"exec_user=hermes\n"
|
|
"hermes_bin=/data/current-package/bin/hermes\n"
|
|
)
|
|
return hermes_home
|
|
|
|
|
|
def test_get_container_exec_info_returns_metadata(container_env):
|
|
"""Reads .container-mode and returns all fields including exec_user."""
|
|
with patch("hermes_constants.is_container", return_value=False):
|
|
info = get_container_exec_info()
|
|
|
|
assert info is not None
|
|
assert info["backend"] == "podman"
|
|
assert info["container_name"] == "hermes-agent"
|
|
assert info["exec_user"] == "hermes"
|
|
assert info["hermes_bin"] == "/data/current-package/bin/hermes"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# =============================================================================
|
|
# _exec_in_container
|
|
# =============================================================================
|
|
|
|
|
|
@pytest.fixture
|
|
def docker_container_info():
|
|
return {
|
|
"backend": "docker",
|
|
"container_name": "hermes-agent",
|
|
"exec_user": "hermes",
|
|
"hermes_bin": "/data/current-package/bin/hermes",
|
|
}
|
|
|
|
|
|
@pytest.fixture
|
|
def podman_container_info():
|
|
return {
|
|
"backend": "podman",
|
|
"container_name": "hermes-agent",
|
|
"exec_user": "hermes",
|
|
"hermes_bin": "/data/current-package/bin/hermes",
|
|
}
|
|
|
|
|
|
def test_exec_in_container_calls_execvp(docker_container_info):
|
|
"""Verifies os.execvp is called with correct args: runtime, tty flags,
|
|
user, env vars, container name, binary, and CLI args."""
|
|
from hermes_cli.main import _exec_in_container
|
|
|
|
with patch("shutil.which", return_value="/usr/bin/docker"), \
|
|
patch("subprocess.run") as mock_run, \
|
|
patch("sys.stdin") as mock_stdin, \
|
|
patch("os.execvp") as mock_execvp, \
|
|
patch.dict(os.environ, {"TERM": "xterm-256color", "LANG": "en_US.UTF-8"},
|
|
clear=False):
|
|
mock_stdin.isatty.return_value = True
|
|
mock_run.return_value = MagicMock(returncode=0)
|
|
|
|
_exec_in_container(docker_container_info, ["chat", "-m", "opus"])
|
|
|
|
mock_execvp.assert_called_once()
|
|
cmd = mock_execvp.call_args[0][1]
|
|
assert cmd[0] == "/usr/bin/docker"
|
|
assert cmd[1] == "exec"
|
|
assert "-it" in cmd
|
|
idx_u = cmd.index("-u")
|
|
assert cmd[idx_u + 1] == "hermes"
|
|
e_indices = [i for i, v in enumerate(cmd) if v == "-e"]
|
|
e_values = [cmd[i + 1] for i in e_indices]
|
|
assert "TERM=xterm-256color" in e_values
|
|
assert "LANG=en_US.UTF-8" in e_values
|
|
assert "hermes-agent" in cmd
|
|
assert "/data/current-package/bin/hermes" in cmd
|
|
assert "chat" in cmd
|
|
|
|
|