mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-21 16:18:55 +00:00
06c729706f
Unit-test flag stripping without Docker, and assert the image shim rejects the rc.init '-g: not found' restart loop from #66679.
107 lines
3.3 KiB
Python
107 lines
3.3 KiB
Python
"""Unit tests for docker/tini-shim.sh argument stripping (#66679).
|
|
|
|
These run without Docker: the shim's HERMES_TINI_SHIM_TARGET /
|
|
HERMES_TINI_SHIM_WRAPPER hooks let us record the argv that would be
|
|
handed to /init.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import subprocess
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
SHIM = REPO_ROOT / "docker" / "tini-shim.sh"
|
|
|
|
|
|
@pytest.fixture
|
|
def recorder(tmp_path: Path) -> tuple[Path, Path]:
|
|
"""Fake /init + wrapper that print argv, one token per line."""
|
|
init = tmp_path / "fake-init"
|
|
wrapper = tmp_path / "fake-wrapper"
|
|
init.write_text("#!/bin/sh\nprintf '%s\\n' \"$@\"\n")
|
|
wrapper.write_text("#!/bin/sh\nprintf 'wrapper\\n'\n")
|
|
init.chmod(0o755)
|
|
wrapper.chmod(0o755)
|
|
return init, wrapper
|
|
|
|
|
|
def _run_shim(
|
|
recorder: tuple[Path, Path],
|
|
args: list[str],
|
|
) -> subprocess.CompletedProcess[str]:
|
|
init, wrapper = recorder
|
|
env = os.environ.copy()
|
|
env["HERMES_TINI_SHIM_TARGET"] = str(init)
|
|
env["HERMES_TINI_SHIM_WRAPPER"] = str(wrapper)
|
|
return subprocess.run(
|
|
["sh", str(SHIM), *args],
|
|
capture_output=True,
|
|
text=True,
|
|
timeout=10,
|
|
env=env,
|
|
check=False,
|
|
)
|
|
|
|
|
|
def test_shim_script_is_executable_bit_friendly() -> None:
|
|
assert SHIM.is_file()
|
|
text = SHIM.read_text()
|
|
assert text.startswith("#!/bin/sh")
|
|
assert "HERMES_TINI_SHIM_TARGET" in text
|
|
|
|
|
|
def test_strips_g_and_double_dash(recorder: tuple[Path, Path]) -> None:
|
|
"""Legacy `tini -g -- gateway run` must not forward `-g` to /init."""
|
|
r = _run_shim(recorder, ["-g", "--", "gateway", "run"])
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
init, wrapper = recorder
|
|
assert lines[0] == str(wrapper)
|
|
assert lines[1:] == ["gateway", "run"]
|
|
assert "-g" not in lines
|
|
assert "--" not in lines
|
|
|
|
|
|
def test_strips_g_without_double_dash(recorder: tuple[Path, Path]) -> None:
|
|
r = _run_shim(recorder, ["-g", "gateway", "run"])
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
init, wrapper = recorder
|
|
assert lines == [str(wrapper), "gateway", "run"]
|
|
|
|
|
|
def test_empty_args_after_flags_uses_wrapper_only(
|
|
recorder: tuple[Path, Path],
|
|
) -> None:
|
|
"""entrypoint `tini -g --` with empty CMD → /init main-wrapper."""
|
|
r = _run_shim(recorder, ["-g", "--"])
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
_, wrapper = recorder
|
|
assert lines == [str(wrapper)]
|
|
|
|
|
|
def test_does_not_double_wrap_existing_wrapper(
|
|
recorder: tuple[Path, Path],
|
|
) -> None:
|
|
_, wrapper = recorder
|
|
r = _run_shim(recorder, ["-g", "--", str(wrapper), "gateway", "run"])
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
assert lines == [str(wrapper), "gateway", "run"]
|
|
|
|
|
|
def test_strips_p_and_e_with_arguments(recorder: tuple[Path, Path]) -> None:
|
|
r = _run_shim(
|
|
recorder,
|
|
["-p", "SIGKILL", "-e", "143", "-v", "-v", "--", "sleep", "infinity"],
|
|
)
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
_, wrapper = recorder
|
|
assert lines == [str(wrapper), "sleep", "infinity"]
|
|
assert "SIGKILL" not in lines
|
|
assert "143" not in lines
|