mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-07 08:02:23 +00:00
8c78f533dd
Copilot caught an important runtime parity gap on PR #27489: the fix imported the npm `wrap-ansi` package directly, but Ink's `<Text wrap="wrap">` uses a runtime-selecting shim (`ui-tui/packages/hermes-ink/src/ink/wrapAnsi.ts`) that prefers `Bun.wrapAnsi` when running under Bun and falls back to the npm package elsewhere. So under Bun, Ink would render via `Bun.wrapAnsi` while `cursorLayout` would compute breaks via the npm package — any disagreement reintroduces the exact cursor-drift symptom the PR is meant to eliminate. Fix: - Export `wrapAnsi` from `@hermes/ink` (`packages/hermes-ink/src/entry-exports.ts` and `packages/hermes-ink/index.d.ts`) so the shim is the public surface. - Switch `ui-tui/src/lib/inputMetrics.ts` from `import wrapAnsi from 'wrap-ansi'` to `import { wrapAnsi } from '@hermes/ink'`. Both renderer (Ink) and cursor layout now traverse the same shim, so they share the runtime-selected implementation by construction. - Same swap in `textInputWrap.test.ts` and `cursorDriftRegression.test.ts` — tests now assert parity through the shim, which means under Bun they actually exercise Bun's implementation instead of asserting a tautology against the npm package. - Drop the direct `"wrap-ansi": "^9.0.0"` from `ui-tui/package.json`. `@hermes/ink` (which IS a declared dep) pulls wrap-ansi in transitively — that's not a phantom dep because the import path goes through `@hermes/ink`'s public exports, not through a hoisting accident. Verified: 791/791 vitest tests pass. `@hermes/ink` rebuilt (`dist/entry-exports.js` includes `wrapAnsi` export). TUI bundle rebuilt clean.
39 lines
2.6 KiB
TypeScript
39 lines
2.6 KiB
TypeScript
/// <reference path="./ambient.d.ts" />
|
|
export { default as useStderr } from './src/hooks/use-stderr.ts'
|
|
export type { StderrHandle } from './src/hooks/use-stderr.ts'
|
|
export { default as useStdout } from './src/hooks/use-stdout.ts'
|
|
export type { StdoutHandle } from './src/hooks/use-stdout.ts'
|
|
export { Ansi } from './src/ink/Ansi.tsx'
|
|
export { evictInkCaches } from './src/ink/cache-eviction.ts'
|
|
export type { EvictLevel, InkCacheSizes } from './src/ink/cache-eviction.ts'
|
|
export { AlternateScreen } from './src/ink/components/AlternateScreen.tsx'
|
|
export { default as Box } from './src/ink/components/Box.tsx'
|
|
export type { Props as BoxProps } from './src/ink/components/Box.tsx'
|
|
export { default as Link } from './src/ink/components/Link.tsx'
|
|
export { default as Newline } from './src/ink/components/Newline.tsx'
|
|
export { NoSelect } from './src/ink/components/NoSelect.tsx'
|
|
export { RawAnsi } from './src/ink/components/RawAnsi.tsx'
|
|
export { default as ScrollBox } from './src/ink/components/ScrollBox.tsx'
|
|
export type { ScrollBoxHandle, ScrollBoxProps } from './src/ink/components/ScrollBox.tsx'
|
|
export { default as Spacer } from './src/ink/components/Spacer.tsx'
|
|
export type { Props as StdinProps } from './src/ink/components/StdinContext.ts'
|
|
export { default as Text } from './src/ink/components/Text.tsx'
|
|
export type { Props as TextProps } from './src/ink/components/Text.tsx'
|
|
export type { Key } from './src/ink/events/input-event.ts'
|
|
export { default as useApp } from './src/ink/hooks/use-app.ts'
|
|
export { useCursorAdvance } from './src/ink/hooks/use-cursor-advance.ts'
|
|
export { useDeclaredCursor } from './src/ink/hooks/use-declared-cursor.ts'
|
|
export { default as useInput } from './src/ink/hooks/use-input.ts'
|
|
export { useHasSelection, useSelection } from './src/ink/hooks/use-selection.ts'
|
|
export { default as useStdin } from './src/ink/hooks/use-stdin.ts'
|
|
export { useTabStatus } from './src/ink/hooks/use-tab-status.ts'
|
|
export { useTerminalFocus } from './src/ink/hooks/use-terminal-focus.ts'
|
|
export { useTerminalTitle } from './src/ink/hooks/use-terminal-title.ts'
|
|
export { useTerminalViewport } from './src/ink/hooks/use-terminal-viewport.ts'
|
|
export { default as measureElement } from './src/ink/measure-element.ts'
|
|
export { createRoot, forceRedraw, default as render, renderSync } from './src/ink/root.ts'
|
|
export type { Instance, RenderOptions, Root } from './src/ink/root.ts'
|
|
export { stringWidth } from './src/ink/stringWidth.ts'
|
|
export { wrapAnsi } from './src/ink/wrapAnsi.ts'
|
|
export { default as TextInput, UncontrolledTextInput } from 'ink-text-input'
|
|
export type { Props as TextInputProps } from 'ink-text-input'
|