mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
112 lines
3.5 KiB
Python
112 lines
3.5 KiB
Python
"""Tests for per-file consecutive patch-failure tracking.
|
|
|
|
When the agent repeatedly fails to patch the same file with similar but
|
|
non-matching old_strings, it's usually stuck in a loop with a stale view
|
|
of the file. After 3 consecutive failures on the same path, the patch
|
|
tool injects an escalating ``_hint`` that tells the model to break out
|
|
of the loop (re-read, use longer context, or fall back to write_file).
|
|
|
|
See issue #507 (Roo Code deep-dive, item 2f).
|
|
"""
|
|
|
|
import json
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def hermes_home(monkeypatch, tmp_path):
|
|
"""Isolate HERMES_HOME and clear module-level caches afterward so the
|
|
real shell-out side effects from _handle_patch don't leak into
|
|
subsequent tests (see test_line_ending_preservation.py for details)."""
|
|
home = tmp_path / "hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
yield home
|
|
try:
|
|
from tools.file_tools import clear_file_ops_cache, _read_tracker_lock, _read_tracker
|
|
clear_file_ops_cache()
|
|
with _read_tracker_lock:
|
|
_read_tracker.clear()
|
|
except Exception:
|
|
pass
|
|
try:
|
|
from tools.terminal_tool import _active_environments, _env_lock
|
|
with _env_lock:
|
|
_active_environments.clear()
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
@pytest.fixture
|
|
def fresh_tracker():
|
|
"""Reset the module-level tracker before each test so the count starts
|
|
at zero regardless of prior test order."""
|
|
from tools.file_tools import _patch_failure_tracker, _patch_failure_lock
|
|
|
|
with _patch_failure_lock:
|
|
_patch_failure_tracker.clear()
|
|
yield
|
|
with _patch_failure_lock:
|
|
_patch_failure_tracker.clear()
|
|
|
|
|
|
class TestPatchFailureEscalation:
|
|
def test_first_two_failures_use_normal_hint(self, hermes_home, tmp_path, fresh_tracker):
|
|
from tools.file_tools import _handle_patch
|
|
|
|
target = tmp_path / "f.py"
|
|
target.write_text("def foo():\n return 1\n")
|
|
|
|
for _i in range(2):
|
|
result = _handle_patch(
|
|
{
|
|
"mode": "replace",
|
|
"path": str(target),
|
|
"old_string": f"NONEXISTENT_{_i}_XYZQQQ",
|
|
"new_string": "x",
|
|
},
|
|
task_id="esc_t1",
|
|
)
|
|
d = json.loads(result)
|
|
hint = d.get("_hint", "") or ""
|
|
assert "failure #" not in hint, (
|
|
f"Escalating hint fired too early on attempt {_i + 1}: {hint!r}"
|
|
)
|
|
|
|
|
|
def test_different_tasks_have_independent_counters(
|
|
self, hermes_home, tmp_path, fresh_tracker
|
|
):
|
|
from tools.file_tools import _handle_patch
|
|
|
|
target = tmp_path / "shared.py"
|
|
target.write_text("z = 0\n")
|
|
|
|
# Three failures under task A.
|
|
for _i in range(3):
|
|
_handle_patch(
|
|
{
|
|
"mode": "replace",
|
|
"path": str(target),
|
|
"old_string": f"GHOST_A_{_i}_QWE",
|
|
"new_string": "x",
|
|
},
|
|
task_id="task_A",
|
|
)
|
|
|
|
# First failure under task B — should NOT see escalation.
|
|
result = _handle_patch(
|
|
{
|
|
"mode": "replace",
|
|
"path": str(target),
|
|
"old_string": "GHOST_B_QWE",
|
|
"new_string": "x",
|
|
},
|
|
task_id="task_B",
|
|
)
|
|
d = json.loads(result)
|
|
hint = d.get("_hint", "") or ""
|
|
assert "failure #" not in hint, (
|
|
f"task_B's hint cross-contaminated from task_A: {hint!r}"
|
|
)
|