mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
98 lines
3.1 KiB
Python
98 lines
3.1 KiB
Python
"""Tests for hermes_cli.uninstall.remove_node_symlinks.
|
|
|
|
Regression for #34536: the POSIX installer drops node/npm/npx symlinks in
|
|
~/.local/bin pointing into $HERMES_HOME/node and prepends ~/.local/bin to
|
|
PATH, shadowing an existing nvm. Uninstall must remove those symlinks, but
|
|
only when they still resolve into the Hermes-managed node dir.
|
|
"""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
import hermes_cli.uninstall as uninstall
|
|
|
|
|
|
@pytest.fixture
|
|
def fake_home(tmp_path, monkeypatch):
|
|
"""Redirect Path.home() at the home both the installer-symlink target and
|
|
the ~/.local/bin links live under the same temp dir."""
|
|
home = tmp_path / "home"
|
|
home.mkdir()
|
|
monkeypatch.setattr(Path, "home", classmethod(lambda cls: home))
|
|
(home / ".local" / "bin").mkdir(parents=True)
|
|
return home
|
|
|
|
|
|
def _make_hermes_node(hermes_home: Path) -> Path:
|
|
"""Create a fake $HERMES_HOME/node/bin/{node,npm,npx} tree."""
|
|
node_bin = hermes_home / "node" / "bin"
|
|
node_bin.mkdir(parents=True)
|
|
for name in ("node", "npm", "npx"):
|
|
(node_bin / name).write_text("#!/bin/sh\n")
|
|
(node_bin / name).chmod(0o755)
|
|
return node_bin
|
|
|
|
|
|
|
|
|
|
def test_leaves_unrelated_symlinks_untouched(fake_home):
|
|
"""A node symlink the user repointed at nvm must survive uninstall."""
|
|
hermes_home = fake_home / ".hermes"
|
|
_make_hermes_node(hermes_home)
|
|
local_bin = fake_home / ".local" / "bin"
|
|
|
|
# Simulate nvm's node living elsewhere; user's ~/.local/bin/node -> nvm.
|
|
nvm_bin = fake_home / ".nvm" / "versions" / "node" / "v20.0.0" / "bin"
|
|
nvm_bin.mkdir(parents=True)
|
|
(nvm_bin / "node").write_text("#!/bin/sh\n")
|
|
(local_bin / "node").symlink_to(nvm_bin / "node")
|
|
|
|
removed = uninstall.remove_node_symlinks(hermes_home)
|
|
|
|
assert removed == []
|
|
assert (local_bin / "node").is_symlink()
|
|
assert (local_bin / "node").resolve() == (nvm_bin / "node").resolve()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_removes_fhs_symlinks_in_usr_local_bin(fake_home, tmp_path, monkeypatch):
|
|
"""Root FHS installs place node symlinks in /usr/local/bin.
|
|
|
|
We monkeypatch _node_symlink_candidate_dirs to return a temp dir standing
|
|
in for /usr/local/bin so the test doesn't need real root privileges.
|
|
"""
|
|
hermes_home = fake_home / ".hermes"
|
|
node_bin = _make_hermes_node(hermes_home)
|
|
|
|
# Fake /usr/local/bin as a temp dir with our symlinks.
|
|
fhs_bin = tmp_path / "usr_local_bin"
|
|
fhs_bin.mkdir()
|
|
for name in ("node", "npm", "npx"):
|
|
(fhs_bin / name).symlink_to(node_bin / name)
|
|
|
|
# Ensure ~/.local/bin has NO symlinks (simulate pure FHS install).
|
|
local_bin = fake_home / ".local" / "bin"
|
|
for name in ("node", "npm", "npx"):
|
|
p = local_bin / name
|
|
if p.exists() or p.is_symlink():
|
|
p.unlink()
|
|
|
|
# Return only our fake FHS dir as a candidate.
|
|
monkeypatch.setattr(
|
|
uninstall, "_node_symlink_candidate_dirs", lambda: [fhs_bin]
|
|
)
|
|
|
|
removed = uninstall.remove_node_symlinks(hermes_home)
|
|
|
|
assert sorted(p.name for p in removed) == ["node", "npm", "npx"]
|
|
for name in ("node", "npm", "npx"):
|
|
assert not (fhs_bin / name).is_symlink()
|