mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
62 lines
2.1 KiB
Python
62 lines
2.1 KiB
Python
"""Tests for `_can_open_graphical_browser()` in hermes_cli.auth.
|
|
|
|
Guards the fix for the May 2026 report where `hermes auth add xai-oauth`
|
|
launched a text-mode browser (w3m) INSIDE the terminal on a headless Linux
|
|
box — `_is_remote_session()` only checked SSH/cloud-shell env vars, so a plain
|
|
local box with no GUI browser still called `webbrowser.open()`, which resolved
|
|
to a console browser and hijacked the TTY.
|
|
|
|
The helper distinguishes "a real windowed browser will pop up" from "a console
|
|
browser will hijack the terminal" so OAuth callsites can fall back to printing
|
|
the URL / manual paste instead of auto-opening.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import webbrowser
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.auth import _can_open_graphical_browser
|
|
|
|
|
|
class _FakeController:
|
|
def __init__(self, name: str) -> None:
|
|
self.name = name
|
|
|
|
def open(self, *_a, **_kw): # pragma: no cover - never invoked
|
|
return True
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_browser_env(monkeypatch):
|
|
"""Each test controls DISPLAY / WAYLAND_DISPLAY / BROWSER explicitly."""
|
|
for var in ("DISPLAY", "WAYLAND_DISPLAY", "BROWSER"):
|
|
monkeypatch.delenv(var, raising=False)
|
|
yield
|
|
|
|
|
|
def _force_platform_linux(monkeypatch):
|
|
monkeypatch.setattr("hermes_cli.auth.sys.platform", "linux")
|
|
|
|
|
|
def _force_resolved_browser(monkeypatch, name: str):
|
|
monkeypatch.setattr(webbrowser, "get", lambda *_a, **_kw: _FakeController(name))
|
|
|
|
|
|
def test_headless_linux_no_display_refuses(monkeypatch):
|
|
"""The reported bug: headless Linux, no display server → don't auto-open."""
|
|
_force_platform_linux(monkeypatch)
|
|
# Even if a GUI browser somehow resolved, no display means no GUI.
|
|
_force_resolved_browser(monkeypatch, "google-chrome")
|
|
assert _can_open_graphical_browser() is False
|
|
|
|
|
|
def test_browser_env_pointing_at_console_browser_refuses(monkeypatch):
|
|
"""$BROWSER=w3m must refuse even with a display server present."""
|
|
_force_platform_linux(monkeypatch)
|
|
monkeypatch.setenv("DISPLAY", ":0")
|
|
monkeypatch.setenv("BROWSER", "/usr/bin/w3m")
|
|
assert _can_open_graphical_browser() is False
|
|
|
|
|