mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
114 lines
4.2 KiB
Python
114 lines
4.2 KiB
Python
"""Tests for DM thread session isolation.
|
|
|
|
DM thread sessions must start empty — no parent transcript seeding.
|
|
Thread context is handled by platform adapters (e.g. Slack's
|
|
_fetch_thread_context fetches actual thread replies via the API).
|
|
Session-level seeding was removed because it copied the ENTIRE parent
|
|
DM transcript, causing unrelated conversations to bleed across threads.
|
|
|
|
Covers:
|
|
- Thread sessions start empty (no parent seeding)
|
|
- Group/channel thread sessions also start empty
|
|
- Multiple threads from same parent are independent
|
|
- Existing thread sessions are not mutated on re-access
|
|
- Cross-platform: consistent behavior for Slack, Telegram, Discord
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, GatewayConfig
|
|
from gateway.session import SessionSource, SessionStore
|
|
|
|
|
|
@pytest.fixture()
|
|
def store(tmp_path, monkeypatch):
|
|
"""SessionStore with SQLite — load_transcript reads from DB only.
|
|
|
|
Pin DEFAULT_DB_PATH to tmp_path so SessionDB() can't write to the real
|
|
~/.hermes/state.db. (DEFAULT_DB_PATH is a module-level constant computed
|
|
at hermes_state import time, before pytest's HERMES_HOME monkeypatch
|
|
fires — the autouse fixture's HERMES_HOME override doesn't help here.)
|
|
"""
|
|
import hermes_state
|
|
monkeypatch.setattr(hermes_state, "DEFAULT_DB_PATH", tmp_path / "state.db")
|
|
config = GatewayConfig()
|
|
s = SessionStore(sessions_dir=tmp_path, config=config)
|
|
return s
|
|
|
|
|
|
def _dm_source(platform=Platform.SLACK, chat_id="D123", thread_id=None, user_id="U1"):
|
|
return SessionSource(
|
|
platform=platform,
|
|
chat_id=chat_id,
|
|
chat_type="dm",
|
|
user_id=user_id,
|
|
thread_id=thread_id,
|
|
)
|
|
|
|
|
|
def _group_source(platform=Platform.SLACK, chat_id="C456", thread_id=None, user_id="U1"):
|
|
return SessionSource(
|
|
platform=platform,
|
|
chat_id=chat_id,
|
|
chat_type="group",
|
|
user_id=user_id,
|
|
thread_id=thread_id,
|
|
)
|
|
|
|
|
|
PARENT_HISTORY = [
|
|
{"role": "user", "content": "What's the weather?"},
|
|
{"role": "assistant", "content": "It's sunny and 72°F."},
|
|
]
|
|
|
|
|
|
class TestDMThreadIsolation:
|
|
"""Thread sessions must start empty — no parent transcript seeding."""
|
|
|
|
def test_thread_session_starts_empty(self, store):
|
|
"""New DM thread session should NOT inherit parent's transcript."""
|
|
parent_source = _dm_source()
|
|
parent_entry = store.get_or_create_session(parent_source)
|
|
for msg in PARENT_HISTORY:
|
|
store.append_to_transcript(parent_entry.session_id, msg)
|
|
|
|
thread_source = _dm_source(thread_id="1234567890.000001")
|
|
thread_entry = store.get_or_create_session(thread_source)
|
|
|
|
thread_transcript = store.load_transcript(thread_entry.session_id)
|
|
assert len(thread_transcript) == 0
|
|
|
|
|
|
class TestDMThreadIsolationEdgeCases:
|
|
"""Edge cases — threads always start empty regardless of context."""
|
|
|
|
def test_group_thread_starts_empty(self, store):
|
|
"""Group/channel threads should also start empty."""
|
|
parent_source = _group_source()
|
|
parent_entry = store.get_or_create_session(parent_source)
|
|
for msg in PARENT_HISTORY:
|
|
store.append_to_transcript(parent_entry.session_id, msg)
|
|
|
|
thread_source = _group_source(thread_id="1234567890.000001")
|
|
thread_entry = store.get_or_create_session(thread_source)
|
|
|
|
thread_transcript = store.load_transcript(thread_entry.session_id)
|
|
assert len(thread_transcript) == 0
|
|
|
|
|
|
class TestDMThreadIsolationCrossPlatform:
|
|
"""Verify thread isolation is consistent across all platforms."""
|
|
|
|
@pytest.mark.parametrize("platform", [Platform.SLACK, Platform.TELEGRAM, Platform.DISCORD])
|
|
def test_thread_starts_empty_across_platforms(self, store, platform):
|
|
"""DM thread sessions start empty regardless of platform."""
|
|
parent_source = _dm_source(platform=platform)
|
|
parent_entry = store.get_or_create_session(parent_source)
|
|
for msg in PARENT_HISTORY:
|
|
store.append_to_transcript(parent_entry.session_id, msg)
|
|
|
|
thread_source = _dm_source(platform=platform, thread_id="thread_123")
|
|
thread_entry = store.get_or_create_session(thread_source)
|
|
|
|
thread_transcript = store.load_transcript(thread_entry.session_id)
|
|
assert len(thread_transcript) == 0
|