mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
53 lines
1.6 KiB
Python
53 lines
1.6 KiB
Python
"""Runtime smoke test for Docker $HERMES_HOME/logs/gateways seeding.
|
|
|
|
Build the real image and verify logs/ and logs/gateways/ exist and are
|
|
owned by the hermes user after container boot.
|
|
|
|
Regression guard for #45258: if the first gateway log service runs in
|
|
root context, logs/gateways/ is created root-owned; every profile
|
|
registered later runs its log service as the dropped hermes user and
|
|
s6-log crash-loops on mkdir: Permission denied.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from tests.docker.conftest import (
|
|
docker_exec_sh,
|
|
restart_container,
|
|
start_container,
|
|
)
|
|
|
|
|
|
def test_logs_gateways_seeded_and_hermes_owned(
|
|
built_image: str, container_name: str,
|
|
) -> None:
|
|
"""logs/ and logs/gateways/ must exist and be owned by hermes after boot."""
|
|
start_container(built_image, container_name)
|
|
|
|
# Both directories must exist
|
|
r = docker_exec_sh(
|
|
container_name,
|
|
"test -d /opt/data/logs && "
|
|
"test -d /opt/data/logs/gateways && "
|
|
"echo DIRS_OK || echo DIRS_MISSING",
|
|
timeout=10,
|
|
)
|
|
assert "DIRS_OK" in r.stdout, (
|
|
f"logs/ or logs/gateways/ not seeded: {r.stdout}"
|
|
)
|
|
|
|
# Both must be owned by hermes
|
|
r = docker_exec_sh(
|
|
container_name,
|
|
'logs_owner=$(stat -c "%U" /opt/data/logs); '
|
|
'gateways_owner=$(stat -c "%U" /opt/data/logs/gateways); '
|
|
'echo "logs=$logs_owner gateways=$gateways_owner"',
|
|
timeout=10,
|
|
)
|
|
assert "logs=hermes" in r.stdout, (
|
|
f"logs/ not owned by hermes: {r.stdout}"
|
|
)
|
|
assert "gateways=hermes" in r.stdout, (
|
|
f"logs/gateways/ not owned by hermes: {r.stdout}"
|
|
)
|
|
|
|
|