mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-11 08:42:11 +00:00
975edd4140
* fix(cli): omit --workspace when subpackage has its own package-lock.json When ui-tui/ (or web/) contains its own package-lock.json, _workspace_root() returns the subpackage directory itself. Passing --workspace ui-tui in that case fails because npm cannot find a workspace named 'ui-tui' inside ui-tui/. Fix: skip the --workspace flag when npm_cwd equals the target directory, running a plain 'npm install' from the standalone project root instead. Applies the same fix to both _make_tui_argv (TUI) and _build_web_ui (web). Fixes #42973 * test(cli): fix web workspace-scope fixture + cover own-lockfile fallback (#42973) The web half of the #42977 fix broke test_npm_install_uses_workspace_web_scope, which built its fixture with no lockfile anywhere. Without a root lockfile, _workspace_root(web_dir) already returns web_dir, so the new "() if npm_cwd == web_dir" branch correctly drops --workspace and the assertion failed. Model a real workspace checkout instead: the single package-lock.json lives at the root, so --workspace web scopes the install. Also add the symmetric web regression test (web/ carrying its own lockfile => --workspace must be dropped and the install runs plainly from web_dir via npm ci), matching the TUI coverage already in test_tui_npm_install.py. --------- Co-authored-by: liuhao1024 <sunsky.lau@gmail.com>
85 lines
2.9 KiB
Python
85 lines
2.9 KiB
Python
"""Unit tests for the extracted ``hermes cron`` parser builder.
|
|
|
|
Confirms ``build_cron_parser`` wires up the same subactions, aliases, options,
|
|
and ``func=cmd_cron`` dispatch that lived inline in ``main()`` before the
|
|
god-file Phase 2 extraction.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
|
|
from hermes_cli.subcommands.cron import build_cron_parser
|
|
|
|
|
|
def _sentinel_handler(args): # pragma: no cover - only identity is asserted
|
|
return "cron-handler"
|
|
|
|
|
|
def _build():
|
|
parser = argparse.ArgumentParser(prog="hermes")
|
|
subparsers = parser.add_subparsers(dest="command")
|
|
build_cron_parser(subparsers, cmd_cron=_sentinel_handler)
|
|
return parser
|
|
|
|
|
|
def test_cron_subactions_present():
|
|
parser = _build()
|
|
for action in ("list", "create", "edit", "pause", "resume", "run", "remove", "status", "tick"):
|
|
ns = parser.parse_args(["cron", action] if action in ("list", "status", "tick")
|
|
else ["cron", action, "jobid"] if action in ("pause", "resume", "run", "remove", "edit")
|
|
else ["cron", "create", "30m"])
|
|
assert ns.command == "cron"
|
|
assert ns.cron_command == action
|
|
|
|
|
|
def test_cron_aliases():
|
|
parser = _build()
|
|
# create has alias "add"
|
|
ns = parser.parse_args(["cron", "add", "30m"])
|
|
assert ns.cron_command == "add"
|
|
# remove has aliases rm / delete
|
|
for alias in ("rm", "delete"):
|
|
ns = parser.parse_args(["cron", alias, "jid"])
|
|
assert ns.cron_command == alias
|
|
|
|
|
|
def test_cron_create_options():
|
|
parser = _build()
|
|
ns = parser.parse_args([
|
|
"cron", "create", "0 9 * * *", "daily task prompt",
|
|
"--name", "daily", "--deliver", "origin", "--repeat", "3",
|
|
"--skill", "a", "--skill", "b", "--no-agent",
|
|
"--workdir", "/tmp/x",
|
|
])
|
|
assert ns.schedule == "0 9 * * *"
|
|
assert ns.prompt == "daily task prompt"
|
|
assert ns.name == "daily"
|
|
assert ns.deliver == "origin"
|
|
assert ns.repeat == 3
|
|
assert ns.skills == ["a", "b"]
|
|
assert ns.no_agent is True
|
|
assert ns.workdir == "/tmp/x"
|
|
|
|
|
|
def test_cron_edit_no_agent_tristate():
|
|
parser = _build()
|
|
# --no-agent -> True, --agent -> False, neither -> None
|
|
assert parser.parse_args(["cron", "edit", "j", "--no-agent"]).no_agent is True
|
|
assert parser.parse_args(["cron", "edit", "j", "--agent"]).no_agent is False
|
|
assert parser.parse_args(["cron", "edit", "j"]).no_agent is None
|
|
|
|
|
|
def test_cron_dispatch_func_is_injected_handler():
|
|
parser = _build()
|
|
ns = parser.parse_args(["cron", "list"])
|
|
assert ns.func is _sentinel_handler
|
|
|
|
|
|
def test_cron_accept_hooks_flag_on_run_and_tick():
|
|
parser = _build()
|
|
# --accept-hooks is suppressed-default; present only when passed.
|
|
ns = parser.parse_args(["cron", "run", "jid", "--accept-hooks"])
|
|
assert ns.accept_hooks is True
|
|
ns2 = parser.parse_args(["cron", "tick", "--accept-hooks"])
|
|
assert ns2.accept_hooks is True
|