mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
69 lines
2.3 KiB
Python
69 lines
2.3 KiB
Python
import base64
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import web_server
|
|
|
|
pytest.importorskip("starlette.testclient")
|
|
from starlette.testclient import TestClient
|
|
|
|
|
|
@pytest.fixture
|
|
def client(monkeypatch):
|
|
previous_auth_required = getattr(web_server.app.state, "auth_required", None)
|
|
web_server.app.state.auth_required = False
|
|
test_client = TestClient(web_server.app)
|
|
test_client.headers[web_server._SESSION_HEADER_NAME] = web_server._SESSION_TOKEN
|
|
try:
|
|
yield test_client
|
|
finally:
|
|
if previous_auth_required is None:
|
|
try:
|
|
delattr(web_server.app.state, "auth_required")
|
|
except AttributeError:
|
|
pass
|
|
else:
|
|
web_server.app.state.auth_required = previous_auth_required
|
|
|
|
|
|
def test_fs_list_sorts_and_hides_noise(client, tmp_path):
|
|
root = tmp_path / "project"
|
|
root.mkdir()
|
|
(root / "b.txt").write_text("b")
|
|
(root / "a_dir").mkdir()
|
|
(root / "a.txt").write_text("a")
|
|
(root / "node_modules").mkdir()
|
|
(root / ".git").mkdir()
|
|
|
|
response = client.get("/api/fs/list", params={"path": str(root)})
|
|
|
|
assert response.status_code == 200
|
|
entries = response.json()["entries"]
|
|
assert [entry["name"] for entry in entries] == ["a_dir", "a.txt", "b.txt"]
|
|
assert entries[0] == {"name": "a_dir", "path": str(root / "a_dir"), "isDirectory": True}
|
|
assert all(entry["name"] not in {".git", "node_modules"} for entry in entries)
|
|
|
|
|
|
def test_fs_read_data_url_rejects_over_cap(client, tmp_path, monkeypatch):
|
|
monkeypatch.setattr(web_server, "_FS_DATA_URL_MAX_BYTES", 3)
|
|
target = tmp_path / "image.png"
|
|
target.write_bytes(b"1234")
|
|
|
|
response = client.get("/api/fs/read-data-url", params={"path": str(target)})
|
|
|
|
assert response.status_code == 413
|
|
|
|
|
|
def test_fs_endpoints_require_auth(tmp_path):
|
|
client = TestClient(web_server.app)
|
|
target = tmp_path / "secret.txt"
|
|
target.write_text("secret")
|
|
|
|
list_response = client.get("/api/fs/list", params={"path": str(tmp_path)})
|
|
read_response = client.get("/api/fs/read-text", params={"path": str(target)})
|
|
default_response = client.get("/api/fs/default-cwd")
|
|
|
|
assert list_response.status_code == 401
|
|
assert read_response.status_code == 401
|
|
assert default_response.status_code == 401
|