mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
81 lines
3.7 KiB
Python
81 lines
3.7 KiB
Python
"""Tests for hermes tools disable/enable/list command (backend)."""
|
|
from argparse import Namespace
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.tools_config import tools_disable_enable_command
|
|
|
|
|
|
# ── Built-in toolset disable ────────────────────────────────────────────────
|
|
|
|
|
|
class TestToolsDisableBuiltin:
|
|
|
|
def test_disable_removes_toolset_from_platform(self):
|
|
config = {"platform_toolsets": {"cli": ["web", "memory", "terminal"]}}
|
|
with patch("hermes_cli.tools_config.load_config", return_value=config), \
|
|
patch("hermes_cli.tools_config.save_config") as mock_save:
|
|
tools_disable_enable_command(Namespace(tools_action="disable", names=["web"], platform="cli"))
|
|
saved = mock_save.call_args[0][0]
|
|
assert "web" not in saved["platform_toolsets"]["cli"]
|
|
assert "memory" in saved["platform_toolsets"]["cli"]
|
|
|
|
|
|
# ── Built-in toolset enable ─────────────────────────────────────────────────
|
|
|
|
|
|
# ── MCP tool disable ────────────────────────────────────────────────────────
|
|
|
|
|
|
class TestToolsDisableMcp:
|
|
|
|
|
|
def test_disable_unknown_server_prints_error(self, capsys):
|
|
config = {"mcp_servers": {}}
|
|
with patch("hermes_cli.tools_config.load_config", return_value=config), \
|
|
patch("hermes_cli.tools_config.save_config"):
|
|
tools_disable_enable_command(
|
|
Namespace(tools_action="disable", names=["unknown:tool"], platform="cli")
|
|
)
|
|
out = capsys.readouterr().out
|
|
assert "MCP server 'unknown' not found in config" in out
|
|
|
|
|
|
# ── MCP tool enable ──────────────────────────────────────────────────────────
|
|
|
|
|
|
# ── Mixed targets ────────────────────────────────────────────────────────────
|
|
|
|
|
|
# ── List output ──────────────────────────────────────────────────────────────
|
|
|
|
|
|
class TestToolsList:
|
|
|
|
|
|
def test_list_shows_mcp_excluded_tools(self, capsys):
|
|
config = {
|
|
"mcp_servers": {"github": {"tools": {"exclude": ["create_issue"]}}},
|
|
}
|
|
with patch("hermes_cli.tools_config.load_config", return_value=config):
|
|
tools_disable_enable_command(Namespace(tools_action="list", platform="cli"))
|
|
out = capsys.readouterr().out
|
|
assert "github" in out
|
|
assert "create_issue" in out
|
|
|
|
|
|
# ── Validation ───────────────────────────────────────────────────────────────
|
|
|
|
|
|
class TestToolsValidation:
|
|
|
|
|
|
def test_mixed_valid_and_invalid_applies_valid_only(self):
|
|
config = {"platform_toolsets": {"cli": ["web", "memory"]}}
|
|
with patch("hermes_cli.tools_config.load_config", return_value=config), \
|
|
patch("hermes_cli.tools_config.save_config") as mock_save:
|
|
tools_disable_enable_command(
|
|
Namespace(tools_action="disable", names=["web", "bad_toolset"], platform="cli")
|
|
)
|
|
saved = mock_save.call_args[0][0]
|
|
assert "web" not in saved["platform_toolsets"]["cli"]
|
|
assert "memory" in saved["platform_toolsets"]["cli"]
|