mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-27 11:22:03 +00:00
c39b2b50ee
Launching Hermes from a directory that ships its own top-level package with a
Hermes-internal name (utils/, proxy/, ui/) crashed the gateway/TUI child with
an ImportError (exit 1, crash loop): from utils import atomic_replace resolved
to the user's package.
tui_gateway/entry.py already stripped the relative cwd forms ('' / '.'), but
the launch dir also reaches sys.path as its own ABSOLUTE path (venv activation
or a project that adds itself to PYTHONPATH), which the strip missed and which
sat ahead of the Hermes root.
Centralize a hardened guard in hermes_bootstrap.harden_import_path(): drop the
relative forms AND force the Hermes source root to the front even when an
absolute cwd entry is present. Wire it into tui_gateway/entry.py and
acp_adapter/entry.py (both spawn into arbitrary cwds); hermes_cli/main.py and
gateway/run.py already insert the root at front. gatewayClient.ts now also
exports HERMES_PYTHON_SRC_ROOT for defense in depth.
81 lines
3 KiB
Python
81 lines
3 KiB
Python
"""Tests for tui_gateway/entry.py sys.path hardening (issues #15989, #51286).
|
|
|
|
When the TUI backend is spawned by Node.js, the launch directory may shadow
|
|
Hermes's own top-level modules (``utils``, ``proxy``, ``ui``). entry.py must
|
|
neutralize this before any non-stdlib import is resolved, by delegating to the
|
|
shared ``hermes_bootstrap.harden_import_path`` guard.
|
|
|
|
These tests assert the entry point wires up the real guard (rather than
|
|
re-implementing it inline) and that the guard's behavior covers both the
|
|
relative-cwd form and the absolute-cwd-path form that was the actual #51286
|
|
failure.
|
|
"""
|
|
|
|
import ast
|
|
import pathlib
|
|
|
|
import hermes_bootstrap
|
|
|
|
|
|
def _entry_source() -> str:
|
|
here = pathlib.Path(__file__).resolve()
|
|
repo_root = here.parent.parent.parent # tests/tui_gateway/ -> repo root
|
|
return (repo_root / "tui_gateway" / "entry.py").read_text(encoding="utf-8")
|
|
|
|
|
|
def test_entry_calls_shared_harden_guard_before_heavy_imports():
|
|
"""entry.py must call hermes_bootstrap.harden_import_path() before it
|
|
imports tui_gateway.server (which pulls ``from utils import ...``)."""
|
|
source = _entry_source()
|
|
tree = ast.parse(source)
|
|
|
|
harden_call_line = None
|
|
server_import_line = None
|
|
for node in ast.walk(tree):
|
|
if (
|
|
isinstance(node, ast.Call)
|
|
and isinstance(node.func, ast.Attribute)
|
|
and node.func.attr == "harden_import_path"
|
|
):
|
|
harden_call_line = node.lineno
|
|
if isinstance(node, ast.ImportFrom) and (node.module or "").startswith(
|
|
"tui_gateway"
|
|
):
|
|
if server_import_line is None:
|
|
server_import_line = node.lineno
|
|
|
|
assert harden_call_line is not None, (
|
|
"entry.py must call hermes_bootstrap.harden_import_path()"
|
|
)
|
|
assert server_import_line is not None, "entry.py must import from tui_gateway"
|
|
assert harden_call_line < server_import_line, (
|
|
"harden_import_path() must run before tui_gateway.server is imported"
|
|
)
|
|
|
|
|
|
def test_entry_does_not_reimplement_guard_inline():
|
|
"""The old inline ``{'', '.'}`` strip lived in entry.py; the dedicated
|
|
helper now owns it. Guard against the inline logic creeping back."""
|
|
source = _entry_source()
|
|
assert '{"", "."}' not in source and "{'', '.'}" not in source, (
|
|
"entry.py should delegate to hermes_bootstrap.harden_import_path, "
|
|
"not re-implement the sys.path strip inline"
|
|
)
|
|
|
|
|
|
def test_guard_handles_absolute_cwd_path():
|
|
"""The #51286 case: the launch dir is on sys.path as its own absolute
|
|
path, ahead of the Hermes root. harden_import_path must relocate the
|
|
Hermes root to the front so ``from utils import ...`` resolves to Hermes."""
|
|
import sys
|
|
|
|
original = sys.path[:]
|
|
try:
|
|
sys.path[:] = ["/home/user/tg-ws-proxy", "/opt/hermes", "/usr/lib"]
|
|
hermes_bootstrap.harden_import_path(src_root="/opt/hermes")
|
|
assert sys.path[0] == "/opt/hermes"
|
|
assert sys.path.index("/opt/hermes") < sys.path.index(
|
|
"/home/user/tg-ws-proxy"
|
|
)
|
|
finally:
|
|
sys.path[:] = original
|