mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
98 lines
3.5 KiB
Python
98 lines
3.5 KiB
Python
"""Tests for ``_get_cloud_provider()`` caching policy.
|
|
|
|
Regression coverage for issue #22324: a transient ``None`` from the resolver
|
|
must not be cached for the lifetime of the process. Cache only when:
|
|
|
|
* The user explicitly opts in to ``cloud_provider: local``, OR
|
|
* A provider is successfully resolved.
|
|
|
|
All other ``None`` outcomes (no credentials yet, config read error, explicit
|
|
provider instantiation failure) leave the cache unset so the next call retries.
|
|
"""
|
|
import logging
|
|
from unittest.mock import Mock
|
|
|
|
import pytest
|
|
|
|
import tools.browser_tool as browser_tool
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_resolver_state(monkeypatch):
|
|
monkeypatch.setattr(browser_tool, "_cached_cloud_provider", None)
|
|
monkeypatch.setattr(browser_tool, "_cloud_provider_resolved", False)
|
|
yield
|
|
|
|
|
|
class TestCloudProviderCachePolicy:
|
|
def test_explicit_local_caches_permanently(self, monkeypatch):
|
|
"""`cloud_provider: local` is a positive choice and must stick."""
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.read_raw_config",
|
|
lambda: {"browser": {"cloud_provider": "local"}},
|
|
)
|
|
|
|
assert browser_tool._get_cloud_provider() is None
|
|
assert browser_tool._cloud_provider_resolved is True
|
|
|
|
# Even if config later changes, the cache stays.
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.read_raw_config",
|
|
lambda: {"browser": {"cloud_provider": "browser-use"}},
|
|
)
|
|
assert browser_tool._get_cloud_provider() is None
|
|
|
|
|
|
def test_no_credentials_yet_does_not_cache_none(self, monkeypatch):
|
|
"""Auto-detect path with no creds: must NOT poison the cache."""
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.read_raw_config",
|
|
lambda: {"browser": {}},
|
|
)
|
|
|
|
bu_unconfigured = Mock()
|
|
bu_unconfigured.is_configured.return_value = False
|
|
bb_unconfigured = Mock()
|
|
bb_unconfigured.is_configured.return_value = False
|
|
monkeypatch.setattr(
|
|
browser_tool, "BrowserUseProvider", lambda: bu_unconfigured
|
|
)
|
|
monkeypatch.setattr(
|
|
browser_tool, "BrowserbaseProvider", lambda: bb_unconfigured
|
|
)
|
|
|
|
assert browser_tool._get_cloud_provider() is None
|
|
assert browser_tool._cloud_provider_resolved is False
|
|
|
|
# Credentials self-heal — next call must retry and pick up the provider.
|
|
healed = Mock(name="healed-provider")
|
|
healed.is_configured.return_value = True
|
|
monkeypatch.setattr(browser_tool, "BrowserUseProvider", lambda: healed)
|
|
|
|
assert browser_tool._get_cloud_provider() is healed
|
|
assert browser_tool._cloud_provider_resolved is True
|
|
|
|
|
|
def test_explicit_provider_instantiation_failure_does_not_cache(
|
|
self, monkeypatch, caplog
|
|
):
|
|
"""If `_PROVIDER_REGISTRY[key]()` raises, log warning and don't cache."""
|
|
def exploding_factory():
|
|
raise RuntimeError("missing dependency")
|
|
|
|
monkeypatch.setattr(
|
|
browser_tool, "_PROVIDER_REGISTRY", {"browser-use": exploding_factory}
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.read_raw_config",
|
|
lambda: {"browser": {"cloud_provider": "browser-use"}},
|
|
)
|
|
|
|
with caplog.at_level(logging.WARNING, logger="tools.browser_tool"):
|
|
assert browser_tool._get_cloud_provider() is None
|
|
|
|
assert browser_tool._cloud_provider_resolved is False
|
|
assert any(
|
|
"browser-use" in r.message and r.levelno == logging.WARNING
|
|
for r in caplog.records
|
|
)
|