mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
99 lines
3.8 KiB
Python
99 lines
3.8 KiB
Python
"""Platform/source tagging for the desktop chat surface.
|
|
|
|
The desktop app's chat panel uses ``hermes serve`` (the ``tui_gateway``
|
|
backend), so every chat session historically got ``platform="tui"`` stamped
|
|
on it — even though the user is in a graphical chat surface, not a
|
|
terminal. That mis-tag is why the agent suggested TUI-only slash commands
|
|
(like ``/reload-mcp``) to desktop chat users.
|
|
|
|
These tests pin the env-var matrix that resolves the session platform at
|
|
``tui_gateway`` session-creation time:
|
|
|
|
HERMES_DESKTOP=1, HERMES_DESKTOP_TERMINAL unset -> platform="desktop"
|
|
HERMES_DESKTOP=1, HERMES_DESKTOP_TERMINAL=1 -> platform="tui" (embedded pane)
|
|
neither set -> platform="tui" (standalone)
|
|
|
|
The resolver helper is import-safe (no heavy module side effects) so it
|
|
can be unit-tested without spinning up the full gateway.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
|
|
def _reload_resolver():
|
|
# Plain import — every resolver under test reads the env at CALL time, so
|
|
# no reload is needed. importlib.reload(tui_gateway.server) would
|
|
# re-register the module's atexit hooks (thread-pool shutdown +
|
|
# _shutdown_sessions) on every test; duplicated hooks race the stderr
|
|
# buffer at interpreter shutdown (Fatal Python error:
|
|
# _enter_buffered_busy) — same flake class as PR #34217. Name kept for
|
|
# the existing call sites.
|
|
import tui_gateway.server as _srv
|
|
return _srv
|
|
|
|
|
|
@pytest.fixture
|
|
def clean_env(monkeypatch):
|
|
monkeypatch.delenv("HERMES_DESKTOP", raising=False)
|
|
monkeypatch.delenv("HERMES_DESKTOP_TERMINAL", raising=False)
|
|
return monkeypatch
|
|
|
|
|
|
class TestResolveSessionPlatform:
|
|
def test_standalone_tui_neither_env_set(self, clean_env):
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_platform() == "tui"
|
|
|
|
def test_desktop_chat_backend_gets_desktop_tag(self, clean_env):
|
|
clean_env.setenv("HERMES_DESKTOP", "1")
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_platform() == "desktop"
|
|
|
|
|
|
@pytest.mark.parametrize("val", ["1", "true", "yes", "on", "TRUE", "Yes", "ON"])
|
|
def test_truthy_variants_recognized(self, clean_env, val):
|
|
clean_env.setenv("HERMES_DESKTOP", val)
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_platform() == "desktop"
|
|
|
|
@pytest.mark.parametrize("val", ["0", "false", "", "no", "off", "False"])
|
|
def test_falsy_variants_fall_back_to_tui(self, clean_env, val):
|
|
clean_env.setenv("HERMES_DESKTOP", val)
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_platform() == "tui"
|
|
|
|
def test_embedded_terminal_overrides_desktop_when_both_set(self, clean_env):
|
|
"""The terminal-pane qualifier must short-circuit the desktop-backend
|
|
marker. An embedded TUI is a TUI, not a desktop chat surface."""
|
|
clean_env.setenv("HERMES_DESKTOP", "1")
|
|
clean_env.setenv("HERMES_DESKTOP_TERMINAL", "true")
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_platform() == "tui"
|
|
|
|
|
|
class TestResolveSessionSource:
|
|
def test_explicit_source_param_wins(self, clean_env):
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_source("telegram") == "telegram"
|
|
|
|
|
|
def test_no_env_no_param_defaults_to_tui(self, clean_env):
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_session_source(None) == "tui"
|
|
|
|
|
|
class TestResolveAgentPlatform:
|
|
|
|
def test_missing_source_falls_back_to_env_resolved_platform(self, clean_env):
|
|
clean_env.setenv("HERMES_DESKTOP", "1")
|
|
_srv = _reload_resolver()
|
|
assert _srv._resolve_agent_platform(None) == "desktop"
|
|
|
|
|
|
class TestSessionSourceFallback:
|
|
def test_session_source_uses_existing_session_value(self, clean_env):
|
|
clean_env.setenv("HERMES_DESKTOP", "1")
|
|
_srv = _reload_resolver()
|
|
assert _srv._session_source({"source": "telegram"}) == "telegram"
|
|
|
|
|