mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
116 lines
4.8 KiB
Python
116 lines
4.8 KiB
Python
"""Tests for the OpenAI TTS `instructions` field passthrough.
|
|
|
|
Covers #14196: forwarding the OpenAI-spec `instructions` parameter through the
|
|
`text_to_speech` tool so the agent can control tone/emotion/pacing on
|
|
gpt-4o-mini-tts and OpenAI-compatible voice-design servers.
|
|
"""
|
|
|
|
import json
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def clean_env(monkeypatch):
|
|
for key in ("OPENAI_API_KEY", "HERMES_SESSION_PLATFORM"):
|
|
monkeypatch.delenv(key, raising=False)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Backend-level passthrough (_generate_openai_tts)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestOpenaiBackendInstructions:
|
|
def _run(self, tmp_path, monkeypatch, *, tts_config=None, instructions=None):
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
mock_client = MagicMock()
|
|
mock_client.audio.speech.create.return_value = MagicMock()
|
|
mock_cls = MagicMock(return_value=mock_client)
|
|
|
|
with patch("tools.tts_tool._import_openai_client", return_value=mock_cls), \
|
|
patch("tools.tts_tool._resolve_openai_audio_client_config",
|
|
return_value=("test-key", None, False)):
|
|
from tools.tts_tool import _generate_openai_tts
|
|
kwargs = {}
|
|
if instructions is not None:
|
|
kwargs["instructions"] = instructions
|
|
_generate_openai_tts(
|
|
"Hello", str(tmp_path / "out.mp3"), tts_config or {}, **kwargs
|
|
)
|
|
return mock_client.audio.speech.create
|
|
|
|
def test_instructions_forwarded_when_provided(self, tmp_path, monkeypatch):
|
|
"""Tool arg `instructions` is passed to audio.speech.create as-is."""
|
|
create = self._run(tmp_path, monkeypatch, instructions="Speak cheerfully.")
|
|
assert create.call_args[1]["instructions"] == "Speak cheerfully."
|
|
|
|
|
|
def test_empty_string_instructions_omitted(self, tmp_path, monkeypatch):
|
|
"""Empty string is treated as absent (not forwarded)."""
|
|
create = self._run(tmp_path, monkeypatch, instructions="")
|
|
assert "instructions" not in create.call_args[1]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Tool-level plumbing (text_to_speech_tool -> _generate_openai_tts)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestToolLevelInstructions:
|
|
def _invoke_tool(self, tmp_path, monkeypatch, *, instructions=None):
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
|
|
mock_client = MagicMock()
|
|
|
|
def fake_stream(path):
|
|
# Mimic OpenAI SDK's stream_to_file by writing a tiny payload.
|
|
with open(path, "wb") as f:
|
|
f.write(b"ID3\x03\x00\x00\x00\x00\x00\x00")
|
|
|
|
response = MagicMock()
|
|
response.stream_to_file.side_effect = fake_stream
|
|
mock_client.audio.speech.create.return_value = response
|
|
|
|
mock_cls = MagicMock(return_value=mock_client)
|
|
|
|
with patch("tools.tts_tool._import_openai_client", return_value=mock_cls), \
|
|
patch("tools.tts_tool._resolve_openai_audio_client_config",
|
|
return_value=("test-key", None, False)), \
|
|
patch("tools.tts_tool._load_tts_config",
|
|
return_value={"provider": "openai"}):
|
|
from tools.tts_tool import text_to_speech_tool
|
|
kwargs = {"output_path": str(tmp_path / "out.mp3")}
|
|
if instructions is not None:
|
|
kwargs["instructions"] = instructions
|
|
result = text_to_speech_tool("Hello world", **kwargs)
|
|
return mock_client.audio.speech.create, json.loads(result)
|
|
|
|
def test_tool_threads_instructions_to_openai_create(
|
|
self, tmp_path, monkeypatch
|
|
):
|
|
create, result = self._invoke_tool(
|
|
tmp_path, monkeypatch, instructions="Whisper conspiratorially."
|
|
)
|
|
assert result.get("success") is True
|
|
assert create.call_args[1]["instructions"] == "Whisper conspiratorially."
|
|
|
|
def test_tool_omits_instructions_when_not_supplied(
|
|
self, tmp_path, monkeypatch
|
|
):
|
|
create, result = self._invoke_tool(tmp_path, monkeypatch)
|
|
assert result.get("success") is True
|
|
assert "instructions" not in create.call_args[1]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Schema
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSchema:
|
|
def test_schema_exposes_instructions_parameter(self):
|
|
from tools.tts_tool import TTS_SCHEMA
|
|
props = TTS_SCHEMA["parameters"]["properties"]
|
|
assert "instructions" in props
|
|
assert props["instructions"]["type"] == "string"
|
|
# Must stay optional — current behavior must be preserved.
|
|
assert "instructions" not in TTS_SCHEMA["parameters"].get("required", [])
|